Skip to content

[HOLD for payment 2023-05-04] ON HOLD [$1000] Suggestion text below company address is not visible when we don't select any suggested option but it is visible in every other cases #16448

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. Open Workspaces
  3. Open any workspace
  4. Open connect bank account
  5. Click on connect manually
  6. Fill in step 1 information (eg data: routing number = 210021002, acc no = 1234)
  7. In company address, type in address but don't select any option and after typing, select city below
  8. Observe that suggestion text below company address is gone
  9. Fill in other details, click on continue and click on back and obserce that suggestion text below company address is back
  10. Click on back few times and click on startover, again fill in step 6 details and observe that company address has suggestion text below it
  11. Type in address and select any one suggestion and observe that company address has suggestion text below it

Expected Result:

App should display suggestion text below company address if user decides to fill it on their own and not use the suggested addresses

Actual Result:

App does not display suggestion text below company address if user decides to fill it on their own and if suggestions were still displayed before user tries to move to fill in other details

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.88-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

suggested.text.not.displayed.issue.mp4
Recording.27.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679566976110789

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018ed613b675853bc5
  • Upwork Job ID: 1641411262190702592
  • Last Price Increase: 2023-03-30

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 23, 2023
  2. MelvinBot commented on Mar 23, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. MelvinBot commented on Mar 23, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. zanyrenney commented on Mar 27, 2023

    @zanyrenney
    Contributor

    I'm not sure if this constitutes a bug, so need to check on this and bring a conversation to bug0.

  5. zanyrenney commented on Mar 30, 2023

    @zanyrenney
    Contributor

    I guess looking at this again, it is inconsistent so makes sense to progress forward here.

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 30, 2023
  7. changed the title [-]Suggestion text below company address is not visible when we don't select any suggested option but it is visible in every other cases[/-] [+][$1000] Suggestion text below company address is not visible when we don't select any suggested option but it is visible in every other cases[/+] on Mar 30, 2023
  8. MelvinBot commented on Mar 30, 2023

    @MelvinBot
    Contributor
  9. 62 remaining items

  10. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 10, 2023
  11. removed their assignment
    on May 10, 2023
  12. melvin-bot commented on May 10, 2023

    @melvin-bot

    Current assignee @conorpendergrast is eligible for the Bug assigner, not assigning anyone new.

  13. melvin-bot commented on May 10, 2023

    @melvin-bot
  14. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 10, 2023
  15. melvin-bot commented on May 10, 2023

    @melvin-bot

    Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  16. melvin-bot commented on May 10, 2023

    @melvin-bot
  17. conorpendergrast commented on May 10, 2023

    @conorpendergrast
    Contributor

    @sophiepintoraetz Sorry to bring you in on this too Sophie! I am OoO until Monday and in the interest of these payments being overdue, I wanted to make sure they didn't have to wait until then.

    Once you and @iwiznia have agreed if the bonuses are due, then the contracts here can be paid. I've already paid the issue reporter!

  18. iwiznia commented on May 10, 2023

    @iwiznia
    Contributor

    Yep, agree on bonuses

  19. conorpendergrast commented on May 10, 2023

    @conorpendergrast
    Contributor

    Ionatan is speedy, so I'm doing the payments. Wrap-up steps are yours, Sophie!

  20. conorpendergrast commented on May 10, 2023

    @conorpendergrast
    Contributor

    Payments done

  21. sophiepintoraetz commented on May 12, 2023

    @sophiepintoraetz
    Contributor

    QA steps requested here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions