Repository navigation
[HOLD for payment 2023-05-05] [$1000] Long pressing on emoji suggestions highlights the text/attachments behind the emoji list on mweb #16485
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- First of all , open android app, go to any chat, type in :per (to get the suggestion list)
- Now long press any of the emoji from the suggestion list and notice that the emoji gets placed on the chat box
- Next, repeat the same steps on mweb chrome and notice that in mweb,the emoji doesn’t gets placed on the chat box instead it highlights the text or attachments (anything that is present behind the suggestion list)
Expected Result:
There should be consistency between the mweb and android/web where long pressing the emoji from the suggestion list should place the emoji on the chat box on mweb
Actual Result:
Long pressing the emoji in the emoji suggestion list selects the text/attachment (any text) behind the suggestion list on mweb chrome
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.2.88-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
emojierror.mp4
az_recorder_20230324_133659.1.mp4
Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1679662560223179
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0170cd69222271989f
- Upwork Job ID: 1640771245599219712
- Last Price Increase: 2023-04-18
Activity
MelvinBot commentedon Mar 24, 2023
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Mar 24, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)MelvinBot commentedon Mar 27, 2023
@garrettmknight Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
garrettmknight commentedon Mar 28, 2023
Confirmed, agree that we should make this consistent and the expected result makes sense.
[-]Long pressing on emoji suggestions highlights the text/attachments behind the emoji list on mweb[/-][+][$1000] Long pressing on emoji suggestions highlights the text/attachments behind the emoji list on mweb[/+]MelvinBot commentedon Mar 28, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0170cd69222271989f
MelvinBot commentedon Mar 28, 2023
Current assignee @garrettmknight is eligible for the External assigner, not assigning anyone new.
MelvinBot commentedon Mar 28, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (
External)93 remaining items
MelvinBot commentedon Apr 28, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.7-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-05-05. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
MelvinBot commentedon Apr 28, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
rushatgabhane commentedon May 5, 2023
Checklist to please the bot :)
The PR that introduced the bug has been identified. Link to the PR: Static emoji autosuggestion #14686
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Static emoji autosuggestion #14686 (comment)
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not required because this is an extreme edge case for mWeb android only.
Determine if we should create a regression test for this bug - Not required. This is an extreme edge case for mWeb android only.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.
melvin-bot commentedon May 8, 2023
@tgolen, @ntdiary, @michaelhaxhiu, @rushatgabhane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
michaelhaxhiu commentedon May 8, 2023
edit:
Buddy check, seems there is no speed bonus applied to this PR right?A speed bonus should apply for the C and C+.
cc @ntdiary and @rushatgabhane
rushatgabhane commentedon May 9, 2023
@michaelhaxhiu looks like there is a timeline bonus as per https://ex-syt.glitch.me/
michaelhaxhiu commentedon May 9, 2023
Ahh the ol "3 business days" caught me up! Thanks for that :)
michaelhaxhiu commentedon May 9, 2023
Ok so, these are the payouts:
michaelhaxhiu commentedon May 9, 2023
Just waiting on @rushatgabhane to accept the job and I can pay/close.
michaelhaxhiu commentedon May 9, 2023
Paid all parties