Repository navigation
[HOLD for payment 2023-05-05] [$2000] Uploading gif image seems to fluctuate the image while previewing it immediately after uploading #16528
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open web chrome and open any chat and send a message
- Now click on profile icon and upload a gif image. Crop the image to full.
- From the chat, click on your profile picture and preview it.
- First Bug : Notice that the image fluctuates
- Second Bug : Also, sometimes an empty attachment also gets displayed (This is not easily reproducible) For this, upload a large jpg/png file without cropping and try to preview the image immediately. It displays an empty attachment. - Not able to reproduce for me
Expected Result:
The image shouldn’t fluctuate while trying to preview the image
Actual Result:
The image fluctuates while trying to preview the image
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.2.89-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Recording.62.mp4
photoerror-2023-03-26_14.16.52.mp4
photoerror-2023-03-26_14.09.59.mp4
Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation:
https://expensify.slack.com/archives/C049HHMV9SM/p1679819714964549
View all open jobs on GitHub
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01afe7983a04d30b23
- Upwork Job ID: 1643073372561469440
- Last Price Increase: 2023-04-25
Activity
MelvinBot commentedon Mar 26, 2023
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Mar 26, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)marcaaron commentedon Mar 27, 2023
Feels questionable whether we should allow uploading an animated gif as a profile pic.
priya-zha commentedon Mar 27, 2023
video-2023-03-27_16.54.41.mp4
@marcaaron It happens with normal images too. Can you please try to view any profile picture of the user. It seems to fluctuate with normal images too, not only with gifs.
stephanieelliott commentedon Mar 29, 2023
Hm, I'm not seeing that behavior occur on static images, like .jpg. For me, it's only happening with .gifs.
Agree with @marcaaron that we probably shouldn't support .gifs in that field, posted in Slack to discuss: https://expensify.slack.com/archives/C01SKUP7QR0/p1680106537787609
stephanieelliott commentedon Apr 4, 2023
OK it sounds like we had previously agreed to allow a GIF and convert it to JPG (context). So I suppose this does need to be fixed.
[-]Uploading gif image seems to fluctuate the image while previewing it immediately after uploading[/-][+][$1000] Uploading gif image seems to fluctuate the image while previewing it immediately after uploading[/+]MelvinBot commentedon Apr 4, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01afe7983a04d30b23
MelvinBot commentedon Apr 4, 2023
Current assignee @stephanieelliott is eligible for the External assigner, not assigning anyone new.
42 remaining items
[-][$2000] Uploading gif image seems to fluctuate the image while previewing it immediately after uploading[/-][+][HOLD for payment 2023-05-05] [$2000] Uploading gif image seems to fluctuate the image while previewing it immediately after uploading[/+]MelvinBot commentedon Apr 28, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".MelvinBot commentedon Apr 28, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.7-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-05-05. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
MelvinBot commentedon Apr 28, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
danieldoglas commentedon May 8, 2023
@eVoloshchak can you please fill the checklist above?
@stephanieelliott I think this is ready for payment
eVoloshchak commentedon May 9, 2023
The PR that introduced the bug has been identified. Link to the PR: Add feature to view Profile Picture in full screen #8483
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Add feature to view Profile Picture in full screen #8483 (comment)
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This is an edge case since it requires you to preview the image immediately after uploading, so it's hard to reproduce unless on a slow connection. I've asked here whether we should add "I throttled my network connection and tested it with slow connection to ensure it matches the expected behaviour" item to checklist
Determine if we should create a regression test for this bug.
Is it easy to test for this bug? Yes
Is the bug related to an important user flow? (For example, adding a bank account) No
Is it an impactful bug? No
I don't think regression test is needed here. This is reproducible using only a slow connection and has a very low impact
stephanieelliott commentedon May 10, 2023
Getting ready to pay (just waiting on offer acceptance in Upwork) - looks like the job was assigned on 4/13, all reviewed and all changes resolved on 4/18. Then on 4/18 another bug surfaced, we discussed and eventually decided to fix it in the same PR on 4/21. PR was finally merged on 4/16.
For the purposes of calculating the speed bonus/penalty, I am going to use the date that comments were resolved on the original bug (4/18) as the "merge date". 4/13 assignment vs 4/18 merge = 5 days, so this one is not eligible for the speed bonus nor will it face a penalty, so the payment will be $2,000.
tienifr commentedon May 11, 2023
@stephanieelliott hi, I think there're 2 days of weekends between 4/13 and 4/18, kindly consider that in the calculations as well.
Thanks you!
stephanieelliott commentedon May 12, 2023
Oh, thanks @tienifr I hadn't thought about that -- thanks for calling that out! Everyone is paid out, C and C+ w/ bonus