Repository navigation
[$2000] Web -Chat - Line breaks are not displayed correctly after special copy/paste scenario #16668
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when executing PR #16464
Action Performed:
There will be 2 test cases:
Test case 1 (Test issue in previous PR) - Use the following text for the test (it has 4 newlines + has web link):
I'm around if you are and wanna hop on a call https://meet.google.com/yjx-maas-pku
Nothing specific in mind
Test case 2 (Test the current issue) - Use the following text for the test (it has 4 newlines + no web link):
I hope you have a good day
Cheers
Follow the steps for both scenario or you can use PR link above
- Copy that text in Test case 1
- Paste it normally into the chat composer using ctrl+v
- Verify that it still contains the 4 newlines
- Paste it without formatting into the chat composer user ctrl+shift+v
- Verify that it still contains the 4 newlines and no more
- Send the message
- Copy the previous message by right-clicking the message and select copy it to clipboard
- Repeat steps 2-5
- Copy the message by clicking the copy to clipboard in the hover menu
- Repeat steps 2-5
- Copy the message by highlighting all the text of the comment, right-click the message > select copy to clipboard
- Repeat steps 2-5
- Copy text inside the composer input that contains newlines by using ctrl+c
- Repeat steps 2-5
- Copy text inside the composer input that contains newlines by using ctrl+x
- Repeat steps 2-5
- Repeat steps 1->16 for Test case 2
Expected Result:
- It has 4 newlines + has web link
- It has 4 newlines + no web link
Actual Result:
Scenario 1:
Step 5. 3 lines instead of 4 for both
Step 8. Paste it without formatting into the chat composer user ctrl+shift+v - 7 lines instead 4
Step 11. two ways is failed - 7 lines instead of 4
Step 13. two ways is failed - 7 lines instead of 4
Scenario 2:
Step 5. 3 lines instead of 4 for both
Step 8. Paste it without formatting into the chat composer user ctrl+shift+v - 7 lines instead 4
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- Windows/ Chrome
- MacOS / Desktop
Version Number: 1.2.91.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
16464.Web.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~013db20b7edebe8630
- Upwork Job ID: 1651166295134699520
- Last Price Increase: 2023-05-04
Activity
MelvinBot commentedon Mar 29, 2023
Triggered auto assignment to @kevinksullivan (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Mar 29, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)kevinksullivan commentedon Mar 31, 2023
hi @kbecciv I assume based on the other PR this is specific to MacOS / Chrome / Safari ?
kevinksullivan commentedon Mar 31, 2023
Also, are you saying I should test both test case 1 AND 2? Or, because that other issue exists, I'll just do test case 2?
kbecciv commentedon Mar 31, 2023
Hey @kevinksullivan The tester was QAring on Windows/Chrome, updated the environment.
Both scenario did not work correctly, to test both test case 1 AND 2 will be better.
kevinksullivan commentedon Mar 31, 2023
Ok, thanks @kbecciv . Next question here. What exactly should I do for these test cases? The steps says:
You're saying in the first test I should take this text and go test the other PR?
Then, for test 2, you're saying I copy/paste this?
I'm a bit confused since you say these have 4 "new lines", but I don't understand how you're getting that number?
MelvinBot commentedon Apr 4, 2023
@kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!
kevinksullivan commentedon Apr 5, 2023
@kbecciv feel free to assign me back once you've clarified. Just want to make sure I understand how this is supposed to work, since there are a lot of steps here!
38 remaining items
eVoloshchak commentedon May 1, 2023
Not overdue, this is awaiting proposals
grgia commentedon May 1, 2023
Awaiting proposals
sakluger commentedon May 4, 2023
It's been a week with no proposals, let's increase the price.
[-][$1000] Web -Chat - Line breaks are not displayed correctly after special copy/paste scenario[/-][+][$2000] Web -Chat - Line breaks are not displayed correctly after special copy/paste scenario[/+]MelvinBot commentedon May 4, 2023
Upwork job price has been updated to $2000
sakluger commentedon May 8, 2023
I'm actually going to close this one out. I think there's a good chance that there is something specific to the GH formatting that causes the NewLine to not appear when pasting with formatting, and so there's a good chance this is expected behavior.