You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Android - Chat - In offline mode, protected PDF file shows "Failed to load PDF file" messages. #16694
Can we even load this offline at this point? I have the same question as I did here re: image caching being the precursor to then supporting caching of other file types.
I think this is an interesting case actually b/c technically the only image caching we've discussed so far for PDFs is the PDF "Preview" - and since this is a protected PDF, mayyyybe we don't even want to cache such previews?
That being said, I do think we still need to wait on the full image caching solution b/c I think it will help with a lot of related caching discussions
@trjExpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Activity
MelvinBot commentedon Mar 29, 2023
Triggered auto assignment to @trjExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Mar 29, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)trjExpensify commentedon Mar 30, 2023
Can we even load this offline at this point? I have the same question as I did here re: image caching being the precursor to then supporting caching of other file types.
CC: @thomas-coldwell @Beamanator @marcaaron @aimane-chnaif
MelvinBot commentedon Apr 3, 2023
@trjExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
MelvinBot commentedon Apr 5, 2023
@trjExpensify Eep! 4 days overdue now. Issues have feelings too...
MelvinBot commentedon Apr 7, 2023
@trjExpensify Still overdue 6 days?! Let's take care of this!
trjExpensify commentedon Apr 11, 2023
Hey Melv, I'm back!
Didn't get an answer on this. @thomas-coldwell @Beamanator @marcaaron @aimane-chnaif what do you guys think? I believe this is held on us figuring out image caching first and then expanding that solution to other file types.
Beamanator commentedon Apr 11, 2023
Aah shucks sorry for the late response!
I think this is an interesting case actually b/c technically the only image caching we've discussed so far for PDFs is the PDF "Preview" - and since this is a protected PDF, mayyyybe we don't even want to cache such previews?
That being said, I do think we still need to wait on the full image caching solution b/c I think it will help with a lot of related caching discussions
trjExpensify commentedon Apr 11, 2023
It would show some kind of "locked" preview though wouldn't it? Instead of an error message or a grey screen etc?
MelvinBot commentedon Apr 12, 2023
@trjExpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
66 remaining items
trjExpensify commentedon Jun 3, 2024
Interesting! @eh2077 are you still able to reproduce on Android, and if so, can you share the steps with @b4s36t4?
eh2077 commentedon Jun 4, 2024
I'll check this tmr
melvin-bot commentedon Jun 4, 2024
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
eh2077 commentedon Jun 5, 2024
@trjExpensify I can't reproduce it on the emulator.
@mollfpr Are you still able to reproduce it?
mvtglobally commentedon Jun 5, 2024
Issue not reproducible during KI retests. (First week)
trjExpensify commentedon Jun 5, 2024
Sounds promising. @mollfpr can retry and then we can close if he can't either. I don't have an Android device.
mvtglobally commentedon Jun 10, 2024
Issue not reproducible during KI retests. (Second week)
eh2077 commentedon Jun 10, 2024
Not overdue, issue is not reproducible
melvin-bot commentedon Jun 11, 2024
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
eh2077 commentedon Jun 11, 2024
@trjExpensify I managed to test on an Android device and it's not reproducible
w_756d736983559b7332f27ba1eba4cb8675c108f6-2024-06-11.16_22_19.372.mp4
eh2077 commentedon Jun 11, 2024
So, I think we can close this. Do you agree?
trjExpensify commentedon Jun 11, 2024
Yep, let's close. Sounds good!