Skip to content

[$250] Android - Chat - In offline mode, protected PDF file shows "Failed to load PDF file" messages. #16694

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the App
  2. Login with any account
  3. Navigate to any conversation
  4. Send 2 password protected PDF
  5. Tap on it
  6. Tap "Enter the password" > enter password
  7. Close protected PDF file
  8. Dissable the internet connection
  9. Tap on the protected PDF submitted file

Expected Result:

In offline mode, protected PDF file should NOT show the"Failed to load PDF file" message.

Actual Result:

In offline mode, protected PDF file shows Failed to load PDF file" messages.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.91.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5997620_Screen_Recording_20230329_202256_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c405d2bc500b7f64
  • Upwork Job ID: 1795516458922020864
  • Last Price Increase: 2024-06-11
Issue OwnerCurrent Issue Owner: @eh2077

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 29, 2023
  2. MelvinBot commented on Mar 29, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. MelvinBot commented on Mar 29, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. trjExpensify commented on Mar 30, 2023

    @trjExpensify
    Contributor

    Can we even load this offline at this point? I have the same question as I did here re: image caching being the precursor to then supporting caching of other file types.

    CC: @thomas-coldwell @Beamanator @marcaaron @aimane-chnaif

  5. MelvinBot commented on Apr 3, 2023

    @MelvinBot
    Contributor

    @trjExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  6. MelvinBot commented on Apr 5, 2023

    @MelvinBot
    Contributor

    @trjExpensify Eep! 4 days overdue now. Issues have feelings too...

  7. MelvinBot commented on Apr 7, 2023

    @MelvinBot
    Contributor

    @trjExpensify Still overdue 6 days?! Let's take care of this!

  8. trjExpensify commented on Apr 11, 2023

    @trjExpensify
    Contributor

    Hey Melv, I'm back!

    Didn't get an answer on this. @thomas-coldwell @Beamanator @marcaaron @aimane-chnaif what do you guys think? I believe this is held on us figuring out image caching first and then expanding that solution to other file types.

  9. Beamanator commented on Apr 11, 2023

    @Beamanator
    Contributor

    Aah shucks sorry for the late response!

    I think this is an interesting case actually b/c technically the only image caching we've discussed so far for PDFs is the PDF "Preview" - and since this is a protected PDF, mayyyybe we don't even want to cache such previews?

    That being said, I do think we still need to wait on the full image caching solution b/c I think it will help with a lot of related caching discussions

  10. trjExpensify commented on Apr 11, 2023

    @trjExpensify
    Contributor

    and since this is a protected PDF, mayyyybe we don't even want to cache such previews?

    It would show some kind of "locked" preview though wouldn't it? Instead of an error message or a grey screen etc?

  11. MelvinBot commented on Apr 12, 2023

    @MelvinBot
    Contributor

    @trjExpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  12. 66 remaining items

  13. trjExpensify commented on Jun 3, 2024

    @trjExpensify
    Contributor
    • Launch the App
    • Login with any account
    • Navigate to any conversation
    • Send 2 password protected PDF
    • Tap on it
    • Tap "Enter the password" > enter password
    • Close protected PDF file
    • Dissable the internet connection
    • Tap on the protected PDF submitted file

    Interesting! @eh2077 are you still able to reproduce on Android, and if so, can you share the steps with @b4s36t4?

  14. eh2077 commented on Jun 4, 2024

    @eh2077
    Contributor

    I'll check this tmr

  15. melvin-bot commented on Jun 4, 2024

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  16. eh2077 commented on Jun 5, 2024

    @eh2077
    Contributor

    @trjExpensify I can't reproduce it on the emulator.

    @mollfpr Are you still able to reproduce it?

  17. mvtglobally commented on Jun 5, 2024

    @mvtglobally

    Issue not reproducible during KI retests. (First week)

  18. trjExpensify commented on Jun 5, 2024

    @trjExpensify
    Contributor

    Sounds promising. @mollfpr can retry and then we can close if he can't either. I don't have an Android device.

  19. mvtglobally commented on Jun 10, 2024

    @mvtglobally

    Issue not reproducible during KI retests. (Second week)

  20. eh2077 commented on Jun 10, 2024

    @eh2077
    Contributor

    Not overdue, issue is not reproducible

  21. melvin-bot commented on Jun 11, 2024

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  22. eh2077 commented on Jun 11, 2024

    @eh2077
    Contributor

    @trjExpensify I managed to test on an Android device and it's not reproducible

    w_756d736983559b7332f27ba1eba4cb8675c108f6-2024-06-11.16_22_19.372.mp4
  23. eh2077 commented on Jun 11, 2024

    @eh2077
    Contributor

    So, I think we can close this. Do you agree?

  24. trjExpensify commented on Jun 11, 2024

    @trjExpensify
    Contributor

    Yep, let's close. Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions