[HOLD for payment 2023-05-22] [N7 Account Settings] Add "Set as default" flow for Contact Methods

Part of the bigger "Account Settings" project - https://github.com/Expensify/Expensify/issues/182122

This is one of the last pieces of this project!!

Goals for this issue:

Hook up "Set as default" button in Contact Method Details page
Make sure the command works & all offline UX for this flow is perfecto 👍

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01673504ee586cd7d6
Upwork Job ID: 1643963070269542400
Last Price Increase: 2023-04-06

Holding on this for a sec while I sort out https://github.com/Expensify/Web-Expensify/pull/36916

Job added to Upwork: https://www.upwork.com/jobs/~01673504ee586cd7d6

@aimane-chnaif

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

Finally got both PRs out for review for this!

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Add ability to set a contact method your default contact method #16750

If no regressions arise, payment will be issued on 2023-05-22. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@aimane-chnaif

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
[@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@aimane-chnaif] Determine if we should create a regression test for this bug.
[@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@Beamanator

@Beamanator - are we able to discuss payment? I'm about to go OOO so would be good to get this sorted today.

@sophiepintoraetz

@sophiepintoraetz - hey yes! No regressions thankfully! So @aimane-chnaif is due $1000 for testing the internal PR, but I would recommend a bump up to $2000 because @aimane-chnaif did a LOT of testing, found lots of useful bugs and / or useful followup conversations 💪

Offer sent!

Paid - we're all set here.

Navigation Menu

Repository navigation

[HOLD for payment 2023-05-22] [N7 Account Settings] Add "Set as default" flow for Contact Methods #16747

16 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-05-22] [N7 Account Settings] Add "Set as default" flow for Contact Methods #16747

Description

Activity

Beamanator commented on Mar 30, 2023

MelvinBot commented on Apr 6, 2023

MelvinBot commented on Apr 6, 2023

Beamanator commented on Apr 6, 2023

16 remaining items

melvin-bot commented on May 15, 2023

melvin-bot commented on May 15, 2023

melvin-bot commented on May 15, 2023

sophiepintoraetz commented on May 22, 2023

Beamanator commented on May 22, 2023

sophiepintoraetz commented on May 22, 2023

sophiepintoraetz commented on May 22, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions