[$1000] A failed IOU request has the “Cancel” feature as a successful IOU request and able to cancel the request

@Natnael-Guchima

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Click on “Profile” avatar
Click on “Preference” link
Turn on “Simulate a network failure”
Open an existing chat
Click on “Actions” icon
Click on “Request money” link
Enter “Amount” and click on “Next” button
Click on “Request” button
Turn off “Simualte a network failure”
Observe that Money request has an error message
Click on the newly created IOU
Observe that the failed “Cancel” button is active
Click on the “Cancel” button

Expected Result:

“Cancel” button for failed IOUs shouldn't be clickable and should be disabled or hidden from the UI

Actual Result:

“Cancel” button for failed IOUs is active and clickable

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.2.92-0
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-03-30.10.40.19.mp4

Recording.99.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680162826186869

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017fdfc602b8fa6805
Upwork Job ID: 1651528714235252736
Last Price Increase: 2023-05-10

@greg-schroeder

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Reviewing now

@Natnael-Guchima

Hmm. I couldn't reproduce this where the error message pops up after simulating a network failure and then disabling that - it didn't show an error at all. I tested on staging.

@Natnael-Guchima can you check your reproduction steps to make sure nothing is missing?

@greg-schroeder

One minute, @greg-schroeder. Let me check and get back to you.

@greg-schroeder

2023-04-05.19.56.24.mp4

I can reproduce it in staging, @greg-schroeder.

Steps:

Open an existing chat
Click profile avatar
Click on preferences
Turn on simulate a failing network
Close settings
Click on 'Actions' icon > Request Money > enter amount & submit
Click on profile avatar > Preferences > Turn off simulate a network failure
Close setting

The above step should produce the error message. If error is thrown open the failed IOU and click on 'Cancel' button

@Natnael-Guchima

I'm currently seeing Delete instead of Cancel. Was the copy changed at some point?

No, cancel and decline buttons are removed in favor of the new Delete button on this PR

@Natnael-Guchima Thanks for the reply. So is this bug still applicable? But instead of Cancel, we should disable Delete if the request failed?

You are welcome @akinwale. I am not sure if this bug is still applicable. I haven't heard anything from internal team on weather to pursue this or not.

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Cancel" button in the IOU details modal is being displayed for failed IOU requests. It is assumed that the Cancel button has been replaced by the "Delete" button based on this PR: #17583. This proposal will assume the Delete button going forward.

What is the root cause of that problem?

The filter for deletable transactions in the getDeletableTransactions method for IOUTransactions does not check for transactions that have a pendingAction. Hence, the Delete button is shown for failed transactions which have a pending action.

App/src/pages/iou/IOUTransactions.js

Lines 67 to 74 in 1b1e562

    
               return _.chain(actionsForIOUReport) 
        
                   .filter((action) => action.originalMessage.type === CONST.IOU.REPORT_ACTION_TYPE.CREATE) 
        
                   .filter((action) => !_.contains(deletedTransactionIDs, action.originalMessage.IOUTransactionID)) 
        
                   .filter((action) => this.props.userEmail === action.actorEmail) 
        
                   .map((action) => lodashGet(action, 'originalMessage.IOUTransactionID', '')) 
        
                   .compact() 
        
                   .value(); 
        
           }

What changes do you think we should make in order to solve the problem?

Add a filter to remove transactions that have a pendingAction of add in the getDeletableTransactions method.

.filter((action) => action.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD)

Alternatively, if the button should not be displayed for all transactions that have a pending action, then the filter can be defined as such:

.filter((action) => _.isEmpty(lodashGet(action, 'pendingAction', '')))

What alternative solutions did you explore? (Optional)

None.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The failed IOU request is still deleable

What is the root cause of that problem?

In

App/src/pages/iou/IOUTransactions.js

Lines 67 to 74 in 1ee8cf8

    
               return _.chain(actionsForIOUReport) 
        
                   .filter((action) => action.originalMessage.type === CONST.IOU.REPORT_ACTION_TYPE.CREATE) 
        
                   .filter((action) => !_.contains(deletedTransactionIDs, action.originalMessage.IOUTransactionID)) 
        
                   .filter((action) => this.props.userEmail === action.actorEmail) 
        
                   .map((action) => lodashGet(action, 'originalMessage.IOUTransactionID', '')) 
        
                   .compact() 
        
                   .value(); 
        
           }

We get the deletable transactions without filtering out the errors transaction

What changes do you think we should make in order to solve the problem?

Solution 1: If we don't want to show the delete button

Filter out the error action by adding the following line:

.filter((action) => !action.errors)

Solution 2: If we want to disable the delete button

add a new props (shouldDisableDelete) to ReportTransaction
check if it is the error transaction set shouldDisableDelete= true, otherwise false

Improvement

We should move this line

App/src/pages/iou/IOUTransactions.js

Line 86 in 1ee8cf8

const deletableTransactions = this.getDeletableTransactions();

outside of map function to improve performance.

What alternative solutions did you explore? (Optional)

@tienifr

@tienifr your proposal with solution 1 LGTM 👍🏼

@tienifr

📣 @tienifr You have been assigned to this job by @roryabraham!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

Also, would love to see some automated tests cover this change 🙏🏼

@roryabraham

@roryabraham thanks for the proposal review in advance. @tienifr's Solution 1 looks good to me too!
👍 on some automated tests cover this change

Per discussion:

Looking at the reproduction steps, I don’t think this is relevant anymore. We are deprecating cancel (though not delete).

We're going to close the issue/PR and pay this out.

@tienifr

@tienifr, @Natnael-Guchima, @0xmiroslav offers sent

@tienifr

@tienifr, @Natnael-Guchima, @0xmiroslav offers sent

Accepted. Thanks!

Navigation Menu

Repository navigation

[$1000] A failed IOU request has the “Cancel” feature as a successful IOU request and able to cancel the request #16748

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

40 remaining items

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	return _.chain(actionsForIOUReport)
	.filter((action) => action.originalMessage.type === CONST.IOU.REPORT_ACTION_TYPE.CREATE)
	.filter((action) => !_.contains(deletedTransactionIDs, action.originalMessage.IOUTransactionID))
	.filter((action) => this.props.userEmail === action.actorEmail)
	.map((action) => lodashGet(action, 'originalMessage.IOUTransactionID', ''))
	.compact()
	.value();
	}

[$1000] A failed IOU request has the “Cancel” feature as a successful IOU request and able to cancel the request #16748

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

MelvinBot commented on Mar 30, 2023

MelvinBot commented on Mar 30, 2023

Bug0 Triage Checklist (Main S/O)

MelvinBot commented on Apr 3, 2023

greg-schroeder commented on Apr 5, 2023

greg-schroeder commented on Apr 5, 2023

Natnael-Guchima commented on Apr 5, 2023

Natnael-Guchima commented on Apr 5, 2023

40 remaining items

Natnael-Guchima commented on May 10, 2023

akinwale commented on May 10, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

tienifr commented on May 11, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

roryabraham commented on May 11, 2023

melvin-bot commented on May 11, 2023

roryabraham commented on May 11, 2023

0xmiroslav commented on May 12, 2023

greg-schroeder commented on May 16, 2023

greg-schroeder commented on May 16, 2023

Natnael-Guchima commented on May 16, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions