Skip to content

[$1000] App changes the language of the user if previous user language was different #16749

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app in web chrome and login with User A
  2. Ensure that User A language is English
  3. Open the app in Android and login with User B
  4. Ensure the language for User B in Spanish
  5. Logout from android app and login again with user A

Expected Result:

User A language in android app should be English as it was set in web chrome

Actual Result:

App changes the language of user A to Spanish on app as well as chrome even though user A was already logged in web chrome and language was set to English

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.92-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

ScreenRecorderProject1.mp4
Screenrecorder-2023-03-30-13-17-10-159.mp4
az_recorder_20230330_111951.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680164016638469

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01118f6910510d5429
  • Upwork Job ID: 1643656041671368704
  • Last Price Increase: 2023-04-05

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 30, 2023
  2. MelvinBot commented on Mar 30, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. MelvinBot commented on Mar 30, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. MelvinBot commented on Apr 3, 2023

    @MelvinBot
    Contributor

    @greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick!

  5. greg-schroeder commented on Apr 5, 2023

    @greg-schroeder
    Contributor

    Reviewing now

  6. deleted a comment from MelvinBot on Apr 5, 2023
  7. changed the title [-] App changes the language of the user if previous user language was different.[/-] [+] App changes the language of the user if previous user language was different[/+] on Apr 5, 2023
  8. greg-schroeder commented on Apr 5, 2023

    @greg-schroeder
    Contributor

    Reproduced this on android and web chrome, issue looks good. Marking External

  9. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 5, 2023
  10. changed the title [-] App changes the language of the user if previous user language was different[/-] [+][$1000] App changes the language of the user if previous user language was different[/+] on Apr 5, 2023
  11. MelvinBot commented on Apr 5, 2023

    @MelvinBot
    Contributor
  12. 2 remaining items

  13. MelvinBot commented on Apr 5, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

  14. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 5, 2023
  15. MelvinBot commented on Apr 5, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @hayata-suenaga (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  16. 0xmiroslav commented on Apr 5, 2023

    @0xmiroslav
    Contributor

    We already raised and discussed this concern here.
    And landed at depending on language selected on Login page.
    cc: @puneetlath

  17. parasharrajat commented on Apr 5, 2023

    @parasharrajat
    Member

    This might not be a bug but an enhancement. The current logic is that app will respect the language set on the latest device while login.

    So the current device language is not default(English), then change the user language to set language on that device. As you log in when the Spanish language was active on the device and this is your recent device, the language choice will be picked from it.

    @dhanashree-sawant Can you pleas raise this to Slack and confirm?

  18. parasharrajat commented on Apr 5, 2023

    @parasharrajat
    Member

    Oh, just saw your comment @0xmiroslav. 👍

  19. greg-schroeder commented on Apr 5, 2023

    @greg-schroeder
    Contributor

    Okay. I think it makes sense to respect the most recent choice, but it's odd that it respects it across accounts. With that said, I'm not sure why anyone would be logging into multiple accounts from the same device and have different preferences for language

  20. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 5, 2023
  21. greg-schroeder commented on Apr 5, 2023

    @greg-schroeder
    Contributor

    I'm going to remove help wanted for now

  22. dhanashree-sawant commented on Apr 5, 2023

    @dhanashree-sawant

    Hi @parasharrajat, sorry I am confused, do I need to raise the concern on slack for it? seems like @0xmiroslav comment has clarified that part. Let me know if you need anything now from me, I will be available.

  23. parasharrajat commented on Apr 5, 2023

    @parasharrajat
    Member

    but it's odd that it respects it across accounts

    @greg-schroeder it is not like that. What happening is that when you log out from your account the app language is set to Spanish bcz you have the option to change the language from the Login screen. Then if you log in to any account the language will remain Spanish. So it has nothing to do with multiple acc logins.

    @dhanashree-sawant I wasn't sure that it was discussed earlier but it seems that it has been #16749 (comment). So if you still disagree feel free to discuss this on Slack as a P/S statement and if something changed we can reopen this issue.

    For now, we can close this issue @greg-schroeder

  24. greg-schroeder commented on Apr 5, 2023

    @greg-schroeder
    Contributor

    Ah, okay, that makes it very clear. Thanks Rajat. Definitely closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions