You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$1000] App changes the language of the user if previous user language was different #16749
Logout from android app and login again with user A
Expected Result:
User A language in android app should be English as it was set in web chrome
Actual Result:
App changes the language of user A to Spanish on app as well as chrome even though user A was already logged in web chrome and language was set to English
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.2.92-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-] App changes the language of the user if previous user language was different.[/-][+] App changes the language of the user if previous user language was different[/+]on Apr 5, 2023
changed the title [-] App changes the language of the user if previous user language was different[/-][+][$1000] App changes the language of the user if previous user language was different[/+]on Apr 5, 2023
This might not be a bug but an enhancement. The current logic is that app will respect the language set on the latest device while login.
So the current device language is not default(English), then change the user language to set language on that device. As you log in when the Spanish language was active on the device and this is your recent device, the language choice will be picked from it.
Okay. I think it makes sense to respect the most recent choice, but it's odd that it respects it across accounts. With that said, I'm not sure why anyone would be logging into multiple accounts from the same device and have different preferences for language
Hi @parasharrajat, sorry I am confused, do I need to raise the concern on slack for it? seems like @0xmiroslav comment has clarified that part. Let me know if you need anything now from me, I will be available.
@greg-schroeder it is not like that. What happening is that when you log out from your account the app language is set to Spanish bcz you have the option to change the language from the Login screen. Then if you log in to any account the language will remain Spanish. So it has nothing to do with multiple acc logins.
@dhanashree-sawant I wasn't sure that it was discussed earlier but it seems that it has been #16749 (comment). So if you still disagree feel free to discuss this on Slack as a P/S statement and if something changed we can reopen this issue.
Activity
MelvinBot commentedon Mar 30, 2023
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Mar 30, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)MelvinBot commentedon Apr 3, 2023
@greg-schroeder Whoops! This issue is 2 days overdue. Let's get this updated quick!
greg-schroeder commentedon Apr 5, 2023
Reviewing now
[-] App changes the language of the user if previous user language was different.[/-][+] App changes the language of the user if previous user language was different[/+]greg-schroeder commentedon Apr 5, 2023
Reproduced this on android and web chrome, issue looks good. Marking
External[-] App changes the language of the user if previous user language was different[/-][+][$1000] App changes the language of the user if previous user language was different[/+]MelvinBot commentedon Apr 5, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01118f6910510d5429
2 remaining items
MelvinBot commentedon Apr 5, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (
External)MelvinBot commentedon Apr 5, 2023
Triggered auto assignment to @hayata-suenaga (
External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.0xmiroslav commentedon Apr 5, 2023
We already raised and discussed this concern here.
And landed at depending on language selected on Login page.
cc: @puneetlath
parasharrajat commentedon Apr 5, 2023
This might not be a bug but an enhancement. The current logic is that app will respect the language set on the latest device while login.
So the current device language is not default(English), then change the user language to set language on that device. As you log in when the Spanish language was active on the device and this is your recent device, the language choice will be picked from it.
@dhanashree-sawant Can you pleas raise this to Slack and confirm?
parasharrajat commentedon Apr 5, 2023
Oh, just saw your comment @0xmiroslav. 👍
greg-schroeder commentedon Apr 5, 2023
Okay. I think it makes sense to respect the most recent choice, but it's odd that it respects it across accounts. With that said, I'm not sure why anyone would be logging into multiple accounts from the same device and have different preferences for language
greg-schroeder commentedon Apr 5, 2023
I'm going to remove
help wantedfor nowdhanashree-sawant commentedon Apr 5, 2023
Hi @parasharrajat, sorry I am confused, do I need to raise the concern on slack for it? seems like @0xmiroslav comment has clarified that part. Let me know if you need anything now from me, I will be available.
parasharrajat commentedon Apr 5, 2023
@greg-schroeder it is not like that. What happening is that when you log out from your account the app language is set to Spanish bcz you have the option to change the language from the Login screen. Then if you log in to any account the language will remain Spanish. So it has nothing to do with multiple acc logins.
@dhanashree-sawant I wasn't sure that it was discussed earlier but it seems that it has been #16749 (comment). So if you still disagree feel free to discuss this on Slack as a P/S statement and if something changed we can reopen this issue.
For now, we can close this issue @greg-schroeder
greg-schroeder commentedon Apr 5, 2023
Ah, okay, that makes it very clear. Thanks Rajat. Definitely closing.