Repository navigation
[Fabric] IOS - Log in - App flickers when open it #16799
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Close the NewDot app.
- Open NewDot app
- Put your credentials
- Close the app and re-open the app
Expected Result:
App is not flickering when open it
Actual Result:
App flickers when open it
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.2.88.0
Reproducible in staging?: NO
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug5999778_flash_ios.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Activity
MelvinBot commentedon Mar 31, 2023
Triggered auto assignment to @tjferriss (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Mar 31, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)j-piasecki commentedon Apr 6, 2023
Hi! I'll be working on this issue.
WoLewicki commentedon Apr 6, 2023
Hi! I'll be working on this issue.
WoLewicki commentedon Apr 27, 2023
This issue seems to be the result of two separate issues, first being
Bootsplashlibrary not working on Fabric, so it does not disappear only after the content is ready, which has been fixed with36a6ff5(#13767). Second was the jumping caused by the avatar image rendering only after the onyx state is resolved. While it was loading,nullis rendered by onyx, and the style of the whole element depends on the style ofAvatarWithIndicatorcomponent. Since it changes fromnullto a view withheight: 40, the whole header gets bigger height and the content below jumps a bit.We believe it should not be like that. The placeholder for the image should be visible from the beginning since it does not use any of the onyx data. We moved the part that uses onyx to the separate
Indicatorcomponent and it works just fine then:8a3b24f(#13767). wdyt @mountiny @roryabraham @AndrewGable ?As a side note, this was not visible on the old arch, but we are not sure why. Maybe because the rerenders are batched more often then and the state with
nullinstead of content does not render, or maybe we just did not spot such case and it is an issue there too.mountiny commentedon Apr 27, 2023
I think that sounds as a good solution and also great investigation @WoLewicki
roryabraham commentedon Apr 27, 2023
Yeah, that sounds like a good solution.
This is a bit of a separate conversation, but I've recently been thinking we should change Onyx to remove that behavior and just make subscribers responsible for handling when the data is not present. The only trick is that it's not easy to tell the difference between "data not read yet" and "data not present", but I'm not sure if that really matters.
This would also enable us to make a
useOnyxhook, which we can't necessarily do without breaking this behavior of renderingnullwhile data is being loaded.j-piasecki commentedon Jun 20, 2023
No longer flickering when building the app from the current (WoLewicki@e12c1cf)
andrew-fabricbranch:ios-startup.mov
melvin-bot commentedon Sep 4, 2023
@j-piasecki, @WoLewicki, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.