You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-04-26] [$1000] Red dot remains visible on chat after a failed attachment is deleted #16852
Observe that the failed attachment is deleted, and the corresponding error indicator ‘Red dot’ remains visible on the chat
Expected Result:
Red dot shouldn’t remain visible after a filed attachment is deleted
Actual Result:
Red dot remains visible after a failed attachment is deleted
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.2.93-4 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-]Red dot remains visible on chat after a failed attachment is deleted[/-][+][$1000] Red dot remains visible on chat after a failed attachment is deleted[/+]on Apr 5, 2023
No PRs caused regression. It would be have been better to handle this case while migrating DeleteComment api in #9532.
As this is edge case, I don't think regression step is needed here.
Activity
MelvinBot commentedon Apr 1, 2023
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Apr 1, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)MelvinBot commentedon Apr 5, 2023
@bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
bfitzexpensify commentedon Apr 5, 2023
Think this is valid for external
[-]Red dot remains visible on chat after a failed attachment is deleted[/-][+][$1000] Red dot remains visible on chat after a failed attachment is deleted[/+]MelvinBot commentedon Apr 5, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01365275cfe90a2203
MelvinBot commentedon Apr 5, 2023
Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.
38 remaining items
bfitzexpensify commentedon Apr 27, 2023
Offers sent out for payment
bfitzexpensify commentedon Apr 27, 2023
I think adding a regression test here is a good idea, perhaps in the Compose box - Attachment only (Offline Behavior) test
Natnael-Guchima commentedon Apr 27, 2023
Accepted. Thanks 🙏.
bfitzexpensify commentedon May 1, 2023
@0xmiroslav please review the items in #16852 (comment) when you get a chance - thanks!
neil-marcellini commentedon May 3, 2023
Bump @0xmiroslav
0xmiroslav commentedon May 3, 2023
No PRs caused regression. It would be have been better to handle this case while migrating
DeleteCommentapi in #9532.As this is edge case, I don't think regression step is needed here.
bfitzexpensify commentedon May 5, 2023
Thanks @0xmiroslav. I think we are good to close this one out now.