Skip to content

[HOLD for payment 2023-04-26] [$1000] Red dot remains visible on chat after a failed attachment is deleted #16852

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Click on “Profile” avatar
  2. Click on “Preference” link
  3. Turn on “Simulate a network failure”
  4. Open an existing chat
  5. Click on “Actions” icon
  6. Click on “Add attachment” link
  7. Select a picture of file
  8. Wait few seconds
  9. Turn off “Simulate a network failure”
  10. Click on “Delete” icon on the failed attachment
  11. Observe that the failed attachment is deleted, and the corresponding error indicator ‘Red dot’ remains visible on the chat

Expected Result:

Red dot shouldn’t remain visible after a filed attachment is deleted

Actual Result:

Red dot remains visible after a failed attachment is deleted

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.93-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.123.mp4
2023-03-31.10.52.31.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680249331562699

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01365275cfe90a2203
  • Upwork Job ID: 1643570634344288256
  • Last Price Increase: 2023-04-12

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 1, 2023
  2. MelvinBot commented on Apr 1, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. MelvinBot commented on Apr 1, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. MelvinBot commented on Apr 5, 2023

    @MelvinBot
    Contributor

    @bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  5. bfitzexpensify commented on Apr 5, 2023

    @bfitzexpensify
    Contributor

    Think this is valid for external

  6. changed the title [-]Red dot remains visible on chat after a failed attachment is deleted[/-] [+][$1000] Red dot remains visible on chat after a failed attachment is deleted[/+] on Apr 5, 2023
  7. MelvinBot commented on Apr 5, 2023

    @MelvinBot
    Contributor
  8. MelvinBot commented on Apr 5, 2023

    @MelvinBot
    Contributor

    Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.

  9. 38 remaining items

  10. bfitzexpensify commented on Apr 27, 2023

    @bfitzexpensify
    Contributor

    Offers sent out for payment

  11. bfitzexpensify commented on Apr 27, 2023

    @bfitzexpensify
    Contributor

    I think adding a regression test here is a good idea, perhaps in the Compose box - Attachment only (Offline Behavior) test

  12. Natnael-Guchima commented on Apr 27, 2023

    @Natnael-Guchima

    Offers sent out for payment

    Accepted. Thanks 🙏.

  13. bfitzexpensify commented on May 1, 2023

    @bfitzexpensify
    Contributor

    @0xmiroslav please review the items in #16852 (comment) when you get a chance - thanks!

  14. neil-marcellini commented on May 3, 2023

    @neil-marcellini
    Contributor
  15. 0xmiroslav commented on May 3, 2023

    @0xmiroslav
    Contributor

    No PRs caused regression. It would be have been better to handle this case while migrating DeleteComment api in #9532.
    As this is edge case, I don't think regression step is needed here.

  16. bfitzexpensify commented on May 5, 2023

    @bfitzexpensify
    Contributor

    Thanks @0xmiroslav. I think we are good to close this one out now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions