You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Workspace - Infinite loading displayed for second device after delete the Workspace as admin. #16915
Precognition:
2 accounts are needed for the following tests, 1 Admin and 1 user
With one of the accounts, log in, create a workspace and invite the other account to the workspace.
Log in with the same workspace admin account on the main device and the employee in the secondary device/ navigate to #announce room
Navigate to a Workspace settings
Delete the workspace by click/tap on the 3 dots > Delete workspace
Check secondary device
Expected Result:
"Hmm. it's not here . You don't have access to this chat" should be appeared for second device.
Actual Result:
Infinite loading displayed for second device after delete WS as admin.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Web - Workspace - Infinite loading displayed for second device after delete the Workspace as admin.[/-][+]Workspace - Infinite loading displayed for second device after delete the Workspace as admin.[/+]on Apr 4, 2023
The report object still exists in Onyx but has some extra fields, investigating that (specifically why isLoadingReportActions is true is staging and dev but not in prod)
I think what was happening is we make a call to OpenReport in the client after the workspace is deleted in the other device and that call was successful but returned no data and a jsonCode: 403
That caused a failure but there was no Onyx failure data that switched the state of isLoadingReportActions back to false.
Activity
OSBotify commentedon Apr 4, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:MelvinBot commentedon Apr 4, 2023
Triggered auto assignment to @PauloGasparSv (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.kbecciv commentedon Apr 4, 2023
Issue is not reproduced in Production, adding Deploy Blocker Label.
[-]Web - Workspace - Infinite loading displayed for second device after delete the Workspace as admin.[/-][+]Workspace - Infinite loading displayed for second device after delete the Workspace as admin.[/+]PauloGasparSv commentedon Apr 4, 2023
Shifting my focus to this!
PauloGasparSv commentedon Apr 4, 2023
Great! Was able to replicate this in Web : D
Local:
Staging:

PauloGasparSv commentedon Apr 4, 2023
This may be caused because the report data is still in Onyx after the deletion but the reportActions are removed
Still couldn't figure out which P.R. introduced this but it may be API related
PauloGasparSv commentedon Apr 4, 2023
For some reason this logic in the API isn't clearing the
report_<ReportID>object but instead turning it into this thingPauloGasparSv commentedon Apr 4, 2023
Strange thing is that commenting this logic solves the issue! But that logic should be in production, so I'll test production here.
cc @roryabraham if you have any ideas on this as the logic I commented was introduced in this P.R.
After commenting those lines:


PauloGasparSv commentedon Apr 4, 2023
Also couldn't replicate the issue in production!
The report object still exists in Onyx but has some extra fields, investigating that (specifically why
isLoadingReportActionsis true is staging and dev but not in prod)PauloGasparSv commentedon Apr 4, 2023
All right, I think
isLoadingReportActionsis being updated wrong now!Couldn't find any recent changes or the P.R. that introduced this bug yet.
Taking a break for lunch but I'll get back to this ASAP.
situchan commentedon Apr 4, 2023
This might have same root cause as #16897
MelvinBot commentedon Apr 4, 2023
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
PauloGasparSv commentedon Apr 4, 2023
Thanks @situchan!
Testing the P.R. #16918 right now, I think it will fix this
cc @marcaaron
PauloGasparSv commentedon Apr 4, 2023
Yup, the changes from #16918 fix this!
I think what was happening is we make a call to
OpenReportin the client after the workspace is deleted in the other device and that call was successful but returned no data and ajsonCode: 403That caused a failure but there was no Onyx failure data that switched the state of
isLoadingReportActionsback to false.That may be related to https://github.com/Expensify/Web-Expensify/pull/36929
PauloGasparSv commentedon Apr 4, 2023
#16918 Got merged! Keeping an eye on it.
PauloGasparSv commentedon Apr 4, 2023
P.R. is in staging, re-testing this!
PauloGasparSv commentedon Apr 4, 2023
Changes from #16918 fixed this and were CP'd to staging so closing it off!