You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$1000] Inconsistent padding inbetween lines below Say Hello! for DM and workspace room chats #17094
On any workspace chat and observe text below 'Say Hello!' in the top
Open any individual user text
Observe text below 'Say Hello!' in the top
Expected Result:
App should keep equal space between lines in introduction text below 'Say Hello!' on workspace chats and individual user chats
Actual Result:
App has considerably more space between lines in introduction text below 'Say Hello!' on individual user chats then on workspace chats
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.2.96-3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-]Inconsistent padding inbetween lines below Say Hello! for DM and workspace room chats[/-][+][$1000] Inconsistent padding inbetween lines below Say Hello! for DM and workspace room chats[/+]on Apr 7, 2023
Please re-state the problem that we are trying to solve in this issue.
Extra line break in DM chat when compared to workspace chat.
What is the root cause of that problem?
Existence of two newlines in the usePlusButton property.
What changes do you think we should make in order to solve the problem?
We should remove one newline from usePlusButton.
What alternative solutions did you explore? (Optional)
Solution 1: Do nothing. The text shown in workspace is in context to what is being talked about, while the text about plus button is an extra addition.
Activity
MelvinBot commentedon Apr 6, 2023
Triggered auto assignment to @puneetlath (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Apr 6, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)[-]Inconsistent padding inbetween lines below Say Hello! for DM and workspace room chats[/-][+][$1000] Inconsistent padding inbetween lines below Say Hello! for DM and workspace room chats[/+]MelvinBot commentedon Apr 7, 2023
Job added to Upwork: https://www.upwork.com/jobs/~017453ee971033575f
MelvinBot commentedon Apr 7, 2023
Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.
MelvinBot commentedon Apr 7, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (
External)MelvinBot commentedon Apr 7, 2023
Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.
Prince-Mendiratta commentedon Apr 7, 2023
@puneetlath what's the expected behaviour here? To have the extra padding or not?
Pujan92 commentedon Apr 7, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Fewer line breaks in the begginingChatHistory for the rooms.
What is the root cause of that problem?
Currently, single line break is given to those strings(
...RoomPartOne)App/src/languages/en.js
Lines 253 to 260 in 64f4a78
What changes do you think we should make in order to solve the problem?
Adding extra line break which makes(\n\n) for those 4
...RoomPartOnestrings in en.js & es.js will make it consistent with the DM chat history view.App/src/languages/en.js
Lines 253 to 260 in 64f4a78
Result
Screen.Recording.2023-04-08.at.12.15.25.AM.mp4
Prince-Mendiratta commentedon Apr 7, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Extra line break in DM chat when compared to workspace chat.
What is the root cause of that problem?
Existence of two newlines in the
usePlusButtonproperty.What changes do you think we should make in order to solve the problem?
We should remove one newline from
usePlusButton.What alternative solutions did you explore? (Optional)
Solution 1: Do nothing. The text shown in workspace is in context to what is being talked about, while the text about plus button is an extra addition.
parasharrajat commentedon Apr 7, 2023
I think this is international. I reviewed the original PR which added this and it was raised #13647 (comment). This was the answer #13647 (comment).
@shawnborton What are your thoughts now?
shawnborton commentedon Apr 7, 2023
Hmm yeah, I don't think there is a bug here, going to close.