Skip to content

[$1000] Inconsistent padding inbetween lines below Say Hello! for DM and workspace room chats #17094

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. On any workspace chat and observe text below 'Say Hello!' in the top
  3. Open any individual user text
  4. Observe text below 'Say Hello!' in the top

Expected Result:

App should keep equal space between lines in introduction text below 'Say Hello!' on workspace chats and individual user chats

Actual Result:

App has considerably more space between lines in introduction text below 'Say Hello!' on individual user chats then on workspace chats

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.96-3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

inconsitent.padding.in.text.below.say.hello.mp4
Recording.149.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680764206149349

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017453ee971033575f
  • Upwork Job ID: 1644409720206995456
  • Last Price Increase: 2023-04-07

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 6, 2023
  2. MelvinBot commented on Apr 6, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. MelvinBot commented on Apr 6, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 7, 2023
  5. changed the title [-]Inconsistent padding inbetween lines below Say Hello! for DM and workspace room chats[/-] [+][$1000] Inconsistent padding inbetween lines below Say Hello! for DM and workspace room chats[/+] on Apr 7, 2023
  6. MelvinBot commented on Apr 7, 2023

    @MelvinBot
    Contributor
  7. MelvinBot commented on Apr 7, 2023

    @MelvinBot
    Contributor

    Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

  8. MelvinBot commented on Apr 7, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 7, 2023
  10. MelvinBot commented on Apr 7, 2023

    @MelvinBot
    Contributor

    Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

  11. Prince-Mendiratta commented on Apr 7, 2023

    @Prince-Mendiratta
    Contributor

    @puneetlath what's the expected behaviour here? To have the extra padding or not?

  12. Pujan92 commented on Apr 7, 2023

    @Pujan92
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Fewer line breaks in the begginingChatHistory for the rooms.

    What is the root cause of that problem?

    Currently, single line break is given to those strings(...RoomPartOne)

    App/src/languages/en.js

    Lines 253 to 260 in 64f4a78

    beginningOfChatHistoryDomainRoomPartOne: ({domainRoom}) => `Collaboration with everyone at ${domainRoom} starts here! 🎉\nUse `,
    beginningOfChatHistoryDomainRoomPartTwo: ' to chat with colleagues, share tips, and ask questions.',
    beginningOfChatHistoryAdminRoomPartOne: ({workspaceName}) => `Collaboration among ${workspaceName} admins starts here! 🎉\nUse `,
    beginningOfChatHistoryAdminRoomPartTwo: ' to chat about topics such as workspace configurations and more.',
    beginningOfChatHistoryAnnounceRoomPartOne: ({workspaceName}) => `Collaboration between all ${workspaceName} members starts here! 🎉\nUse `,
    beginningOfChatHistoryAnnounceRoomPartTwo: ({workspaceName}) => ` to chat about anything ${workspaceName} related.`,
    beginningOfChatHistoryUserRoomPartOne: 'Collaboration starts here! 🎉\nUse this space to chat about anything ',
    beginningOfChatHistoryUserRoomPartTwo: ' related.',

    What changes do you think we should make in order to solve the problem?

    Adding extra line break which makes(\n\n) for those 4 ...RoomPartOne strings in en.js & es.js will make it consistent with the DM chat history view.

    App/src/languages/en.js

    Lines 253 to 260 in 64f4a78

    beginningOfChatHistoryDomainRoomPartOne: ({domainRoom}) => `Collaboration with everyone at ${domainRoom} starts here! 🎉\nUse `,
    beginningOfChatHistoryDomainRoomPartTwo: ' to chat with colleagues, share tips, and ask questions.',
    beginningOfChatHistoryAdminRoomPartOne: ({workspaceName}) => `Collaboration among ${workspaceName} admins starts here! 🎉\nUse `,
    beginningOfChatHistoryAdminRoomPartTwo: ' to chat about topics such as workspace configurations and more.',
    beginningOfChatHistoryAnnounceRoomPartOne: ({workspaceName}) => `Collaboration between all ${workspaceName} members starts here! 🎉\nUse `,
    beginningOfChatHistoryAnnounceRoomPartTwo: ({workspaceName}) => ` to chat about anything ${workspaceName} related.`,
    beginningOfChatHistoryUserRoomPartOne: 'Collaboration starts here! 🎉\nUse this space to chat about anything ',
    beginningOfChatHistoryUserRoomPartTwo: ' related.',

    Result
    Screen.Recording.2023-04-08.at.12.15.25.AM.mp4
  13. Prince-Mendiratta commented on Apr 7, 2023

    @Prince-Mendiratta
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Extra line break in DM chat when compared to workspace chat.

    What is the root cause of that problem?

    Existence of two newlines in the usePlusButton property.

    What changes do you think we should make in order to solve the problem?

    We should remove one newline from usePlusButton.

    What alternative solutions did you explore? (Optional)

    Solution 1: Do nothing. The text shown in workspace is in context to what is being talked about, while the text about plus button is an extra addition.

  14. parasharrajat commented on Apr 7, 2023

    @parasharrajat
    Member

    I think this is international. I reviewed the original PR which added this and it was raised #13647 (comment). This was the answer #13647 (comment).

    @shawnborton What are your thoughts now?

  15. shawnborton commented on Apr 7, 2023

    @shawnborton
    Contributor

    Hmm yeah, I don't think there is a bug here, going to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions