You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Hold] Notification received for sent and deleted message in offline #17197
Wait a couple of seconds and observe the notification panel
Expected Result:
The deleted message should not appear on the notification panel on android.
Actual Result:
The deleted message appears on the notification panel on the receiving account’s phone and its content can be seen.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
[] MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.2.97-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
probably since this is most likely dealing with Pusher events. I just learned about this tracking issue #12775? which is dealing with "replay effect" of actions which I think is probably the underlying issue here.
changed the title [-]Notification received for sent and deleted message in offline[/-][+][Hold] Notification received for sent and deleted message in offline[/+]on Apr 14, 2023
@bondydaa I don't think the replay effect will fix this, because the server will still receive an AddComment request and an EditComment request to delete the message, so we will still send the notification when adding the comment. I think that's fine actually, it's equivalent to adding and deleting a comment quickly while online.
Yeah I would close this. Someday in the future we might build request de-duplication, which would fix this, but so far no one has proposed anything and I think it's pretty complicated and low ROI.
Activity
MelvinBot commentedon Apr 9, 2023
Triggered auto assignment to @arielgreen (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Apr 9, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)MelvinBot commentedon Apr 12, 2023
@arielgreen Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
arielgreen commentedon Apr 13, 2023
Confirmed reproducible.
MelvinBot commentedon Apr 13, 2023
Job added to Upwork: https://www.upwork.com/jobs/~019363c7307b2d17b5
MelvinBot commentedon Apr 13, 2023
Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (
Internal)MelvinBot commentedon Apr 13, 2023
Triggered auto assignment to @bondydaa (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.arielgreen commentedon Apr 13, 2023
@bondydaa I am like 98% sure notifications issues like this need to be internal -- can you confirm?
bondydaa commentedon Apr 13, 2023
probably since this is most likely dealing with Pusher events. I just learned about this tracking issue #12775? which is dealing with "replay effect" of actions which I think is probably the underlying issue here.
bondydaa commentedon Apr 14, 2023
let's hold this for #12775 as well
[-]Notification received for sent and deleted message in offline[/-][+][Hold] Notification received for sent and deleted message in offline[/+]neil-marcellini commentedon Apr 24, 2023
@bondydaa I don't think the replay effect will fix this, because the server will still receive an AddComment request and an EditComment request to delete the message, so we will still send the notification when adding the comment. I think that's fine actually, it's equivalent to adding and deleting a comment quickly while online.
bondydaa commentedon Apr 26, 2023
hmm gotcha. so are you suggesting then that we close this out?
neil-marcellini commentedon Apr 27, 2023
Yeah I would close this. Someday in the future we might build request de-duplication, which would fix this, but so far no one has proposed anything and I think it's pretty complicated and low ROI.
bondydaa commentedon Apr 27, 2023
:woohoo: I love :do-nothing: