Skip to content

[Hold] Notification received for sent and deleted message in offline #17197

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open a chat on desktop
  2. Go offline
  3. Send a message and delete the message
  4. Go online
  5. Open android app on the receiving account
  6. Wait a couple of seconds and observe the notification panel

Expected Result:

The deleted message should not appear on the notification panel on android.

Actual Result:

The deleted message appears on the notification panel on the receiving account’s phone and its content can be seen.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • [] MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.97-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20230408_155931_New.Expensify.mp4
2023-04-08.16.04.07.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680959362130529

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019363c7307b2d17b5
  • Upwork Job ID: 1646322139844620288
  • Last Price Increase: 2023-04-13

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 9, 2023
  2. MelvinBot commented on Apr 9, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @arielgreen (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. MelvinBot commented on Apr 9, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. MelvinBot commented on Apr 12, 2023

    @MelvinBot
    Contributor

    @arielgreen Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  5. arielgreen commented on Apr 13, 2023

    @arielgreen
    Contributor

    Confirmed reproducible.

  6. added
    InternalRequires API changes or must be handled by Expensify staff
    on Apr 13, 2023
  7. MelvinBot commented on Apr 13, 2023

    @MelvinBot
    Contributor
  8. MelvinBot commented on Apr 13, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @s77rt (Internal)

  9. MelvinBot commented on Apr 13, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  10. arielgreen commented on Apr 13, 2023

    @arielgreen
    Contributor

    @bondydaa I am like 98% sure notifications issues like this need to be internal -- can you confirm?

  11. bondydaa commented on Apr 13, 2023

    @bondydaa
    Contributor

    probably since this is most likely dealing with Pusher events. I just learned about this tracking issue #12775? which is dealing with "replay effect" of actions which I think is probably the underlying issue here.

  12. bondydaa commented on Apr 14, 2023

    @bondydaa
    Contributor

    let's hold this for #12775 as well

  13. changed the title [-]Notification received for sent and deleted message in offline[/-] [+][Hold] Notification received for sent and deleted message in offline[/+] on Apr 14, 2023
  14. neil-marcellini commented on Apr 24, 2023

    @neil-marcellini
    Contributor

    @bondydaa I don't think the replay effect will fix this, because the server will still receive an AddComment request and an EditComment request to delete the message, so we will still send the notification when adding the comment. I think that's fine actually, it's equivalent to adding and deleting a comment quickly while online.

  15. bondydaa commented on Apr 26, 2023

    @bondydaa
    Contributor

    hmm gotcha. so are you suggesting then that we close this out?

  16. neil-marcellini commented on Apr 27, 2023

    @neil-marcellini
    Contributor

    Yeah I would close this. Someday in the future we might build request de-duplication, which would fix this, but so far no one has proposed anything and I think it's pretty complicated and low ROI.

  17. bondydaa commented on Apr 27, 2023

    @bondydaa
    Contributor

    :woohoo: I love :do-nothing:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringInternalRequires API changes or must be handled by Expensify staffMonthlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions