Skip to content

Detected language preference on the sign-in page doesn’t persist across the app #17215

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Verify that App's language preference is set to English
  2. Set your device/browser language preference to Spanish
  3. Navigate to 'Sign In' screen
  4. Verify if the 'Sign-in' page's translations are in Spanish
  5. Enter email address and click on ‘Continue’ button
  6. Enter password and click on ‘Sign in’ button

Expected Result:

Detected device’s/browser’s language preference should persist throughout the app

Actual Result:

Detected device’s/browser’s language preference don't persist throughout the app

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.2.97-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.186.mp4
2023-04-09.22.31.29.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681074474757409

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 9, 2023
  2. MelvinBot commented on Apr 9, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @arielgreen (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. MelvinBot commented on Apr 9, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. arielgreen commented on Apr 13, 2023

    @arielgreen
    Contributor

    This is expected and accurate behavior. If my selected language in the app is one Expensify supports (such as English) then I would expect that to be the language displayed, regardless of what my OS/browser selection is.

    I performed the steps exactly as described. I saw Spanish on the sign in page. Once logged into my account, Expensify was in English, which makes sense as that is my selected language.

    Closing.

  5. Natnael-Guchima commented on Apr 13, 2023

    @Natnael-Guchima

    @arielgreen This PR seems to claim that the detected preferred language should persist across the app.

  6. Natnael-Guchima commented on Apr 13, 2023

    @Natnael-Guchima

    Also, can you take a look at this Slack thread -> ‘Write something…’ in composer flashes from Spanish to English when a user changes browser/device language preference to Spanish and Sign-in. If the above behavior is expected this issue on the Slack thread might be a bug.

  7. Natnael-Guchima commented on Apr 16, 2023

    @Natnael-Guchima

    Hello @puneetlath, is a detected language preference not persisting throughout the app an expected behavior? Also, please, can you take a look at an observation I mentioned here ^? It is related to detecting language preference.

  8. puneetlath commented on Apr 16, 2023

    @puneetlath
    Contributor

    @Natnael-Guchima I'm not able to reproduce what you say. I just tried the following:

    1. set my account to spanish
    2. signed out (sign in page is in english, like my device)
    3. signed in (account is now in english)
  9. Natnael-Guchima commented on Apr 16, 2023

    @Natnael-Guchima

    @Natnael-Guchima I'm not able to reproduce what you say. I just tried the following:

    1. set my account to spanish
    2. signed out (sign in page is in english, like my device)
    3. signed in (account is now in english)

    @puneetlath I don't know if this is a device specific thing but I am able to reproduce it.

    • set my account language preference to Spanish
    • Signed out (sign in page is in English according to my device and browser language preference)
    • signed in back

    Actual Result: account is now in Spanish

    XRecorder_16042023_190232.mp4
  10. puneetlath commented on Apr 16, 2023

    @puneetlath
    Contributor

    Hmm, and you're definitely on the latest version of the app?

    If so, can you tell me:

    1. What language shows as being set in Onyx when you're on the sign in page
    2. The language being passed in the API request when you sign in
  11. Natnael-Guchima commented on Apr 16, 2023

    @Natnael-Guchima

    Hmm, and you're definitely on the latest version of the app?

    If so, can you tell me:

    1. What language shows as being set in Onyx when you're on the sign in page
    2. The language being passed in the API request when you sign in

    The version and environment I am testing on is:

    • Version: v1.2.99-6
    • Environment: Production

    Where can I see what language shows in Onyx and the language passed in the API request? I don't have access to dev environment if that is where I can see them.
    image

  12. puneetlath commented on Apr 16, 2023

    @puneetlath
    Contributor

    Onyx data is in application > indexedDB > OnyxDB > keyvaluepairs
    image

    Network request is in Network tab. You can see the passed locale in the API command payload:

    image

  13. Natnael-Guchima commented on Apr 16, 2023

    @Natnael-Guchima

    Onyx data is in application > indexedDB > OnyxDB > keyvaluepairs image

    Network request is in Network tab. You can see the passed locale in the API command payload:

    image

    Thanks for the guidance 🙌. Below are the results:

    English is set in Onyx when a user is on the sign-in page
    image

    English is passed in the API request when user sign-in
    image

  14. puneetlath commented on Apr 16, 2023

    @puneetlath
    Contributor

    Ah! It only was added to the password-less flow, since the password flow is going to be removed very soon. That's why you aren't seeing it.

    Thanks for the report though!

  15. Natnael-Guchima commented on Apr 16, 2023

    @Natnael-Guchima

    Okay. No problem👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions