You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD] margin-left is not provided to green dot #17226
Open any report with pending pay amount (To ensure green dot is visible)
Pin that report
Add any text in the report to ensure pencil icon is visible
Observe margin between icons
Expected Result:
App should display icons with equal margin between them
Actual Result:
App does not add margin-left: 8px to green dot due to which pencil icon is displayed next with green dot with no space
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.2.97-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
Please re-state the problem that we are trying to solve in this issue.
In this issue, we can see that the green dot indicator does not have a left margin and when the draft pencil is rendered next to it, it there is no space between them, looking weird.
What is the root cause of that problem?
In the LHN, there are three possible icons:
Pencil Icon (for draft)
Pin Icon (for pinned chat)
Green / Red Dot (Pending IOU / error indicator)
The first 2 have a left margin of 8px while the indicator does not.
What changes do you think we should make in order to solve the problem?
We need to wrap the indicator in a View that has a left margin of 8px. This can be done via the style styles.ml2.
Optional Improvement
Once all the three icons are rendered, it leads to a margin of 24px! This can lead to a good amount of text being hidden in the preview. We could add an additional condition such that if all 3 icons are displayed, we can set the left margin of the pencil icon to be 0px or 4px only.
Hi @muttmuure, the particular issue is about lack of margin left on green dot. you can see that issue still exists by seeing the gap between red and green dot in this comment in #18242 PR. The issue is still not solved. I have also cross checked on latest staging build.
Activity
MelvinBot commentedon Apr 10, 2023
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Apr 10, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)MelvinBot commentedon Apr 14, 2023
@muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
muttmuure commentedon Apr 14, 2023
I don't have access to GBR, asking about this here and will add to SO https://expensify.slack.com/archives/C01GTK53T8Q/p1681470733246659
muttmuure commentedon Apr 17, 2023
GBR is live for requests, so I just need to add a request and then I can test
Prince-Mendiratta commentedon Apr 18, 2023
Proposal
Posting proposal early as per new guidelines
Please re-state the problem that we are trying to solve in this issue.
In this issue, we can see that the green dot indicator does not have a left margin and when the draft pencil is rendered next to it, it there is no space between them, looking weird.
What is the root cause of that problem?
In the LHN, there are three possible icons:
The first 2 have a left margin of 8px while the indicator does not.
What changes do you think we should make in order to solve the problem?
We need to wrap the indicator in a
Viewthat has a left margin of 8px. This can be done via the stylestyles.ml2.Optional Improvement
Once all the three icons are rendered, it leads to a margin of 24px! This can lead to a good amount of text being hidden in the preview. We could add an additional condition such that if all 3 icons are displayed, we can set the left margin of the pencil icon to be 0px or 4px only.
PrashantMangukiya commentedon Apr 18, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Margin-left is not provided to green dot.
What is the root cause of that problem?
We are rendering green dot via line 227 here
App/src/components/LHNOptionsList/OptionRowLHN.js
Line 227 in 5bad1bb
There is not left margin added to green dot, so this is the root cause of the problem.
What changes do you think we should make in order to solve the problem?
We have to change code at line 227 as shown below:
This will solve the issue as shown in results video.
What alternative solutions did you explore? (Optional)
None
Results
Web.mov
5 remaining items
MelvinBot commentedon Apr 24, 2023
@muttmuure Still overdue 6 days?! Let's take care of this!
muttmuure commentedon Apr 24, 2023
I think we can hold this one and see if the other issue resolves this one
[-]margin-left is not provided to green dot[/-][+][HOLD] margin-left is not provided to green dot[/+]muttmuure commentedon May 3, 2023
Still held
aimane-chnaif commentedon May 3, 2023
Now that #18242 is merged, we can remove hold and re-test.
muttmuure commentedon May 12, 2023
Looks like we decided to just replace the pin entirely. Looks good to me so going to close.
dhanashree-sawant commentedon May 12, 2023
Hi @muttmuure, the particular issue is about lack of margin left on green dot. you can see that issue still exists by seeing the gap between red and green dot in this comment in #18242 PR. The issue is still not solved. I have also cross checked on latest staging build.