You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for Testrail] [$2000] When the second picture is uploaded, the first picture that was uploaded earlier starts to load again. #17480
Each picture should upload smoothly and should not start loading again.
Actual Result
First picture starts to load again once more then one is uploaded.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-]When the second picture is uploaded, the first picture that was uploaded earlier starts to load again.[/-][+][$1000] When the second picture is uploaded, the first picture that was uploaded earlier starts to load again.[/+]on Apr 25, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-12. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
[@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@aimane-chnaif] Determine if we should create a regression test for this bug.
[@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2023-06-12] [$2000] When the second picture is uploaded, the first picture that was uploaded earlier starts to load again.[/-][+][HOLD for Testrail] [$2000] When the second picture is uploaded, the first picture that was uploaded earlier starts to load again.[/+]on Jun 12, 2023
That comment is when merged in 2 days. But in our case, merged 2 days 11 hrs.
We should definitely update that bot logic to calculate 3 days, not 2 days.
cc: @mountiny
// The urgency bonus applies only when merged within 72 business hours/ 3 daysif ($daysElapsed < 3) {
But I think there must be something else up with the logic because it should return a false comment as well:
} else {
$urgencyComment = <<<COMMENT Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here: - when @$authorGithub got assigned: $dateAssignedFormatted - when the PR got merged: $nowFormatted - days elapsed: $daysElapsed On to the next one 🚀 COMMENT;
}
Activity
MelvinBot commentedon Apr 16, 2023
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Apr 16, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)twisterdotcom commentedon Apr 17, 2023
I can't reproduce this I'm afraid @usmantariq96. I'm using a Pixel 6. The "loading" circle never appears on the previously uploaded image: https://drive.google.com/file/d/1SsROwvkpTqy8Czds4GVLApEuQau1RWWl/view?usp=sharing
Could you check again for me and reopen the issue if you think it's still an issue?
allroundexperts commentedon Apr 23, 2023
@twisterdotcom This seems to be easily reproducible for me on Pixel simulator.
screen-recording-2023-04-24-at-125803-am_MP9RsBi8.mp4
usmantariq96 commentedon Apr 24, 2023
@twisterdotcom I have checked again and yes it is reproducible.
Please find attached new video.
usmantariq96 commentedon Apr 24, 2023
Bug.4.mp4
twisterdotcom commentedon Apr 25, 2023
Ahh I see. Okay yes. I have reproduced it. Super odd we show the loading icon again for attachments.
https://drive.google.com/file/d/1XdGiohePS4o_ym8iTps0JZx3qJ6hO1Ca/view?usp=sharing
[-]When the second picture is uploaded, the first picture that was uploaded earlier starts to load again.[/-][+][$1000] When the second picture is uploaded, the first picture that was uploaded earlier starts to load again.[/+]MelvinBot commentedon Apr 25, 2023
Job added to Upwork: https://www.upwork.com/jobs/~012efb7ba2df1f8cb6
79 remaining items
melvin-bot commentedon Jun 5, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-12. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Jun 5, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
usmantariq96 commentedon Jun 7, 2023
@twisterdotcom applied
twisterdotcom commentedon Jun 12, 2023
All paid out. @aimane-chnaif - we still need the checklist.
[-][HOLD for payment 2023-06-12] [$2000] When the second picture is uploaded, the first picture that was uploaded earlier starts to load again.[/-][+][HOLD for Testrail] [$2000] When the second picture is uploaded, the first picture that was uploaded earlier starts to load again.[/+]aimane-chnaif commentedon Jun 12, 2023
@twisterdotcom this is eligible for timeline bonus
aimane-chnaif commentedon Jun 12, 2023
It's tough to find the offending PR. I think this issue always existed.
Is it easy to test for this bug? No
Is the bug related to an important user flow? (For example, adding a bank account) No
Is it an impactful bug? No
If the answer is no to all of those questions, you can feel confident we shouldn't create a test for the bug.
twisterdotcom commentedon Jun 13, 2023
Why didn't this issue post a comment like this?
@ShogunFire assigned at 11:25 AM GMT +1 on May 30, 2023.
@joelbettner merged it at 10:15 PM GMT +1 on June 1, 2023.
Huh, what on earth is that code even doing then.
aimane-chnaif commentedon Jun 13, 2023
That comment is when merged in 2 days. But in our case, merged 2 days 11 hrs.
We should definitely update that bot logic to calculate 3 days, not 2 days.
cc: @mountiny
twisterdotcom commentedon Jun 13, 2023
The code for that is here.
It is looking for 3 days:
But I think there must be something else up with the logic because it should return a false comment as well:
Neither of which posted here.
twisterdotcom commentedon Jun 13, 2023
Bonuses have been sent
twisterdotcom commentedon Jun 13, 2023
Ahh good old @mountiny is already on it: https://github.com/Expensify/Web-Expensify/pull/37741.