Skip to content

[HOLD for Testrail] [$2000] When the second picture is uploaded, the first picture that was uploaded earlier starts to load again. #17480

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open any chat
  2. Click on “Add Attachment”
  3. Select “Choose from Gallery”
  4. Upload same picture multiple times

Expected Result

Each picture should upload smoothly and should not start loading again.

Actual Result

First picture starts to load again once more then one is uploaded.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug.2.mp4

Expensify/Expensify Issue URL:
Issue reported by: @usmantariq96
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681508702020879

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012efb7ba2df1f8cb6
  • Upwork Job ID: 1650899886112972800
  • Last Price Increase: 2023-05-17

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 16, 2023
  2. MelvinBot commented on Apr 16, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. MelvinBot commented on Apr 16, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. twisterdotcom commented on Apr 17, 2023

    @twisterdotcom
    Contributor

    I can't reproduce this I'm afraid @usmantariq96. I'm using a Pixel 6. The "loading" circle never appears on the previously uploaded image: https://drive.google.com/file/d/1SsROwvkpTqy8Czds4GVLApEuQau1RWWl/view?usp=sharing

    Could you check again for me and reopen the issue if you think it's still an issue?

  5. allroundexperts commented on Apr 23, 2023

    @allroundexperts
    Contributor

    @twisterdotcom This seems to be easily reproducible for me on Pixel simulator.

    screen-recording-2023-04-24-at-125803-am_MP9RsBi8.mp4
  6. usmantariq96 commented on Apr 24, 2023

    @usmantariq96

    @twisterdotcom I have checked again and yes it is reproducible.
    Please find attached new video.

  7. usmantariq96 commented on Apr 24, 2023

    @usmantariq96
    Bug.4.mp4
  8. twisterdotcom commented on Apr 25, 2023

    @twisterdotcom
    Contributor

    Ahh I see. Okay yes. I have reproduced it. Super odd we show the loading icon again for attachments.

    https://drive.google.com/file/d/1XdGiohePS4o_ym8iTps0JZx3qJ6hO1Ca/view?usp=sharing

  9. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 25, 2023
  10. changed the title [-]When the second picture is uploaded, the first picture that was uploaded earlier starts to load again.[/-] [+][$1000] When the second picture is uploaded, the first picture that was uploaded earlier starts to load again.[/+] on Apr 25, 2023
  11. MelvinBot commented on Apr 25, 2023

    @MelvinBot
    Contributor
  12. 79 remaining items

  13. melvin-bot commented on Jun 5, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.23-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-06-12. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  14. melvin-bot commented on Jun 5, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
    • [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@aimane-chnaif] Determine if we should create a regression test for this bug.
    • [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. usmantariq96 commented on Jun 7, 2023

    @usmantariq96
  16. twisterdotcom commented on Jun 12, 2023

    @twisterdotcom
    Contributor

    All paid out. @aimane-chnaif - we still need the checklist.

  17. changed the title [-][HOLD for payment 2023-06-12] [$2000] When the second picture is uploaded, the first picture that was uploaded earlier starts to load again.[/-] [+][HOLD for Testrail] [$2000] When the second picture is uploaded, the first picture that was uploaded earlier starts to load again.[/+] on Jun 12, 2023
  18. aimane-chnaif commented on Jun 12, 2023

    @aimane-chnaif
    Contributor

    @twisterdotcom this is eligible for timeline bonus

  19. aimane-chnaif commented on Jun 12, 2023

    @aimane-chnaif
    Contributor

    It's tough to find the offending PR. I think this issue always existed.

    • Is it easy to test for this bug? No

    • Is the bug related to an important user flow? (For example, adding a bank account) No

    • Is it an impactful bug? No

    • If the answer is no to all of those questions, you can feel confident we shouldn't create a test for the bug.

  20. twisterdotcom commented on Jun 13, 2023

    @twisterdotcom
    Contributor

    this is eligible for timeline bonus

    Why didn't this issue post a comment like this?

    @ShogunFire assigned at 11:25 AM GMT +1 on May 30, 2023.
    @joelbettner merged it at 10:15 PM GMT +1 on June 1, 2023.

    Huh, what on earth is that code even doing then.

  21. aimane-chnaif commented on Jun 13, 2023

    @aimane-chnaif
    Contributor

    That comment is when merged in 2 days. But in our case, merged 2 days 11 hrs.
    We should definitely update that bot logic to calculate 3 days, not 2 days.
    cc: @mountiny

  22. twisterdotcom commented on Jun 13, 2023

    @twisterdotcom
    Contributor

    The code for that is here.

    It is looking for 3 days:

        // The urgency bonus applies only when merged within 72 business hours/ 3 days
        if ($daysElapsed < 3) {

    But I think there must be something else up with the logic because it should return a false comment as well:

        } else {
            $urgencyComment = <<<COMMENT
            Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:
    
            - when @$authorGithub got assigned: $dateAssignedFormatted
            - when the PR got merged: $nowFormatted
            - days elapsed: $daysElapsed
    
            On to the next one 🚀
            COMMENT;
        }

    Neither of which posted here.

  23. twisterdotcom commented on Jun 13, 2023

    @twisterdotcom
    Contributor

    Bonuses have been sent

  24. twisterdotcom commented on Jun 13, 2023

    @twisterdotcom
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions