[HOLD for payment 2023-05-16] [$1000] Incorrect copy terminology in Add Bank Account Form

@dhanashree-sawant

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open the app
Open settings
Open workspaces
Open any workspace
Open connect bank account
Click on connect manually
Without filling any details, click on continue
Fill in details in step 1 and click on continue. eg details: routing no= 210021002, acc no= 1234
Without filling any field, click on Save & continue
Observe that for 'Incorporation state' field, even though field is dropdown, validation error says 'Please enter' in place of 'Please select'

Expected Result:

App should maintain consistent validation statements for fields in connect bank account

Actual Result:

App has many inconsistencies in validation statements for fields in connect bank account

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

inconsistencies.on.connect.bank.account.page.mp4

Recording.255.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681660533308849

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013e01cb4925f3fd49
Upwork Job ID: 1648701949863370752
Last Price Increase: 2023-04-26

@flaviadefaria

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@kavimuru

@kavimuru Can you please consolidate all the capitalization issues into a single issue? Right now, I've been merging them into #17239

Re-opening this issue because there is one problem which involves incorrect terminology which is not going to be taken care of in the capitalization issue

I'm not sure this is a bug. Posted in slack about it.

Oh, the recording got me confused as it highlighted another field. Moving it forward as a bug.

Job added to Upwork: https://www.upwork.com/jobs/~013e01cb4925f3fd49

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix form terminology #18160

If no regressions arise, payment will be issued on 2023-05-16. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@mananjadhav

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
[@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mananjadhav] Determine if we should create a regression test for this bug.
[@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@flaviadefaria

These texts have been existing since a long time and not necessarily a bug. We definitely improved the context and I don't think we need a regression test here. what do you folks think @flaviadefaria @arosiclair ?

Agree this is not a regression

@flaviadefaria

@flaviadefaria There's nothing else on the checklist from my side and this is ready for payout.

@dhanashree-sawant

Processing payment now:

@dhanashree-sawant - $250
@mananjadhav - $1000 + 50% bonus = $1500
@getusha - $1000 + 50% bonus = $1500

@flaviadefaria

That's right @flaviadefaria. Accepted the offer.

@flaviadefaria

@flaviadefaria Accepted!

Payments done closing this GH.

Navigation Menu

Repository navigation

[HOLD for payment 2023-05-16] [$1000] Incorrect copy terminology in Add Bank Account Form #17539

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

33 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-05-16] [$1000] Incorrect copy terminology in Add Bank Account Form #17539

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

MelvinBot commented on Apr 17, 2023

MelvinBot commented on Apr 17, 2023

Bug0 Triage Checklist (Main S/O)

thienlnam commented on Apr 18, 2023

thienlnam commented on Apr 18, 2023

flaviadefaria commented on Apr 19, 2023

flaviadefaria commented on Apr 19, 2023

MelvinBot commented on Apr 19, 2023

33 remaining items

melvin-bot commented on May 9, 2023

melvin-bot commented on May 9, 2023

melvin-bot commented on May 9, 2023

mananjadhav commented on May 9, 2023

arosiclair commented on May 9, 2023

mananjadhav commented on May 15, 2023

flaviadefaria commented on May 16, 2023

mananjadhav commented on May 16, 2023

getusha commented on May 16, 2023

flaviadefaria commented on May 16, 2023

flaviadefaria commented on May 16, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions