Repository navigation
[HOLD for payment 2023-04-27] [HOLD for payment 2023-04-26] Workspace - When deleting a workspace offline. the layout breaks #17580
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Access staging.new.expensify.com
- Sign into a valid account that is ready for Error tests
- Turn off internet connection
- Delete a workspace while offline
Expected Result:
User expects the layout to continue even when offline
Actual Result:
Layout breaks
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.1.0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Activity
kbecciv commentedon Apr 18, 2023
Attaching TR picture to reproduce the issue
OSBotify commentedon Apr 18, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:MelvinBot commentedon Apr 18, 2023
Triggered auto assignment to @flodnv (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.flodnv commentedon Apr 18, 2023
Can confirm, I reproduced on staging web, but not on prod.
flodnv commentedon Apr 18, 2023
I looked at the PRs in #17546, nothing stands out. I am going to use git bisect to find the offending PR, unless someone chimes in here: https://expensify.slack.com/archives/C01GTK53T8Q/p1681836208585709
flodnv commentedon Apr 18, 2023
Reverting #17310 locally fixes it, so that PR caused it. Assigning everyone who was involved to decide what to do 🙃
flodnv commentedon Apr 18, 2023
For some reason I cannot assign @akinwale
9 remaining items
[-]Workspace - When deleting a workspace offline. the layout breaks[/-][+][HOLD for payment 2023-04-26] Workspace - When deleting a workspace offline. the layout breaks[/+]MelvinBot commentedon Apr 19, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".MelvinBot commentedon Apr 19, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.1-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-04-26. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
[-][HOLD for payment 2023-04-26] Workspace - When deleting a workspace offline. the layout breaks[/-][+][HOLD for payment 2023-04-27] [HOLD for payment 2023-04-26] Workspace - When deleting a workspace offline. the layout breaks[/+]MelvinBot commentedon Apr 20, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".MelvinBot commentedon Apr 20, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.2-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-04-27. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue: