You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-06-05] [$1000] Overlapping text on sign in page with autofill enabled #17688
Make sure your email is autofilled in the email input field
Reload the sign in page
Expected result:
The label “Phone or email” should be above the email input field and not overlap with the autofilled email.
Actual result:
The label “Phone or email” overlaps with the autofilled email and doesn't have proper spacing.
Additional notes: The issue is resolved if the user clicks anywhere on the page after reloading. The label moves to the correct position above the email input field.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.2-0 Reproducible in staging?: Needs reproduction Reproducible in production?: Needs reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-][$1000] Overlapping text on sign in page with autofill enabled[/-][+][HOLD for payment 2023-06-05] [$1000] Overlapping text on sign in page with autofill enabled[/+]on May 29, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.19-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-05. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
[@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@0xmiroslav] Determine if we should create a regression test for this bug.
[@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
No PR caused regression. This issue came from combination of our custom text input with floating label and chrome's default autofill feature. I don't think any further regression test step is needed here.
Activity
MelvinBot commentedon Apr 19, 2023
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Apr 19, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)johncschuster commentedon Apr 25, 2023
Asking a clarifying question about the reproduction steps in Slack.
johncschuster commentedon Apr 27, 2023
I'm unable to reproduce it on Staging.
2023-04-27_16-31-11.mp4
Nathan-Mulugeta commentedon Apr 28, 2023
To reproduce the bug the email has to be auto filled.
113 remaining items
[-][$1000] Overlapping text on sign in page with autofill enabled[/-][+][HOLD for payment 2023-06-05] [$1000] Overlapping text on sign in page with autofill enabled[/+]melvin-bot commentedon May 29, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 29, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.19-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BaseTextInputcomponent label on autofill #19512If no regressions arise, payment will be issued on 2023-06-05. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon May 29, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
therealsujitk commentedon May 31, 2023
@kevinksullivan just a heads up, the Upwork job may expire if inactive for 30 days ~ Upwork Community.
kevinksullivan commentedon Jun 2, 2023
Offers sent @therealsujitk @0xmiroslav @Nathan-Mulugeta . @0xmiroslav can you complete the steps above when you get a chance? Thanks!
therealsujitk commentedon Jun 8, 2023
@kevinksullivan @0xmiroslav friendly bump, this issue is ready for payment.
0xmiroslav commentedon Jun 8, 2023
No PR caused regression. This issue came from combination of our custom text input with floating label and chrome's default autofill feature. I don't think any further regression test step is needed here.
kevinksullivan commentedon Jun 9, 2023
Paid out and ended contracts.