Skip to content

[HOLD for payment 2023-06-05] [$1000] Overlapping text on sign in page with autofill enabled #17688

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Action Performed:
  2. Navigate to sign in page
  3. Make sure your email is autofilled in the email input field
  4. Reload the sign in page

Expected result:

The label “Phone or email” should be above the email input field and not overlap with the autofilled email.
Actual result:
The label “Phone or email” overlaps with the autofilled email and doesn't have proper spacing.

Additional notes: The issue is resolved if the user clicks anywhere on the page after reloading. The label moves to the correct position above the email input field.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.2-0
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-04-18.10.44.07.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681804580550519

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0152deae46500bd6c9
  • Upwork Job ID: 1654481443005186048
  • Last Price Increase: 2023-05-12

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 19, 2023
  2. MelvinBot commented on Apr 19, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. MelvinBot commented on Apr 19, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. johncschuster commented on Apr 25, 2023

    @johncschuster
    Contributor

    Asking a clarifying question about the reproduction steps in Slack.

  5. johncschuster commented on Apr 27, 2023

    @johncschuster
    Contributor

    I'm unable to reproduce it on Staging.

    2023-04-27_16-31-11.mp4
  6. Nathan-Mulugeta commented on Apr 28, 2023

    @Nathan-Mulugeta

    To reproduce the bug the email has to be auto filled.

  7. 113 remaining items

  8. changed the title [-][$1000] Overlapping text on sign in page with autofill enabled[/-] [+][HOLD for payment 2023-06-05] [$1000] Overlapping text on sign in page with autofill enabled[/+] on May 29, 2023
  9. melvin-bot commented on May 29, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on May 29, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.19-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-06-05. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  11. melvin-bot commented on May 29, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
    • [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@0xmiroslav] Determine if we should create a regression test for this bug.
    • [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  12. therealsujitk commented on May 31, 2023

    @therealsujitk
    Contributor

    @kevinksullivan just a heads up, the Upwork job may expire if inactive for 30 days ~ Upwork Community.

  13. kevinksullivan commented on Jun 2, 2023

    @kevinksullivan
    Contributor

    Offers sent @therealsujitk @0xmiroslav @Nathan-Mulugeta . @0xmiroslav can you complete the steps above when you get a chance? Thanks!

  14. therealsujitk commented on Jun 8, 2023

    @therealsujitk
    Contributor

    @kevinksullivan @0xmiroslav friendly bump, this issue is ready for payment.

  15. 0xmiroslav commented on Jun 8, 2023

    @0xmiroslav
    Contributor

    No PR caused regression. This issue came from combination of our custom text input with floating label and chrome's default autofill feature. I don't think any further regression test step is needed here.

  16. kevinksullivan commented on Jun 9, 2023

    @kevinksullivan
    Contributor

    Paid out and ended contracts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions