You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-04-28] [HOLD for payment 2023-04-27] Web - Workspaces - When changing the currency offline, errors appear in the JS console #17693
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Seems like we also have the Global create not opening by default on new account and the console error is showing too which will most likely be related.
changed the title [-]Web - Workspaces - When changing the currency offline, errors appear in the JS console[/-][+][HOLD for payment 2023-04-27] Web - Workspaces - When changing the currency offline, errors appear in the JS console[/+]on Apr 20, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.2-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-04-27. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
changed the title [-][HOLD for payment 2023-04-27] Web - Workspaces - When changing the currency offline, errors appear in the JS console[/-][+][HOLD for payment 2023-04-28] [HOLD for payment 2023-04-27] Web - Workspaces - When changing the currency offline, errors appear in the JS console[/+]on Apr 21, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.3-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-04-28. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
Activity
OSBotify commentedon Apr 19, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:MelvinBot commentedon Apr 19, 2023
Triggered auto assignment to @tgolen (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.mountiny commentedon Apr 19, 2023
Seems like this issue might be related #17684 the error does not appear in production
mountiny commentedon Apr 20, 2023
Seems like we also have the Global create not opening by default on new account and the console error is showing too which will most likely be related.
mountiny commentedon Apr 20, 2023
cannot reproduce this issue locally either (using the steps in the issue body)
mountiny commentedon Apr 20, 2023
PR is in a review and going to staging
mvtglobally commentedon Apr 20, 2023
Issue is fixed https://user-images.githubusercontent.com/43995119/233428431-558c5195-b0a3-4b8c-bb4f-7c24085d280f.MOV
mountiny commentedon Apr 20, 2023
Thank you @mvtglobally closing
[-]Web - Workspaces - When changing the currency offline, errors appear in the JS console[/-][+][HOLD for payment 2023-04-27] Web - Workspaces - When changing the currency offline, errors appear in the JS console[/+]MelvinBot commentedon Apr 20, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".MelvinBot commentedon Apr 20, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.2-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-04-27. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
[-][HOLD for payment 2023-04-27] Web - Workspaces - When changing the currency offline, errors appear in the JS console[/-][+][HOLD for payment 2023-04-28] [HOLD for payment 2023-04-27] Web - Workspaces - When changing the currency offline, errors appear in the JS console[/+]MelvinBot commentedon Apr 21, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.3-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-04-28. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue: