Skip to content

[$1000] Web - Connect Bank Account - Inconsistent behaviour in the same page where adding spaces before the 'Tax Number' behaves differently unlike the behaviour shown by the company website field. #17725

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging dot on web chrome
  2. Go to any workspace > Connect bank account manually> Fill all the details
  3. Now in the company website field as well as in the tax number field , try to add multiple spaces before the text
  4. Click on back button and again go the same page
  5. See that the spaces have been removed from the company website's field but the spaces are not removed from the Tax number field.

Expected Result:

To maintain consistency between the fields, the spaces added before the tax number field should be removed

Actual Result:

In the same page , the spaces added before the company website field is removed , while the spaces added before the tax number field is not removed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.2.3

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.2540.mp4
login-2023-04-19_17.08.48.mp4

Expensify/Expensify Issue URL:

Issue reported by: @avi-shek-jha

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681905290839009

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d5f5fca93a2703df
  • Upwork Job ID: 1650538299630120960
  • Last Price Increase: 2023-05-08

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 20, 2023
  2. MelvinBot commented on Apr 20, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. MelvinBot commented on Apr 20, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. changed the title [-]Web - [/-] [+]Web - Connect Bank Account - Inconsistent behaviour in the same page where adding spaces before the 'Tax Number' behaves differently unlike the behaviour shown by the company website field.[/+] on Apr 20, 2023
  5. kavimuru commented on Apr 20, 2023

    @kavimuru

    Sorry for opening this bug. It should be on hold as per this slack comment. Will reopen if it is needed.

  6. kavimuru commented on Apr 21, 2023

    @kavimuru

    As per the slack conversation reopening the issue.

  7. MelvinBot commented on Apr 24, 2023

    @MelvinBot
    Contributor

    @bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  8. bfitzexpensify commented on Apr 24, 2023

    @bfitzexpensify
    Contributor

    Reproduced.

  9. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 24, 2023
  10. 32 remaining items

  11. pecanoro commented on May 8, 2023

    @pecanoro
    Contributor

    I am also going to open a Slack discussion because I do not strongly agree with trimming the value because it is against the Form guidelines. It might be good to get a consensus on it.

    @parasharrajat If we don't want to trim the form values, then I feel we should do nothing and keep it as it is since nothing is broken, it's just as form fields are supposed to work.

  12. parasharrajat commented on May 8, 2023

    @parasharrajat
    Member

    Ok. That can be done too. I have opened a Slack discussion https://expensify.slack.com/archives/C01GTK53T8Q/p1683555129513689. Let's discussion this over there. Thanks.

  13. melvin-bot commented on May 8, 2023

    @melvin-bot

    📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

  14. parasharrajat commented on May 8, 2023

    @parasharrajat
    Member

    Still discussing.

  15. pecanoro commented on May 11, 2023

    @pecanoro
    Contributor

    I am going to post internally to see if we can get more opinions since only the three of us participated in the Slack discussion 😄

  16. pecanoro commented on May 11, 2023

    @pecanoro
    Contributor

    Ok, after some discussions, we decided that the current behavior is the best behavior so we are going to close this issue.

  17. sophiepintoraetz commented on May 11, 2023

    @sophiepintoraetz
    Contributor

    @parasharrajat - were there any next steps with the discussion?

  18. parasharrajat commented on May 11, 2023

    @parasharrajat
    Member

    No, we don't want to change this behavior. If that's what you are asking.

  19. allroundexperts commented on May 19, 2023

    @allroundexperts
    Contributor

    @parasharrajat @pecanoro Should we reopen this based on the discussion here?

  20. parasharrajat commented on May 19, 2023

    @parasharrajat
    Member

    It seems so. I don't have any objection if it is decided internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions