Skip to content

[HOLD for payment 2023-05-23] [$1000] On increasing the screen size the user can see the previous image in the list #17760

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to any chat
  2. Send 2-3 images
  3. Decrease the screen size
  4. Open the first image and try increasing the screen size

Expected Result:

User shouldn't see other images while increasing the screen size

Actual Result:

On increasing screen size next image gets visible

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.3
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-04-20.at.5.53.52.PM.mov
Recording.293.mp4

Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1681993540527479

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011195db019e2042bb
  • Upwork Job ID: 1649474118394445824
  • Last Price Increase: 2023-04-28

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 20, 2023
  2. MelvinBot commented on Apr 20, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. MelvinBot commented on Apr 20, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. joekaufmanexpensify commented on Apr 21, 2023

    @joekaufmanexpensify
    Contributor

    Agreed, this is a bug. Reproduced on web.

  5. changed the title [-] On increasing the screen size the user can see the previous image in the list[/-] [+][$1000] On increasing the screen size the user can see the previous image in the list[/+] on Apr 21, 2023
  6. MelvinBot commented on Apr 21, 2023

    @MelvinBot
    Contributor
  7. MelvinBot commented on Apr 21, 2023

    @MelvinBot
    Contributor

    Current assignee @joekaufmanexpensify is eligible for the External assigner, not assigning anyone new.

  8. MelvinBot commented on Apr 21, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 21, 2023
  10. MelvinBot commented on Apr 21, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @chiragsalian (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  11. 47 remaining items

  12. AmjedNazzal commented on May 19, 2023

    @AmjedNazzal
    Contributor

    @joekaufmanexpensify Thank you! accepted

  13. joekaufmanexpensify commented on May 22, 2023

    @joekaufmanexpensify
    Contributor

    All set to issue payment soon. Still need to complete BZ checklist steps though.

  14. joekaufmanexpensify commented on May 23, 2023

    @joekaufmanexpensify
    Contributor

    Bumped BZ checklist steps in Slack.

  15. aimane-chnaif commented on May 23, 2023

    @aimane-chnaif
    Contributor
    • The PR that introduced the bug has been identified. Link to the PR: Attachment Carousel Virtual Caching #16973
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/16973/files#r1202887868
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This was overlooked while refactoring carousel and also edge case so no further discussions needed. Just commenting on offending PR is enough.
    • Is it easy to test for this bug? No
    • Is the bug related to an important user flow? (For example, adding a bank account) No
    • Is it an impactful bug? No

    Based on that, we can skip regression test proposal.

  16. joekaufmanexpensify commented on May 23, 2023

    @joekaufmanexpensify
    Contributor

    Great, ty! BZ checklist is now complete.

  17. joekaufmanexpensify commented on May 23, 2023

    @joekaufmanexpensify
    Contributor

    @AmjedNazzal was assigned to this issue on May 8th at 6:16 PM UTC. The PR was merged on May 12th at 2:12 AM UTC. This is slightly longer than 3 business days, so this does not qualify for a speed bonus. We'll hit 7 full days of the regression reporting bonus later this evening, and then issue payment!

  18. joekaufmanexpensify commented on May 24, 2023

    @joekaufmanexpensify
    Contributor

    @AmjedNazzal $1,000 sent and contract ended!

  19. joekaufmanexpensify commented on May 24, 2023

    @joekaufmanexpensify
    Contributor

    @aimane-chnaif $1,000 sent and contract ended!

  20. joekaufmanexpensify commented on May 24, 2023

    @joekaufmanexpensify
    Contributor

    @thesahindia $250 sent and contract ended!

  21. joekaufmanexpensify commented on May 24, 2023

    @joekaufmanexpensify
    Contributor

    Upwork job closed.

  22. joekaufmanexpensify commented on May 24, 2023

    @joekaufmanexpensify
    Contributor

    Bug is fixed, BZ checklist complete, and all payment issued. Closing as this is all set. Thanks everyone!

  23. AmjedNazzal commented on May 24, 2023

    @AmjedNazzal
    Contributor

    Thank you! recieved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions