Skip to content

[HOLD for payment 2023-05-16] [$1000] HTML in edit box is parsed after reloading, but that doesn't happen in normal composer #17843

New issue
New issue
Closed
Closed
[HOLD for payment 2023-05-16] [$1000] HTML in edit box is parsed after reloading, but that doesn't happen in normal composer#17843
Assignees
chiragsalianmollfprlschurreh2077
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Description

@kavimuru
kavimuru
opened on Apr 23, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. open a chat and send a msg
  2. edit it and write an html tag like <h1>abc</h1>
  3. Without saving, reload the page
  4. Now repeat the steps for a new message in composer

Expected results:

html tags should either not be parsed in both edit composer and new composer, or should be parsed in both composers. Also, parsing should be instantaneous, without needing to reload

Actual results:

HTML in edit box is parsed after reloading, but that doesn't happen in normal composer

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.320.mp4
bandicam.2023-04-22.17-12-15-230.mp4

Expensify/Expensify Issue URL:
Issue reported by: @chiragxarora
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682163823425989

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011c3c44a587c09ce7
  • Upwork Job ID: 1650879526556016640
  • Last Price Increase: 2023-04-25

Activity

  1. kavimuru
    added
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 23, 2023

  2. MelvinBot commented on Apr 23, 2023

    @MelvinBot
    MelvinBot
    on Apr 23, 2023
    Contributor

    Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot
    assigned
    lschurr
    on Apr 23, 2023

  4. MelvinBot commented on Apr 23, 2023

    @MelvinBot
    MelvinBot
    on Apr 23, 2023
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  5. melvin-bot
    added
    Overdue
    on Apr 25, 2023

  6. lschurr commented on Apr 25, 2023

    @lschurr
    lschurr
    on Apr 25, 2023
    Contributor

    Triaging this today.

  7. melvin-bot
    removed
    Overdue
    on Apr 25, 2023
  8. lschurr
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 25, 2023
  9. melvin-bot
    changed the title [-]HTML in edit box is parsed after reloading, but that doesn't happen in normal composer[/-] [+][$1000] HTML in edit box is parsed after reloading, but that doesn't happen in normal composer[/+] on Apr 25, 2023

  10. MelvinBot commented on Apr 25, 2023

    @MelvinBot
    MelvinBot
    on Apr 25, 2023
    Contributor

    Job added to Upwork: https://www.upwork.com/jobs/~011c3c44a587c09ce7

  11. MelvinBot commented on Apr 25, 2023

    @MelvinBot
    MelvinBot
    on Apr 25, 2023
    Contributor

    Current assignee @lschurr is eligible for the External assigner, not assigning anyone new.

  12. melvin-bot
    assigned
    mollfpr
    on Apr 25, 2023

  13. MelvinBot commented on Apr 25, 2023

    @MelvinBot
    MelvinBot
    on Apr 25, 2023
    Contributor

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

  14. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 25, 2023

  15. 27 remaining items

  16. lschurr commented on May 9, 2023

    @lschurr
    lschurr
    on May 9, 2023
    Contributor

    @chiragxarora @mollfpr @eh2077 - Can you apply for the job in Upwork if you haven't yet? https://www.upwork.com/jobs/~011c3c44a587c09ce7

  17. chiragxarora commented on May 9, 2023

    @chiragxarora
    chiragxarora
    on May 9, 2023
    Contributor

    I don't have much connects, can you send me an offer instead?

  18. lschurr commented on May 9, 2023

    @lschurr
    lschurr
    on May 9, 2023
    Contributor

    Can you put your Upwork profile here @chiragxarora?

  19. chiragxarora commented on May 9, 2023

    @chiragxarora
    chiragxarora
    on May 9, 2023
    Contributor

    https://www.upwork.com/freelancers/~014a1b566a7d8ee0c5

  20. chiragxarora commented on May 11, 2023

    @chiragxarora
    chiragxarora
    on May 11, 2023
    Contributor

    I haven't received it yet @lschurr

  21. lschurr commented on May 15, 2023

    @lschurr
    lschurr
    on May 15, 2023
    Contributor

    @chiragxarora are you able to see and apply for the job here? https://www.upwork.com/jobs/~011c3c44a587c09ce7

  22. lschurr commented on May 15, 2023

    @lschurr
    lschurr
    on May 15, 2023
    Contributor

    Actually I think I just invited you to the job @chiragxarora - could you check?

  23. chiragxarora commented on May 15, 2023

    @chiragxarora
    chiragxarora
    on May 15, 2023
    Contributor

    I got the interview invite but it's still telling me to apply. Could you send an offer directly?

  24. mollfpr commented on May 15, 2023

    @mollfpr
    mollfpr
    on May 15, 2023
    Contributor

    [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
    [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    I don't think any PR is responsible for this. It's more of an improvement to catch if the draft is the same as the currently edited message.

    [@mollfpr] Determine if we should create a regression test for this bug.

    We can update the test in Message Action menu - Edit Message (Online/Offline) and verify this issue is not reproducible again.

  25. lschurr commented on May 15, 2023

    @lschurr
    lschurr
    on May 15, 2023
    Contributor

    Offer sent @chiragxarora

  26. chiragxarora commented on May 15, 2023

    @chiragxarora
    chiragxarora
    on May 15, 2023
    Contributor

    Offer sent @chiragxarora

    Thanks, accepted!

  27. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on May 15, 2023

  28. lschurr commented on May 16, 2023

    @lschurr
    lschurr
    on May 16, 2023
    Contributor

    Paid and closed job!

  29. lschurr
    closed this as completedon May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions