Skip to content

[HOLD for payment 2023-05-04] Never ending spinner when signing with magic link into an account with 2fa enabled #17969

Closed

Description

@cristipaval

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Begin sign in with an account with 2fa enabled
  2. Click in the magic link
  3. Head back to the initial tab
  4. Insert the 2fa code

Expected Result:

The user should get straight into the App

Actual Result:

The user sees a never-ending loading spinner.

Workaround:

Refresh the tab where the user inerted the 2fa code.

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number:
Reproducible in staging?: yes
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @cristipaval
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682429757156649

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 25, 2023
  2. self-assigned this
    on Apr 25, 2023
  3. MelvinBot commented on Apr 25, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. MelvinBot commented on Apr 25, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  5. tienifr commented on Apr 26, 2023

    @tienifr
    Contributor

    I can't reproduce it on my branch (before the revert). @cristipaval Can you give more context?

    Cc @Santhosh-Sellavel @luacmartins Can you confirm whether you can reproduce this one?

    Screencast.from.26-04-2023.23.40.00.webm
  6. Santhosh-Sellavel commented on Apr 26, 2023

    @Santhosh-Sellavel
    Collaborator

    @tienifr You should try with TFA Enabled account

  7. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Apr 27, 2023
  8. changed the title [-]Never ending spinner when signing with magic link into an account with 2fa enabled[/-] [+][HOLD for payment 2023-05-04] Never ending spinner when signing with magic link into an account with 2fa enabled[/+] on Apr 27, 2023
  9. MelvinBot commented on Apr 27, 2023

    @MelvinBot
    Contributor

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. 5 remaining items

  11. maddylewis commented on May 5, 2023

    @maddylewis
    Contributor

    @cristipaval - when you have a sec, will you fill out your portion of the BZ checklist?

    then, before i process payment, i wanted to confirm that @Santhosh-Sellavel and @tienifr are both receiving $1000 for this one.

  12. cristipaval commented on May 8, 2023

    @cristipaval
    ContributorAuthor

    Done.

    There is already an open issue for adding regression steps around automatic authentication in NewDot.

  13. changed the title [-][HOLD for payment 2023-05-04] Never ending spinner when signing with magic link into an account with 2fa enabled[/-] [+][HOLD for payment 2023-05-16] [HOLD for payment 2023-05-04] Never ending spinner when signing with magic link into an account with 2fa enabled[/+] on May 9, 2023
  14. melvin-bot commented on May 9, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on May 9, 2023

    @melvin-bot
  16. melvin-bot commented on May 9, 2023

    @melvin-bot
  17. changed the title [-][HOLD for payment 2023-05-16] [HOLD for payment 2023-05-04] Never ending spinner when signing with magic link into an account with 2fa enabled[/-] [+][HOLD for payment 2023-05-04] Never ending spinner when signing with magic link into an account with 2fa enabled[/+] on May 9, 2023
  18. maddylewis commented on May 9, 2023

    @maddylewis
    Contributor

    thanks! i will get offers sent over before EOD - (@Santhosh-Sellavel and @tienifr both receiving $1000)

  19. Santhosh-Sellavel commented on May 12, 2023

    @Santhosh-Sellavel
    Collaborator

    @maddylewis Sorry for the delay. No payment is due here for Contributor/C+. As this was a regression from the other issue #17242. We can close the jobs & this issue as all completed here!

  20. cristipaval commented on May 15, 2023

    @cristipaval
    ContributorAuthor

    Right, no payments needed for this one. Thanks @Santhosh-Sellavel and @maddylewis !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions