You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-08-24] [$1000] IOS - Chat - Focus is lost if user inserts emoji in edit mode using emoji picker #18001
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.54-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-24. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sophiepintoraetz] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Issue Reporter: $250 NA
Contributor: $1000 @kosmydel
Contributor+: $1000 @situchan (offer sent - I'll release payment once the checklist is done!)
Eligible for 50% #urgency bonus? @mountiny - I don't think this one is eligible for a bonus, right? @kosmydel was assigned 20 Jul and the PR was merged on 11 Aug
No PR caused regression. This was default iOS behavior in RN modal.
The solution applied here was actually workaround which inherits main composer's setTimeout solution.
This workaround was completely removed in #13922 by fixing iOS native code in RN modal and I will add full regression test step in that issue.
So we can simply skip checklist here.
Activity
MelvinBot commentedon Apr 26, 2023
Triggered auto assignment to @sophiepintoraetz (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Apr 26, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)sophiepintoraetz commentedon Apr 27, 2023
Closing and adding to the tracking issue.
sophiepintoraetz commentedon Apr 27, 2023
This might also be solved by this #15992
lanitochka17 commentedon Jul 15, 2023
Issue is reproducible in mWeb/Safari. Build 1.3.41.2
22542.mWeb.Lost.Focus.mp4
mountiny commentedon Jul 17, 2023
@perunt Could this PR #18001 reintroduce this issue?
perunt commentedon Jul 17, 2023
@mountiny, you referred to the same issue. Is it the correct link?
mountiny commentedon Jul 17, 2023
@perunt Sorry, QA linked to this issue #18001
melvin-bot commentedon Jul 18, 2023
@sophiepintoraetz Whoops! This issue is 2 days overdue. Let's get this updated quick!
39 remaining items
melvin-bot commentedon Aug 17, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Aug 17, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.54-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-24. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Aug 17, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
sophiepintoraetz commentedon Aug 27, 2023
Payouts due:
Issue Reporter: $250 NA
Contributor: $1000 @kosmydel
Contributor+: $1000 @situchan (offer sent - I'll release payment once the checklist is done!)
Eligible for 50% #urgency bonus? @mountiny - I don't think this one is eligible for a bonus, right? @kosmydel was assigned 20 Jul and the PR was merged on 11 Aug
situchan commentedon Aug 28, 2023
No PR caused regression. This was default iOS behavior in RN modal.
The solution applied here was actually workaround which inherits main composer's setTimeout solution.
This workaround was completely removed in #13922 by fixing iOS native code in RN modal and I will add full regression test step in that issue.
So we can simply skip checklist here.
mountiny commentedon Aug 28, 2023
Yeah no bonus here I imagine
sophiepintoraetz commentedon Aug 29, 2023
Payments done!