You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$1000] Log in-After logging out of a Spanish account, login page is displayed in English #18118
When SignIn form is loaded, it always set locale to device's preferred locale.
What changes do you think we should make in order to solve the problem?
We should update above line so that, if we already has preferred locale in Onyx store, we don't need to set locale to device's preferred locale anymore.
To do that, we can add another function in actions/App, then connect to Onyx store to get preferred value, if the value is exist, we do nothing. Otherwise, set the device's preferred locale to Onyx store as the default value. Same technique that we have here
it's difference issue, @abekkala . The issue you mentioned above is in Onfido, which is the third party service. This issue is related to our Sign In page.
changed the title [-]Log in-After logging out of a Spanish account, login page is displayed in English[/-][+][$1000] Log in-After logging out of a Spanish account, login page is displayed in English[/+]on Apr 28, 2023
it seems it was expectation in that PR. But do we want to update it in this GH issue? I think it makes sense if we can keep the user preferred language setting. Otherwise, it makes inconvenient for user every time they logged out, they have to set preferred language again after login.
Activity
MelvinBot commentedon Apr 28, 2023
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon Apr 28, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)hoangzinh commentedon Apr 28, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Log in-After logging out of a Spanish account, login page is displayed in English
What is the root cause of that problem?
Root cause comes from this line of code
https://github.com/Expensify/App/blame/1c749c07cf307cf9689fbc1d9794f74a58ab935e/src/pages/signin/SignInPage.js#L59
When SignIn form is loaded, it always set locale to device's preferred locale.
What changes do you think we should make in order to solve the problem?
We should update above line so that, if we already has preferred locale in Onyx store, we don't need to set locale to device's preferred locale anymore.
To do that, we can add another function in
actions/App, then connect to Onyx store to get preferred value, if the value is exist, we do nothing. Otherwise, set the device's preferred locale to Onyx store as the default value. Same technique that we have hereabekkala commentedon Apr 28, 2023
There may be a fix for this already via the Issue above
hoangzinh commentedon Apr 28, 2023
it's difference issue, @abekkala . The issue you mentioned above is in Onfido, which is the third party service. This issue is related to our Sign In page.
[-]Log in-After logging out of a Spanish account, login page is displayed in English[/-][+][$1000] Log in-After logging out of a Spanish account, login page is displayed in English[/+]MelvinBot commentedon Apr 28, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0126b6330ae55b09b3
abekkala commentedon Apr 28, 2023
Confirmed that fix won't fix this one.
MelvinBot commentedon Apr 28, 2023
Triggered auto assignment to @isabelastisser (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.2 remaining items
MelvinBot commentedon Apr 28, 2023
Triggered auto assignment to @cead22 (
External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.abekkala commentedon Apr 28, 2023
UUGH. I only unassigned Isa but it also unassigned @0xmiroslav
I've assigned you back as the External Contributor-plus team member for proposal review
0xmiroslav commentedon Apr 28, 2023
No problem. Can you please add
Help Wantedlabel back?sobitneupane commentedon Apr 28, 2023
We had discussion about it in this PR and decided to keep it this way.
cc: @puneetlath
hoangzinh commentedon Apr 28, 2023
it seems it was expectation in that PR. But do we want to update it in this GH issue? I think it makes sense if we can keep the user preferred language setting. Otherwise, it makes inconvenient for user every time they logged out, they have to set preferred language again after login.
puneetlath commentedon Apr 28, 2023
Is it a real use-case though that a user would want their expensify account in Spanish but not have their browser set to Spanish?
I think we should only optimize this further if we get real user feedback that this is a real scenario.
0xmiroslav commentedon Apr 28, 2023
I agree. We can close this for now and re-open anytime when we get feedback from users.