Skip to content

[$1000] Log in-After logging out of a Spanish account, login page is displayed in English #18118

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in
  3. Tap settings > Preferences
  4. Change Language of account to Spanish
  5. Log out

Expected Result:

After logging out of a Spanish account, login page is displayed in Spanish

Actual Result:

After logging out of a Spanish account, login page is displayed in English

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.7.2

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6034692_Screen_Recording_20230428_022907_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0126b6330ae55b09b3
  • Upwork Job ID: 1651965588777975808
  • Last Price Increase: 2023-04-28

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 28, 2023
  2. MelvinBot commented on Apr 28, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. MelvinBot commented on Apr 28, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. hoangzinh commented on Apr 28, 2023

    @hoangzinh
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Log in-After logging out of a Spanish account, login page is displayed in English

    What is the root cause of that problem?

    Root cause comes from this line of code
    https://github.com/Expensify/App/blame/1c749c07cf307cf9689fbc1d9794f74a58ab935e/src/pages/signin/SignInPage.js#L59

    When SignIn form is loaded, it always set locale to device's preferred locale.

    What changes do you think we should make in order to solve the problem?

    We should update above line so that, if we already has preferred locale in Onyx store, we don't need to set locale to device's preferred locale anymore.
    To do that, we can add another function in actions/App, then connect to Onyx store to get preferred value, if the value is exist, we do nothing. Otherwise, set the device's preferred locale to Onyx store as the default value. Same technique that we have here

  5. abekkala commented on Apr 28, 2023

    @abekkala
    Contributor

    There may be a fix for this already via the Issue above

  6. hoangzinh commented on Apr 28, 2023

    @hoangzinh
    Contributor

    it's difference issue, @abekkala . The issue you mentioned above is in Onfido, which is the third party service. This issue is related to our Sign In page.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 28, 2023
  8. changed the title [-]Log in-After logging out of a Spanish account, login page is displayed in English[/-] [+][$1000] Log in-After logging out of a Spanish account, login page is displayed in English[/+] on Apr 28, 2023
  9. MelvinBot commented on Apr 28, 2023

    @MelvinBot
    Contributor
  10. abekkala commented on Apr 28, 2023

    @abekkala
    Contributor

    Confirmed that fix won't fix this one.

  11. MelvinBot commented on Apr 28, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @isabelastisser (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  12. 2 remaining items

  13. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 28, 2023
  14. MelvinBot commented on Apr 28, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @cead22 (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  15. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 28, 2023
  16. abekkala commented on Apr 28, 2023

    @abekkala
    Contributor

    UUGH. I only unassigned Isa but it also unassigned @0xmiroslav
    I've assigned you back as the External Contributor-plus team member for proposal review

  17. 0xmiroslav commented on Apr 28, 2023

    @0xmiroslav
    Contributor

    No problem. Can you please add Help Wanted label back?

  18. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 28, 2023
  19. deleted a comment from MelvinBot on Apr 28, 2023
  20. sobitneupane commented on Apr 28, 2023

    @sobitneupane
    Contributor

    We had discussion about it in this PR and decided to keep it this way.

    cc: @puneetlath

  21. hoangzinh commented on Apr 28, 2023

    @hoangzinh
    Contributor

    it seems it was expectation in that PR. But do we want to update it in this GH issue? I think it makes sense if we can keep the user preferred language setting. Otherwise, it makes inconvenient for user every time they logged out, they have to set preferred language again after login.

  22. puneetlath commented on Apr 28, 2023

    @puneetlath
    Contributor

    Is it a real use-case though that a user would want their expensify account in Spanish but not have their browser set to Spanish?

    I think we should only optimize this further if we get real user feedback that this is a real scenario.

  23. 0xmiroslav commented on Apr 28, 2023

    @0xmiroslav
    Contributor

    I agree. We can close this for now and re-open anytime when we get feedback from users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions