[HOLD for payment 2023-06-13] [HOLD for payment 2023-06-08] [$1000] Clicking on an attachment opens wrong image

@quinthar

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Have 2 attachments in the concierge chat. (Uber ride image then Flight details image)
Open the latest attachment (flight details)

Expected Result:

Should open the correct image

Actual Result:

Instead of opening the last image opens the previous one.

NOTE: It only happens in the concierge chat, and only on mobile. But killing the app and reopening it doesn't fix it. Additionally, I've received new images and they don't work either.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: Needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682642592064539

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~017ebe929096afd053
Upwork Job ID: 1656211658447282176
Last Price Increase: 2023-05-17

@zanyrenney

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

checking in slack what the best next steps are here as I can't reproduce this but maybe worth exploring internally from the slack thread.

@quinthar

This is able to be reproduced in Incognito by @quinthar but neither me nor @kavimuru have been able to reproduce.

Additional data points from the bug report:

HTML:
"<p>Yes - it's at the bottom of the confirmation PDF!<br /><img src=\"https://s3-us-west-1.amazonaws.com/concierge-responses-expensify-com/uploads%2F1682657370975-1682657370975.png\" style=\"width:300px;\" class=\"fr-fic fr-dib\" alt=\"uploads%2F1682657370975-1682657370975.png\" /></p>"

This has been able to be reproduced https://expensify.slack.com/archives/C049HHMV9SM/p1683331741796129?thread_ts=1682642592.064539&cid=C049HHMV9SM

images-preview-incorrect.mp4

Please accept invites for payout.

Accepted the offer. Thanks.

https://www.upwork.com/jobs/~019ad885bd5005ca81

@Natnael-Guchima

@Natnael-Guchima @eVoloshchak paid out on Upwork!

@kidroca

I'm not going to close this one out yet as @kidroca mentions there is one bug:

one more issue remains (affects only web), related to the modal focus trap, which causes the first item to scroll into view. This issue has been previously described in detail #18150 (comment).

@kidroca can you let me know when that's resolved so that we can close this GH issue out please?

@Natnael-Guchima

@Natnael-Guchima @eVoloshchak paid out on Upwork!

Thanks.

@kidroca

@kidroca bump on the question in #18150 (comment) - do we need to open another issue to handle that problem?

It may be beneficial to initiate a new ticket for a follow-up and bring closure to the current one. However, before we proceed, we should clarify a few points:

Have we received any recent reports regarding incorrect image display in the carousel?
If so, is there a correlation with a specific platform?

From my end, I no longer encounter the issue of the carousel showing the wrong image during normal usage. The issue appears to be exclusive to mobile Safari on the simulator when I'm testing the app.

I've traced this problem back to the modal handling logic in react-native-web. Currently, I am working on developing a standalone bug example to highlight this issue and intend to open a separate ticket upstream.

If there are no longer reports of the carousel bug, I would propose we close this ticket. We can then initiate a new one specifically to track and monitor the mobile Safari-related issue.

@kidroca

Thanks @kidroca. Your approach sounds good. I'm not finding any recent reports of the carousel bug, so let's go ahead and close this one out.

@bfitzexpensify

@bfitzexpensify would you open a new ticket about the mobile Safari bug?

I can still recreate this "Clicking on an attachment opens wrong image" bug, but only on mobile Safari
if I'm not assigned to a ticket I can't continue my investigation

Cool, opened #21177

Navigation Menu

Repository navigation

[HOLD for payment 2023-06-13] [HOLD for payment 2023-06-08] [$1000] Clicking on an attachment opens wrong image #18150

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

89 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-06-13] [HOLD for payment 2023-06-08] [$1000] Clicking on an attachment opens wrong image #18150

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

MelvinBot commented on Apr 28, 2023

MelvinBot commented on Apr 28, 2023

Bug0 Triage Checklist (Main S/O)

zanyrenney commented on May 2, 2023

zanyrenney commented on May 4, 2023

zanyrenney commented on May 4, 2023

zanyrenney commented on May 9, 2023

zanyrenney commented on May 9, 2023

89 remaining items

Natnael-Guchima commented on Jun 13, 2023

zanyrenney commented on Jun 13, 2023

zanyrenney commented on Jun 14, 2023

zanyrenney commented on Jun 14, 2023

Natnael-Guchima commented on Jun 14, 2023

bfitzexpensify commented on Jun 19, 2023

kidroca commented on Jun 19, 2023

bfitzexpensify commented on Jun 20, 2023

kidroca commented on Jun 20, 2023

bfitzexpensify commented on Jun 21, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions