You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-05-25] [$1000] IOS - Chat - Left edge of PDF is visible on the previous image when scrolling through images #18222
changed the title [-]IOS - Chat - Left edge of PDF is visible on the previous image when scrolling through images[/-][+][$1000] IOS - Chat - Left edge of PDF is visible on the previous image when scrolling through images[/+]on May 2, 2023
Link to discussion: I think this can be caught with actual checklist , it just require testing all possible scenarios during a refactor. Just commenting on offending PR is enough.
Determine if we should create a regression test for this bug. ❌ I don't think this require a regression test, it's just 1px border width issue.
Activity
MelvinBot commentedon May 1, 2023
Triggered auto assignment to @NicMendonca (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon May 1, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)NicMendonca commentedon May 1, 2023
@kbecciv I can't reliably reproduce this.
When the next image is a larger, white background PDF, I notice it. But if its a smaller, image I don't. Any ideas?
kbecciv commentedon May 2, 2023
Hello @NicMendonca! Looks like the preview sizes are calculated incorrectly and several pixels of the PDF are shown on the previous image at right.
NicMendonca commentedon May 2, 2023
Okay! I think that makes sense. But yeah, I definitely see this when I scroll through PDFs on iOS
[-]IOS - Chat - Left edge of PDF is visible on the previous image when scrolling through images[/-][+][$1000] IOS - Chat - Left edge of PDF is visible on the previous image when scrolling through images[/+]MelvinBot commentedon May 2, 2023
Job added to Upwork: https://www.upwork.com/jobs/~017d54deaca793736b
MelvinBot commentedon May 2, 2023
Current assignee @NicMendonca is eligible for the External assigner, not assigning anyone new.
MelvinBot commentedon May 2, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (
External)45 remaining items
MonilBhavsar commentedon May 25, 2023
Okay, this is ready to be paid now
fedirjh commentedon May 25, 2023
jliexpensify commentedon May 26, 2023
@MonilBhavsar all good with no regression test GH?
Also, PR was raised on the 13th, and merged on the 17th, so eligible for 50% bonus.
jliexpensify commentedon May 26, 2023
@hellohublot what's your Upworks profile? Can you please add your full name to your GH account so we can easily see who you are? Thanks!
hellohublot commentedon May 26, 2023
@jliexpensify Thanks, https://www.upwork.com/freelancers/~01509ca2c74bfc7073
MonilBhavsar commentedon May 29, 2023
I think we would be required to update tests for regression, as we have removed margin from PDF attachments
MonilBhavsar commentedon May 29, 2023
There are no tests for verifying margin in "Compose box - Attachments (PDF)". If we want, we can add at the last. cc @jliexpensify
jliexpensify commentedon May 30, 2023
Done, paid, closed!