Skip to content

[HOLD for payment 2023-05-25] [$1000] IOS - Chat - Left edge of PDF is visible on the previous image when scrolling through images #18222

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch App and open any chat with several images and PDF
  2. Tap on any image to open preview
  3. Scroll through images

Expected Result:

Each preview has only one image, there are no fragments of neighboring images

Actual Result:

Some pixels of the left edge of PDF is visible on the previous image when scrolling through images

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.8.5

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6036104_PDF-image-scrolling.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017d54deaca793736b
  • Upwork Job ID: 1653383081749323776
  • Last Price Increase: 2023-05-02

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 1, 2023
  2. MelvinBot commented on May 1, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. MelvinBot commented on May 1, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. NicMendonca commented on May 1, 2023

    @NicMendonca
    Contributor

    @kbecciv I can't reliably reproduce this.

    image

    image

    When the next image is a larger, white background PDF, I notice it. But if its a smaller, image I don't. Any ideas?

  5. kbecciv commented on May 2, 2023

    @kbecciv
    Author

    Hello @NicMendonca! Looks like the preview sizes are calculated incorrectly and several pixels of the PDF are shown on the previous image at right.

  6. NicMendonca commented on May 2, 2023

    @NicMendonca
    Contributor

    Okay! I think that makes sense. But yeah, I definitely see this when I scroll through PDFs on iOS

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 2, 2023
  8. changed the title [-]IOS - Chat - Left edge of PDF is visible on the previous image when scrolling through images[/-] [+][$1000] IOS - Chat - Left edge of PDF is visible on the previous image when scrolling through images[/+] on May 2, 2023
  9. MelvinBot commented on May 2, 2023

    @MelvinBot
    Contributor
  10. MelvinBot commented on May 2, 2023

    @MelvinBot
    Contributor

    Current assignee @NicMendonca is eligible for the External assigner, not assigning anyone new.

  11. MelvinBot commented on May 2, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

  12. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 2, 2023
  13. 45 remaining items

  14. MonilBhavsar commented on May 25, 2023

    @MonilBhavsar
    Contributor

    Okay, this is ready to be paid now

  15. fedirjh commented on May 25, 2023

    @fedirjh
    Contributor
  16. jliexpensify commented on May 26, 2023

    @jliexpensify
    Contributor

    @MonilBhavsar all good with no regression test GH?

    Also, PR was raised on the 13th, and merged on the 17th, so eligible for 50% bonus.

  17. jliexpensify commented on May 26, 2023

    @jliexpensify
    Contributor

    @hellohublot what's your Upworks profile? Can you please add your full name to your GH account so we can easily see who you are? Thanks!

  18. hellohublot commented on May 26, 2023

    @hellohublot
    Contributor
  19. MonilBhavsar commented on May 29, 2023

    @MonilBhavsar
    Contributor

    @MonilBhavsar all good with no regression test GH?

    Also, PR was raised on the 13th, and merged on the 17th, so eligible for 50% bonus.

    I think we would be required to update tests for regression, as we have removed margin from PDF attachments

  20. MonilBhavsar commented on May 29, 2023

    @MonilBhavsar
    Contributor

    There are no tests for verifying margin in "Compose box - Attachments (PDF)". If we want, we can add at the last. cc @jliexpensify

    1. In Desktop and web, verify that PDF is of original size with margin on the sides.
    2. In mobile app and browser, verify that no margin is displayed for a PDF.
  21. jliexpensify commented on May 30, 2023

    @jliexpensify
    Contributor

    Done, paid, closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions