You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-05-23] [$1000] Copy pasting suggestion triggering text from sent message does not trigger suggestion emojis #18230
Send any suggestion triggering text like: ':pizza'
Select and copy the sent message and paste it in compose box
Expected Result:
App should trigger suggestion emojis as it does on slack and as it does normally for copy to clipboard text
Actual Result:
App does not trigger suggestion emojis when we copy paste suggestion triggering text from previous messages
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.8.8 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
It is to force the text to becomes LTR because the style from styles.ltr uses writingDirection which is not supported on native (the comment mentioned Android only but looks like iOS doesn't support that style too).
What changes do you think we should make in order to solve the problem?
This issue will be fixed once we allow the emoji suggestion to show when there is a character before a colon, but I also think the LTR unicode is redundant for web because we already use the writingDirection: ltr style. So, we can simply apply the convertToLTR only for native.
I don't think it belongs to StyleUtils.js, so let's move convertToLTR from StyleUtils.js to a new platform specific file in libs to have a different logic.
In index.js, we simply return the text passed as the param, while in index.native.js, we use the same logic as we have now, which is to append with \u2066
changed the title [-]Copy pasting suggestion triggering text from sent message does not trigger suggestion emojis[/-][+][$1000] Copy pasting suggestion triggering text from sent message does not trigger suggestion emojis[/+]on May 4, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.14-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-05-23. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
[@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@thesahindia] Determine if we should create a regression test for this bug.
[@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
MelvinBot commentedon May 1, 2023
Triggered auto assignment to @slafortune (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon May 1, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)bernhardoj commentedon May 2, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Copying and pasting an emoji code from chat message does not show the emoji suggestion.
What is the root cause of that problem?
Every chat message is appended with LTR unicode.
App/src/pages/home/report/ReportActionItemFragment.js
Lines 129 to 131 in 4d4d484
App/src/styles/StyleUtils.js
Lines 728 to 736 in 4d4d484
It is to force the text to becomes LTR because the style from
styles.ltruseswritingDirectionwhich is not supported on native (the comment mentioned Android only but looks like iOS doesn't support that style too).Because now we have the extra character (\u2066), when we select a chat message and copy it, it will also copy the LTR unicode. You can validate it by copy the text and decode it here https://www.online-toolz.com/tools/text-unicode-entities-convertor.php.
So, when we paste the text (let say :pizza) to composer, it will be
\u2006:pizzaCurrently, an emoji suggestion won't show if there is a character before the colon. There is already a report of this here https://expensify.slack.com/archives/C049HHMV9SM/p1678947124050359 which marked as not a bug.
What changes do you think we should make in order to solve the problem?
This issue will be fixed once we allow the emoji suggestion to show when there is a character before a colon, but I also think the LTR unicode is redundant for web because we already use the
writingDirection: ltrstyle. So, we can simply apply theconvertToLTRonly for native.convertToLTRfrom StyleUtils.js to a new platform specific file inlibsto have a different logic.index.js, we simply return the text passed as the param, while inindex.native.js, we use the same logic as we have now, which is to append with\u2066slafortune commentedon May 4, 2023
Issue looks good!
[-]Copy pasting suggestion triggering text from sent message does not trigger suggestion emojis[/-][+][$1000] Copy pasting suggestion triggering text from sent message does not trigger suggestion emojis[/+]MelvinBot commentedon May 4, 2023
Job added to Upwork: https://www.upwork.com/jobs/~011ee31bf40fe883ce
MelvinBot commentedon May 4, 2023
Current assignee @slafortune is eligible for the External assigner, not assigning anyone new.
MelvinBot commentedon May 4, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (
External)26 remaining items
melvin-bot commentedon May 16, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.14-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-05-23. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon May 16, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
slafortune commentedon May 24, 2023
Offers sent to @thesahindia @bernhardoj @dhairyasenjaliya 👍
@thesahindia can you complete the above check list?
dhanashree-sawant commentedon May 24, 2023
Thanks @slafortune, I have accepted the offer.
slafortune commentedon May 24, 2023
Ah shoot! @dhairyasenjaliya - I need to type more letters than
@dhabefore hitting enter!dhairyasenjaliya commentedon May 24, 2023
Seems like no payment due for me here all good @slafortune
slafortune commentedon May 25, 2023
@thesahindia - Shout when you accept the offer. I am OOO but finishing this.
thesahindia commentedon May 26, 2023
@slafortune, accepted!
melvin-bot commentedon May 29, 2023
@cead22, @slafortune, @bernhardoj, @thesahindia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
slafortune commentedon May 30, 2023
complete