Skip to content

[HOLD for payment 2023-12-07] [$2000] magic code input remains highlighted even after not being focused #18244

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. go to login page
  2. enter email and click on continue button
  3. click on outside of the input field to lose focus

Expected Result:

input should not be highlighted after losing focus

Actual Result :

input remains highlighted even after losing focus

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: dev
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-01.at.7.25.20.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1682949436398789

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01790579d65d182333
  • Upwork Job ID: 1653522863070584832
  • Last Price Increase: 2023-05-15

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 1, 2023
  2. MelvinBot commented on May 1, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. MelvinBot commented on May 1, 2023

    @MelvinBot
    Contributor

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. Christinadobrzyn commented on May 2, 2023

    @Christinadobrzyn
    Contributor

    Looks like we have a few focus/cursor issues but I think this one is different.
    I assume what we want is either

    • The cursor to remain on the "Phone or email" line even when clicking the other parts of the landing page
    • Prohibit highlighting the landing page as we do with old dot and on the mobile apps with NewExpensify
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed on May 2, 2023
  6. changed the title [-] DEV: magic code input remains highlighted even after not being focused[/-] [+][$1000] DEV: magic code input remains highlighted even after not being focused[/+] on May 2, 2023
  7. MelvinBot commented on May 2, 2023

    @MelvinBot
    Contributor
  8. MelvinBot commented on May 2, 2023

    @MelvinBot
    Contributor

    Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

  9. MelvinBot commented on May 2, 2023

    @MelvinBot
    Contributor

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 2, 2023
  11. 266 remaining items

  12. melvin-bot commented on Nov 30, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
    • [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
    • [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@MitchExpensify / @Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. Christinadobrzyn commented on Dec 6, 2023

    @Christinadobrzyn
    Contributor

    prepping for payment

    Payouts due:

    Issue Reporter: $250 @gadhiyamanan (in Upwork)
    Contributor: @wojtus7 - no payment through Upwork or NewExpensify since they are a contractor
    Contributor+: $2000 @Santhosh-Sellavel (in NewExpensify)

    Eligible for 50% #urgency bonus? N

    Upwork job is here.

    Do we need a regression test for this?

  14. gadhiyamanan commented on Dec 6, 2023

    @gadhiyamanan
    Contributor

    @Christinadobrzyn offer accepted, thanks!

  15. removed their assignment
    on Dec 7, 2023
  16. Christinadobrzyn commented on Dec 8, 2023

    @Christinadobrzyn
    Contributor

    Awesome! @gadhiyamanan I paid you in Upwork based on the payment structure here - #18244 (comment)

    @Santhosh-Sellavel will you let me know if we need a regression test for this?

  17. Santhosh-Sellavel commented on Dec 10, 2023

    @Santhosh-Sellavel
    Collaborator

    No special regression case test is needed here, existing cases should be enough. We can skip the checklist as well. Let me know if you differ @dangrous

  18. Christinadobrzyn commented on Dec 11, 2023

    @Christinadobrzyn
    Contributor

    Awesome! Thanks @Santhosh-Sellavel - closing this job as complete!

  19. Santhosh-Sellavel commented on Jan 10, 2024

    @Santhosh-Sellavel
    Collaborator

    Requested on ND

  20. JmillsExpensify commented on Jan 14, 2024

    @JmillsExpensify
    Contributor

    $2,000 payment approved for @Santhosh-Sellavel based on this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions