Repository navigation
Request Money -The word "Request" in the conversation appears with a small letter #18359
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Go to URL https://staging.new.expensify.com/
- Login with any account
- Navigate to a conversation
- Click on the + button in the compose box and select Request Money.
Expected Result:
The word "Request" must be displayed in capital letter.
Actual Result:
The word "Request" in the conversation appears with a small letter.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number: 1.3.9.14
Reproducible in staging?: yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6041541_Recording__2375.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Activity
MelvinBot commentedon May 3, 2023
Triggered auto assignment to @sophiepintoraetz (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon May 3, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)OSBotify commentedon May 3, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:MelvinBot commentedon May 3, 2023
Triggered auto assignment to @dangrous (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.marcaaron commentedon May 3, 2023
asking @luacmartins to check this one out I believe he has the most context
dangrous commentedon May 3, 2023
Yeah basically do we need to update the optimistic data, or do we need to adjust the backend to send a capital letter again? I see it was an intentional choice - https://github.com/Expensify/Web-Expensify/pull/37076/commits/ced6a21b3dca719510fda6e9b290543843e5aed2 - but wondering where that comes from?
(and if we update the optimistic data to match, we should also update whatever TestRail it is that says all of these should be capitalized)
marcaaron commentedon May 3, 2023
Ah Carlos M is ooo actually. Let's ask in eng chat.
marcaaron commentedon May 3, 2023
There might also be a plan to update app or an open PR... maybe we just chose to roll out Web first then fix App later.
luacmartins commentedon May 3, 2023
This is the expected behavior. We are updating to lower case letters. I have an app PR in review that addresses that.
luacmartins commentedon May 3, 2023
Closing this issue since it’s the expected behavior
marcaaron commentedon May 3, 2023
Reopening for a second... the expected behavior is for the message to change from capitalized to not capitalized?
marcaaron commentedon May 3, 2023
continuing here -> https://expensify.slack.com/archives/C03TQ48KC/p1683144192710769
dangrous commentedon May 3, 2023
The optimistic data shall be fixed soon! https://github.com/Expensify/App/pull/17583/files
@kbecciv do you have test steps that specify the capital letter
Requested? We'll need to update those, as it will be shifting to always lowercaserequested. Thank you!