Repository navigation
[PAID] Next button is disabled when trying to invite person to workspace #18403
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Regression from #15672
BUG ‘Next’ button is disabled on back navigation even if there is a selected user; as a result user cannot continue to invite the selected user after navigating back
Action Performed:
Click on ‘Profile’ avatar
Click on ‘Workspaces’ link
Open an existing workspace
Click on ‘Manage members’ link
Click on ‘Invite’ button
Enter email address > select user > click on ‘Next’ button
Click on back navigation icon
Expected Result: Next button shouldn’t be disabled as long as there is a selected user
Actual Result: Next button is disabled even thought there is a selected user
Issue 2
Alluded to by @bondydaa #15672 (comment)
Action Performed:
Log in with account that has access to the policy-expense-chat beta
Go offline by navigating to [profile icon] > Preferences > and enable Force offline
Create a new workspace.
Invite some people to the workspace. Verify that workspace chats for each member appear optimistically.
Go online by navigating to [profile icon] > Preferences > disable Force online.
Expected Result:
Workspace chats created for each members are updated accordingly
Actual Result:
??? Something else ???
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
Version Number:
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683077956552549
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01200c513fe2717ddb
- Upwork Job ID: 1654115698073346048
- Last Price Increase: 2023-05-04
Activity
MelvinBot commentedon May 4, 2023
Triggered auto assignment to @strepanier03 (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.MelvinBot commentedon May 4, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01200c513fe2717ddb
MelvinBot commentedon May 4, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)MelvinBot commentedon May 4, 2023
Current assignee @0xmiroslav is eligible for the Internal assigner, not assigning anyone new.
strepanier03 commentedon May 5, 2023
Working on this now.
strepanier03 commentedon May 5, 2023
For issue 1, I cannot recreate the behavior. On staging it works just fine for me, the Next button doesn't get disabled after clicking the back navigation icon. I'll need to test on Prod too.
For issue 2, I'm working on testing this but need to ensure my accounts are part of the beta. Will update once I'm done.
melvin-bot commentedon May 5, 2023
Looks like something related to
react-navigationmay have been mentioned in this issue discussion.As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our
DeprecatedCustomActions.jsfiles should not be accepted.Feel free to drop a note in #expensify-open-source with any questions.
0xmiroslav commentedon May 5, 2023
@strepanier03 this is already fixed in #18395.
This GH is created just for tracking payment, etc.
9 remaining items
melvin-bot commentedon May 9, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-05-16. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon May 9, 2023
strepanier03 commentedon May 9, 2023
@mountiny -- You're correct, internal issues are paid to the C+ at the flat $1000 rate.
I see that you listed @Natnael-Guchima as the bug reporter in the OP comment and I wanted to confirm they get a bug report bonus of $250 with you since you only mentioned paying the C+. Should I whip up a bug report job for Natnael?
mountiny commentedon May 14, 2023
@strepanier03 correct @Natnael-Guchima should also be paid out $250
strepanier03 commentedon May 15, 2023
Gotcha, thank you @mountiny, will take care of setting everything up today.
strepanier03 commentedon May 15, 2023
@0xmiroslav - I have hired you to the job in UpWork, please take a look at the BZ checklist and leave any necessary comments and I'll update the OP checklist with your responses.
@Natnael-Guchima I've also created and hired you to a bug reporting job, please accept and I'll pay out tomorrow as well.
Thank you both!
Natnael-Guchima commentedon May 15, 2023
Accepted! Thanks @strepanier03
0xmiroslav commentedon May 15, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2023-05-16] Next button is disabled when trying to invite person to workspace[/-][+][PAID] Next button is disabled when trying to invite person to workspace[/+]strepanier03 commentedon May 16, 2023
Everything is done here, I've finished paying and closing contracts as well as leaving feedback. Thank you all for the diligence and effort 🙌 .