Skip to content

The behavior of the emoji reaction modal is inconsistent. #18519

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open Website
  2. Go to chat and send/request money
  3. Hover on the message and open actions modal
  4. Click on unread message.

Expected Result:

The emoji reaction modal behavior should be consistent.

Actual Result:

The behavior of the right side emoji reaction modal is inconsistent.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.11-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-05.at.4.08.29.PM.mov
Recording.508.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Tushu17
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683286164251049

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 6, 2023
  2. melvin-bot commented on May 6, 2023

    @melvin-bot

    Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on May 6, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. huzaifa-99 commented on May 7, 2023

    @huzaifa-99
    Contributor

    I think this is an expected behaviour. The request-money/split-bill message does not show delete/edit and copy icons/btns which kind of makes sense.

  5. deleted a comment from melvin-bot on May 12, 2023
  6. deleted a comment from melvin-bot on May 12, 2023
  7. greg-schroeder commented on May 12, 2023

    @greg-schroeder
    Contributor

    @huzaifa-99 Asking the team about what you said, will update soon.

  8. greg-schroeder commented on May 12, 2023

    @greg-schroeder
    Contributor

    After review I think I agree it's expected based on the different nature of the message types - I'm going to close.

  9. Tushu17 commented on May 12, 2023

    @Tushu17
    Contributor

    Hey @greg-schroeder, I think there's a misunderstanding about the bug. The bug here is that the mini action menu will be shown for all the report action items, but when you use an action like mark as unread or copy link, you won't see the mini action menu (it comes for a split second, then disappears). This works fine on a normal text message, but you will see this bug for money messages, attachments, links, etc.

    Screen.Recording.2023-05-12.at.5.56.29.PM.mov
  10. Tushu17 commented on Jun 2, 2023

    @Tushu17
    Contributor
  11. greg-schroeder commented on Jun 2, 2023

    @greg-schroeder
    Contributor

    @Tushu17 Hmm - this was closed after a team discussion. At any rate, I can't reproduce your video on the current build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions