You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-05-16] Login - Text "Link sent" doesn't appear and link is not sent after Unlink button clicked, console error appears #18526
Please re-state the problem that we are trying to solve in this issue.
Unlink button doesn't work on web (throw a console error) and crash on Android/iOS.
What is the root cause of that problem?
The console error already clearly state the error is can't read METHOD of undefined. We are reading it from CONST.ONYX, but this PR #18464 already drop that const, and we should use Onyx.METHOD instead.
What changes do you think we should make in order to solve the problem?
We should replace CONST.ONYX.METHOD with Onyx.METHOD to these functions:
Helllo @roryabraham, @greg-schroeder . I have reported this issue, and the fix was triggered by the report. Isn't this eligible for bonus reporting?
Thanks.
Activity
melvin-bot commentedon May 6, 2023
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 6, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)bernhardoj commentedon May 7, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Unlink button doesn't work on web (throw a console error) and crash on Android/iOS.
What is the root cause of that problem?
The console error already clearly state the error is can't read
METHODof undefined. We are reading it from CONST.ONYX, but this PR #18464 already drop that const, and we should use Onyx.METHOD instead.What changes do you think we should make in order to solve the problem?
We should replace CONST.ONYX.METHOD with Onyx.METHOD to these functions:
App/src/libs/actions/Session/index.js
Lines 653 to 715 in d120f6a
roryabraham commentedon May 9, 2023
Grabbing this quick fix to get it in before the deploy
roryabraham commentedon May 9, 2023
Merged a fix
Natnael-Guchima commentedon May 9, 2023
Helllo @roryabraham, @greg-schroeder . I have reported this issue, and the fix was triggered by the report. Isn't this eligible for bonus reporting?
Thanks.
8 remaining items
Natnael-Guchima commentedon May 9, 2023
A gentle bump @roryabraham #18526 (comment)
roryabraham commentedon May 10, 2023
Reopening for reporting bonus
roryabraham commentedon May 10, 2023
@greg-schroeder the only payment due here is the $250 reporting bonus. Thanks!
greg-schroeder commentedon May 12, 2023
Got it, I'll take care of it on 5/16!
greg-schroeder commentedon May 12, 2023
I'm going to apply
Internaljust to generate an Upwork jobmelvin-bot commentedon May 12, 2023
Job added to Upwork: https://www.upwork.com/jobs/~016d970f1e853d9ed1
melvin-bot commentedon May 12, 2023
Triggered auto assignment to Contributor Plus for review of internal employee PR - @0xmiroslav (
Internal)greg-schroeder commentedon May 12, 2023
Started a reporting bonus contract for @Natnael-Guchima
Natnael-Guchima commentedon May 12, 2023
Accepted. Thanks.