Skip to content

[HOLD for payment 2023-06-30] [$1000] Chat - Deleted messages with heading style not strike-through in offline #18658

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Login to ND
  3. Go to a chat and add a comment, > # Example
  4. Go offline
  5. Delete message with quotes & heading style

Expected Result:

Deleted messages with quotes & heading style not strike-through in offline

Actual Result:

Unknown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.12.0

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

https://platform.applause.com/services/links/v1/external/46a8d74188263bb1897e1e4a7749ded33d49e43661aebf91b349fb4bd53e5edf

Bug6048345_Screen_Recording_20230509_193244_Chrome.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010211de21c6d5876a
  • Upwork Job ID: 1656697403382730752
  • Last Price Increase: 2023-05-18

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 9, 2023
  2. melvin-bot commented on May 9, 2023

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on May 9, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. twisterdotcom commented on May 11, 2023

    @twisterdotcom
  5. twisterdotcom commented on May 11, 2023

    @twisterdotcom
    Contributor

    I think this is actually just Headers that are showing with underline rather than strikethrough:
    image

    It doesn't matter if there is a quote or not.

  6. twisterdotcom commented on May 11, 2023

    @twisterdotcom
    Contributor

    Created another post for the desktop issue: https://expensify.slack.com/archives/C049HHMV9SM/p1683822276071329

  7. changed the title [-]Chat -Deleted messages with quotes & heading style not strike-through in offline[/-] [+]Chat - Deleted messages with heading style not strike-through in offline[/+] on May 11, 2023
  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 11, 2023
  9. changed the title [-]Chat - Deleted messages with heading style not strike-through in offline[/-] [+][$1000] Chat - Deleted messages with heading style not strike-through in offline[/+] on May 11, 2023
  10. melvin-bot commented on May 11, 2023

    @melvin-bot
  11. melvin-bot commented on May 11, 2023

    @melvin-bot

    Current assignee @twisterdotcom is eligible for the External assigner, not assigning anyone new.

  12. melvin-bot commented on May 11, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

  13. 89 remaining items

  14. deleted a comment from melvin-bot on Jun 28, 2023
  15. twisterdotcom commented on Jun 28, 2023

    @twisterdotcom
    Contributor

    Hey @slafortune - I'm OOO for the rest of the week. Could you please handle the payment and test case if required?

  16. mollfpr commented on Jun 29, 2023

    @mollfpr
    Contributor

    [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:

    #17496

    [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    #17496 (comment)

    [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    This should be cached while QA is happened, so regression step should be enough.

    [@mollfpr] Determine if we should create a regression test for this bug.
    [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Prerequisites:
    Set offline the network by going to Settings -> Preferences and toggle on the Force offline

    1. Open the app in Chrome on your desktop.
    2. Go to a chat and add a heading comment. eg: # Example
    3. Go offline by switching off the connection.
    4. Delete the message.
    5. Verify that the message is shown with a strikethrough style (line over the message) and not underlined.

    Additionally, thoroughly test every markdown style.

    Note -

    1. Repeat the steps above for the following messages (feel free to add more) -
      Messages are separated by a new empty line.
    # text header
    
    # header with link.com
    
    # header with emoji 😇
    
    # 😇😇
    
    > # header inside quote with [link](google.com)
    
    `# try header in code`
    
    \```
    multiline code (remove \ before three backticks above and below)
    😅
    link.com
    \```
    
    😋😆😇😇
    
    [normal link](google.com)
    
    1. Also repeat the steps for different attachments - images, PDFs, files without preview like CSVs, docs. Upload them in online mode, go offline and delete them.
      a. After deleting attachments like images, PDFs, GIFs which have preview, their opacity should decrease and user should not be able to open them.
      b. For attachments without previews like CSV, docs, etc. A strikethrough should be shown similar to text comments.
    2. Add any attachments in offline mode. App should keep showing "Uploading attachment...". Delete the attachment. App should show a strikethrough over the text.
  17. slafortune commented on Jun 29, 2023

    @slafortune
    Contributor

    Offers sent @mollfpr @Nikhil-Vats 👍

  18. Nikhil-Vats commented on Jun 29, 2023

    @Nikhil-Vats
    Contributor

    @cristipaval @mollfpr @slafortune This PR was merged after 9 days but it fixes two issues - this one and #17488 and it took a lot of time and effort because it was difficult to come up with an approach that fixed everything without any regression.

    So, I just wanted to request you to take this into account while deciding the payment amount.

  19. cristipaval commented on Jul 3, 2023

    @cristipaval
    Contributor

    I think @twisterdotcom and @slafortune are the ones who can decide about the payment, as they are the BugZero team members assigned to this issue.

  20. twisterdotcom commented on Jul 4, 2023

    @twisterdotcom
    Contributor

    I think we can bonus this for an extra $500 each. @slafortune have you already paid out? I think you can add a bonus anyway if the contract remains open.

    And did you finish the test case? If so, can we close?

  21. parasharrajat commented on Jul 5, 2023

    @parasharrajat
    Member

    On a side note, there was a regression from the first PR #18658 (comment).

  22. slafortune commented on Jul 5, 2023

    @slafortune
    Contributor

    Cool! Paid with bonus - Thanks all for the details and info! Test case was completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions