You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-06-30] [$1000] Chat - Deleted messages with heading style not strike-through in offline #18658
changed the title [-]Chat -Deleted messages with quotes & heading style not strike-through in offline[/-][+]Chat - Deleted messages with heading style not strike-through in offline[/+]on May 11, 2023
changed the title [-]Chat - Deleted messages with heading style not strike-through in offline[/-][+][$1000] Chat - Deleted messages with heading style not strike-through in offline[/+]on May 11, 2023
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
This should be cached while QA is happened, so regression step should be enough.
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Prerequisites: Set offline the network by going to Settings -> Preferences and toggle on the Force offline
Open the app in Chrome on your desktop.
Go to a chat and add a heading comment. eg: # Example
Go offline by switching off the connection.
Delete the message.
Verify that the message is shown with a strikethrough style (line over the message) and not underlined.
Additionally, thoroughly test every markdown style.
Note -
Repeat the steps above for the following messages (feel free to add more) -
Messages are separated by a new empty line.
# text header
# header with link.com
# header with emoji 😇
# 😇😇
> # header inside quote with [link](google.com)
`# try header in code`
\```
multiline code (remove \ before three backticks above and below)
😅
link.com
\```
😋😆😇😇
[normal link](google.com)
Also repeat the steps for different attachments - images, PDFs, files without preview like CSVs, docs. Upload them in online mode, go offline and delete them.
a. After deleting attachments like images, PDFs, GIFs which have preview, their opacity should decrease and user should not be able to open them.
b. For attachments without previews like CSV, docs, etc. A strikethrough should be shown similar to text comments.
Add any attachments in offline mode. App should keep showing "Uploading attachment...". Delete the attachment. App should show a strikethrough over the text.
@cristipaval@mollfpr@slafortune This PR was merged after 9 days but it fixes two issues - this one and #17488 and it took a lot of time and effort because it was difficult to come up with an approach that fixed everything without any regression.
So, I just wanted to request you to take this into account while deciding the payment amount.
I think we can bonus this for an extra $500 each. @slafortune have you already paid out? I think you can add a bonus anyway if the contract remains open.
And did you finish the test case? If so, can we close?
Activity
melvin-bot commentedon May 9, 2023
Triggered auto assignment to @twisterdotcom (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 9, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)twisterdotcom commentedon May 11, 2023
twisterdotcom commentedon May 11, 2023
I think this is actually just Headers that are showing with underline rather than strikethrough:

It doesn't matter if there is a quote or not.
twisterdotcom commentedon May 11, 2023
Created another post for the desktop issue: https://expensify.slack.com/archives/C049HHMV9SM/p1683822276071329
[-]Chat -Deleted messages with quotes & heading style not strike-through in offline[/-][+]Chat - Deleted messages with heading style not strike-through in offline[/+][-]Chat - Deleted messages with heading style not strike-through in offline[/-][+][$1000] Chat - Deleted messages with heading style not strike-through in offline[/+]melvin-bot commentedon May 11, 2023
Job added to Upwork: https://www.upwork.com/jobs/~010211de21c6d5876a
melvin-bot commentedon May 11, 2023
Current assignee @twisterdotcom is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon May 11, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (
External)89 remaining items
twisterdotcom commentedon Jun 28, 2023
Hey @slafortune - I'm OOO for the rest of the week. Could you please handle the payment and test case if required?
mollfpr commentedon Jun 29, 2023
#17496
#17496 (comment)
This should be cached while QA is happened, so regression step should be enough.
Prerequisites:
Set offline the network by going to Settings -> Preferences and toggle on the Force offline
Additionally, thoroughly test every markdown style.
Note -
Messages are separated by a new empty line.
a. After deleting attachments like images, PDFs, GIFs which have preview, their opacity should decrease and user should not be able to open them.
b. For attachments without previews like CSV, docs, etc. A strikethrough should be shown similar to text comments.
slafortune commentedon Jun 29, 2023
Offers sent @mollfpr @Nikhil-Vats 👍
Nikhil-Vats commentedon Jun 29, 2023
@cristipaval @mollfpr @slafortune This PR was merged after 9 days but it fixes two issues - this one and #17488 and it took a lot of time and effort because it was difficult to come up with an approach that fixed everything without any regression.
So, I just wanted to request you to take this into account while deciding the payment amount.
cristipaval commentedon Jul 3, 2023
I think @twisterdotcom and @slafortune are the ones who can decide about the payment, as they are the BugZero team members assigned to this issue.
twisterdotcom commentedon Jul 4, 2023
I think we can bonus this for an extra $500 each. @slafortune have you already paid out? I think you can add a bonus anyway if the contract remains open.
And did you finish the test case? If so, can we close?
parasharrajat commentedon Jul 5, 2023
On a side note, there was a regression from the first PR #18658 (comment).
slafortune commentedon Jul 5, 2023
Cool! Paid with bonus - Thanks all for the details and info! Test case was completed.