You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-05-23] [$1000] Assign Task - No focus on Description field in Assign task #18660
Please re-state the problem that we are trying to solve in this issue.
Assign Task - No focus on Description field in Assign task
What is the root cause of that problem?
The root cause is we are using autoFocus props on NewTaskDescriptionPage.js
What changes do you think we should make in order to solve the problem?
To add autofocus to description field on NewTaskDescriptionPage.js we need to follow the below steps
First need to create ref for the very first <TextInput> where actually we wanna focus on the screen call
Then on <ScreenWrapper> we need to add props onEntryTransitionEnd basically these props are Called when navigated Screen's transition is finished and makes sure that keyboard opens only after the transition resulting in always successful opening keyboard with nice animation across all platform
On simple autoFocus props we do have a common problem in that animation does not seem to work well the best approach is to add onEntryTransitionEnd
ref={el=>this.InputRef=el}// Define new ref onEntryTransitionEnd={()=>this.InputRef&&this.InputRef.focus()}// focus with ref
What alternative solutions did you explore? (Optional)
We can apply the same autoFocus props to NewTaskDescriptionPage.js
but for that, we also need to pass shouldDelayFocus in order to autoFocus on Android as well seems like we have a problem on Android.
Reproduced, and I agree that this is a bug (it's inconsistent with how the Title, Assignee and Share somewhere pages work. I'll assume this is external, but @thienlnam , @JmillsExpensify or @shawnborton let me know if you think this should be internal.
changed the title [-]Assign Task - No focus on Description field in Assign task[/-][+][$1000] Assign Task - No focus on Description field in Assign task[/+]on May 9, 2023
changed the title [-][$1000] Assign Task - No focus on Description field in Assign task[/-][+][HOLD for payment 2023-05-23] [$1000] Assign Task - No focus on Description field in Assign task[/+]on May 16, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.14-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-05-23. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter - N/A - Applause
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@s77rt] The PR that introduced the bug has been identified. Link to the PR:
[@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@s77rt] Determine if we should create a regression test for this bug.
[@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon May 9, 2023
Triggered auto assignment to @conorpendergrast (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 9, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)dhairyasenjaliya commentedon May 9, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
NewTaskDescriptionPage.jsWhat changes do you think we should make in order to solve the problem?
To add autofocus to
descriptionfield onNewTaskDescriptionPage.jswe need to follow the below stepsFirst need to create
reffor the very first<TextInput>where actually we wanna focus on the screen callThen on
<ScreenWrapper>we need to add propsonEntryTransitionEndbasically these props are Called when navigated Screen's transition is finished and makes sure that keyboard opens only after the transition resulting in always successful opening keyboard with nice animation across all platformOn simple
autoFocusprops we do have a common problem in that animation does not seem to work well the best approach is to addonEntryTransitionEndWhat alternative solutions did you explore? (Optional)
autoFocusprops toNewTaskDescriptionPage.jsbut for that, we also need to pass
shouldDelayFocusin order to autoFocus on Android as well seems like we have a problem on Android.conorpendergrast commentedon May 9, 2023
Reproduced, and I agree that this is a bug (it's inconsistent with how the Title, Assignee and Share somewhere pages work. I'll assume this is external, but @thienlnam , @JmillsExpensify or @shawnborton let me know if you think this should be internal.
[-]Assign Task - No focus on Description field in Assign task[/-][+][$1000] Assign Task - No focus on Description field in Assign task[/+]melvin-bot commentedon May 9, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0117d4766144af9638
melvin-bot commentedon May 9, 2023
Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon May 9, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (
External)19 remaining items
[-][$1000] Assign Task - No focus on Description field in Assign task[/-][+][HOLD for payment 2023-05-23] [$1000] Assign Task - No focus on Description field in Assign task[/+]melvin-bot commentedon May 16, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 16, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.14-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-05-23. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon May 16, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
s77rt commentedon May 17, 2023
conorpendergrast commentedon May 23, 2023
Pay day, moving to Daily
conorpendergrast commentedon May 23, 2023
Looks like this qualifies for the urgency bonus too! Adding +50% and paying
conorpendergrast commentedon May 23, 2023
Paid, contracts ended, checklist completed. All done, and closing!