You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-05-29] [$1000] On the "Confirm Task" page, the vertical alignment alignment is off compared with all the previous page ("Next") #18739
Click on FAB button -> Click on Assign task option
Enter title & description
Which will navigate to Confirm task page here notice the green Confirm Task button is vertically off compare to rest of the app
Expected Result:
Green submit button of Confirm Task Should have same vertically spacing as other pages
Actual Result:
Green submit button of Confirm Task is aligned towards bottom doesn't match with other screen
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.12.0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
For other pages like NewTaskDetailsPage.js there is a Form component included on the page, so it will apply safeAreaPaddingBottomStyle via Form component so we can keep includeSafeAreaPaddingBottom as false.
But for NewTaskPage.js page there is no Form component, so FormAlertWithSubmitButton does not have safe area bottom padding applied anyhow. This is the root cause of the problem.
What changes do you think we should make in order to solve the problem?
We have to pass includeSafeAreaPaddingBottom as true at line 153 as shown below.
<ScreenWrapperincludeSafeAreaPaddingBottom>
it will solve the issue as shown in result video.
What alternative solutions did you explore? (Optional)
changed the title [-]On confirm task page the submit button Confirm task vertically alignment is off as compared with all the other page[/-][+][$1000] On confirm task page the submit button Confirm task vertically alignment is off as compared with all the other page[/+]on May 11, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@sobitneupane] Determine if we should create a regression test for this bug.
[@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
[@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
Activity
melvin-bot commentedon May 10, 2023
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 10, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)PrashantMangukiya commentedon May 11, 2023
Proposal
Posting proposal early as per new guidelines
Please re-state the problem that we are trying to solve in this issue.
On confirm task page the submit button Confirm task vertically alignment is off as compared with all the other page
What is the root cause of that problem?
On confirm task page Confirm task button rendered via this code.
App/src/pages/tasks/NewTaskPage.js
Lines 197 to 204 in 9fcbeba
This button is wrapped within Screenwrapper as shown below
App/src/pages/tasks/NewTaskPage.js
Line 153 in 9fcbeba
For other pages like NewTaskDetailsPage.js there is a
Formcomponent included on the page, so it will applysafeAreaPaddingBottomStyleviaFormcomponent so we can keep includeSafeAreaPaddingBottom as false.But for
NewTaskPage.jspage there is no Form component, soFormAlertWithSubmitButtondoes not have safe area bottom padding applied anyhow. This is the root cause of the problem.What changes do you think we should make in order to solve the problem?
We have to pass includeSafeAreaPaddingBottom as true at line 153 as shown below.
it will solve the issue as shown in result video.
What alternative solutions did you explore? (Optional)
None
Results
Before
Before.mov
After
After.mov
jliexpensify commentedon May 11, 2023
Chatted to Jack, who's leading up the tasks project/implementation. He said this is fine to go to External.
[-]On confirm task page the submit button Confirm task vertically alignment is off as compared with all the other page[/-][+][$1000] On confirm task page the submit button Confirm task vertically alignment is off as compared with all the other page[/+]melvin-bot commentedon May 11, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01d16acfe194106a4a
melvin-bot commentedon May 11, 2023
Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon May 11, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (
External)25 remaining items
melvin-bot commentedon May 22, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
jliexpensify commentedon May 30, 2023
Paying today - @sobitneupane can you please complete the checklist? Thanks!
jliexpensify commentedon May 30, 2023
Everyone is paid and job is closed.
sobitneupane commentedon May 31, 2023
#17322
#17322 (comment)
https://expensify.slack.com/archives/C049HHMV9SM/p1685507445902049
sobitneupane commentedon May 31, 2023
Regression Test Proposal
Do we agree 👍 or 👎
flodnv commentedon May 31, 2023
👎 because we could write a hundred tests like this.
I think instead we need a new QA guideline if it does not yet exist, something like "ensure alignment of UI items is consistent throughout the app".
jliexpensify commentedon Jun 2, 2023
@sobitneupane if you agree with Florent, do you have a new Regression Test Proposal? Thanks!
flodnv commentedon Jun 2, 2023
@jliexpensify
we need a new QA guideline, not a testjliexpensify commentedon Jun 5, 2023
@flodnv sorry, I misunderstood! I'm not familiar with QA Guidelines: I searched in SO but couldn't find anything.
Do I need to arrange anything for this QA guideline? (maybe adding it to this doc? - https://docs.google.com/document/d/1UaWlcieiwLnsKfeKw7iwLF7vgYRmdw_-K8OcY5aPBRU/edit)
flodnv commentedon Jun 5, 2023
I think this is a discussion we need to have with our QA team members
jliexpensify commentedon Jun 6, 2023
Ok great, thanks for the guidance Flo - posted here: https://expensify.slack.com/archives/C9YU7BX5M/p1686016991001429
jliexpensify commentedon Jun 6, 2023
Closing this out now, lets convene on that thread for discussion!