Skip to content

[HOLD for payment 2023-05-29] [$1000] On the "Confirm Task" page, the vertical alignment alignment is off compared with all the previous page ("Next") #18739

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app -> Login in account
  2. Click on FAB button -> Click on Assign task option
  3. Enter title & description
  4. Which will navigate to Confirm task page here notice the green Confirm Task button is vertically off compare to rest of the app

Expected Result:

Green submit button of Confirm Task Should have same vertically spacing as other pages

Actual Result:

Green submit button of Confirm Task is aligned towards bottom doesn't match with other screen

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.12.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Snip - (28) New Expensify - Google Chrome (3)

Expensify/Expensify Issue URL:
Issue reported by: @dhairyasenjaliya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683697149428889

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d16acfe194106a4a
  • Upwork Job ID: 1656796284387614720
  • Last Price Increase: 2023-05-11

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 10, 2023
  2. melvin-bot commented on May 10, 2023

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on May 10, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. PrashantMangukiya commented on May 11, 2023

    @PrashantMangukiya
    Contributor

    Proposal

    Posting proposal early as per new guidelines

    Please re-state the problem that we are trying to solve in this issue.

    On confirm task page the submit button Confirm task vertically alignment is off as compared with all the other page

    What is the root cause of that problem?

    On confirm task page Confirm task button rendered via this code.

    <FormAlertWithSubmitButton
    isAlertVisible={submitError}
    message={errorMessage}
    onSubmit={() => onSubmit()}
    enabledWhenOffline
    buttonText={props.translate('newTaskPage.confirmTask')}
    containerStyles={[styles.mh0, styles.mt5, styles.flex1]}
    />

    This button is wrapped within Screenwrapper as shown below

    <ScreenWrapper includeSafeAreaPaddingBottom={false}>

    For other pages like NewTaskDetailsPage.js there is a Form component included on the page, so it will apply safeAreaPaddingBottomStyle via Form component so we can keep includeSafeAreaPaddingBottom as false.

    But for NewTaskPage.js page there is no Form component, so FormAlertWithSubmitButton does not have safe area bottom padding applied anyhow. This is the root cause of the problem.

    What changes do you think we should make in order to solve the problem?

    We have to pass includeSafeAreaPaddingBottom as true at line 153 as shown below.

    <ScreenWrapper includeSafeAreaPaddingBottom>

    it will solve the issue as shown in result video.

    What alternative solutions did you explore? (Optional)

    None

    Results

    Before

    Before.mov

    After

    After.mov
  5. jliexpensify commented on May 11, 2023

    @jliexpensify
    Contributor

    Chatted to Jack, who's leading up the tasks project/implementation. He said this is fine to go to External.

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 11, 2023
  7. changed the title [-]On confirm task page the submit button Confirm task vertically alignment is off as compared with all the other page[/-] [+][$1000] On confirm task page the submit button Confirm task vertically alignment is off as compared with all the other page[/+] on May 11, 2023
  8. melvin-bot commented on May 11, 2023

    @melvin-bot
  9. melvin-bot commented on May 11, 2023

    @melvin-bot

    Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

  10. melvin-bot commented on May 11, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

  11. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 11, 2023
  12. 25 remaining items

  13. melvin-bot commented on May 22, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
    • [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@sobitneupane] Determine if we should create a regression test for this bug.
    • [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  14. jliexpensify commented on May 30, 2023

    @jliexpensify
    Contributor

    Paying today - @sobitneupane can you please complete the checklist? Thanks!

  15. jliexpensify commented on May 30, 2023

    @jliexpensify
    Contributor

    Everyone is paid and job is closed.

  16. sobitneupane commented on May 31, 2023

    @sobitneupane
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

    #17322

    • [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    #17322 (comment)

    • [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    https://expensify.slack.com/archives/C049HHMV9SM/p1685507445902049

  17. sobitneupane commented on May 31, 2023

    @sobitneupane
    Contributor

    Regression Test Proposal

    1. Click FAB > Assign Task
    2. Enter Task title and description and click Next button (at bottom)
    3. It will navigate to Confirm task screen.
    4. Verify that "Confirm task" button has bottom margin similar to previous page button.

    Do we agree 👍 or 👎

  18. flodnv commented on May 31, 2023

    @flodnv
    Contributor

    👎 because we could write a hundred tests like this.

    I think instead we need a new QA guideline if it does not yet exist, something like "ensure alignment of UI items is consistent throughout the app".

  19. jliexpensify commented on Jun 2, 2023

    @jliexpensify
    Contributor

    @sobitneupane if you agree with Florent, do you have a new Regression Test Proposal? Thanks!

  20. flodnv commented on Jun 2, 2023

    @flodnv
    Contributor

    @jliexpensify we need a new QA guideline, not a test

  21. jliexpensify commented on Jun 5, 2023

    @jliexpensify
    Contributor

    @flodnv sorry, I misunderstood! I'm not familiar with QA Guidelines: I searched in SO but couldn't find anything.

    Do I need to arrange anything for this QA guideline? (maybe adding it to this doc? - https://docs.google.com/document/d/1UaWlcieiwLnsKfeKw7iwLF7vgYRmdw_-K8OcY5aPBRU/edit)

  22. flodnv commented on Jun 5, 2023

    @flodnv
    Contributor

    I think this is a discussion we need to have with our QA team members

  23. jliexpensify commented on Jun 6, 2023

    @jliexpensify
    Contributor

    Ok great, thanks for the guidance Flo - posted here: https://expensify.slack.com/archives/C9YU7BX5M/p1686016991001429

  24. jliexpensify commented on Jun 6, 2023

    @jliexpensify
    Contributor

    Closing this out now, lets convene on that thread for discussion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions