[HOLD for payment 2023-05-23] [$1000] IOUPreview height should adjust based on content

@thesahindia

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Create an iou request to any user without adding a comment
Settle the IOU
Create an iou request to any user without adding a comment
Settle the IOU

Expected Result:

The Card heights should be different

Actual Result:

The card heights are the same
The card without a description has a large gap where the comment would have shown

Native mobile

Web

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.13-0
Issue reported by: @thesahindia here

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01d6ca19ff51a2559a
Upwork Job ID: 1656655701807489024
Last Price Increase: 2023-05-11

@twisterdotcom

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Please re-state the problem that we are trying to solve in this issue.

We want the IOUPreview to adjust its height based on content, specifically if it has a comment/description

What is the root cause of that problem?

The <Text> element for comment/description here is rendering always, regardless if there is any comment/description

What changes do you think we should make in order to solve the problem?

We should conditionally render the <Text> component that displays comment/description here by first calculating description/value like this

const requestDescription = Str.htmlDecode(lodashGet(props.action, 'originalMessage.comment', ''))

and then render it like so

{requestDescription && <Text>{requestDescription}</Text>}

Result

What alternative solutions did you explore? (Optional)

N/A

Proposal

Please re-state the problem that we are trying to solve in this issue.

IOUPreview height does not adjust based on comment

What is the root cause of that problem?

The root cause is that we're always rendering the Text here.

What changes do you think we should make in order to solve the problem?

We should render the text only if a comment exists for IOU. This gets replaced with:

// This can be saved in a variable as well
{lodashGet(props.action, 'originalMessage.comment', '') ? <Text style={[styles.colorMuted]}>{Str.htmlDecode(lodashGet(props.action, 'originalMessage.comment', ''))}</Text> : null}

Using && condition above will cause this regression. We should be using ternary instead.

Although not strictly required, we can also convert this and this into ternary expressions as well.

What alternative solutions did you explore? (Optional)

None

thanks both. This is pretty straight forward so I'm going with the first passable proposal (#18770 (comment)). Also creating requestDescription on a separate line is a bit more readable.

@huzaifa-99

@huzaifa-99 feel free to make a start on the PR, I'll assign you once the UpWork job has been created 👍

Actually I don't think anything will break if I do this now

Okay nevermind, that didn't trigger the automation, I'll do that again once Ted gets a chance to review.

Payment still pending guys 😄!

@trjExpensify

@trjExpensify was ooo but should be back today, sorry about that

@mountiny

no worries @mountiny. Thank you!

The issue will remain open until paid, and Tom will be back soon :)

Yuuup, I got back today. 👍 Looking at this now, appreciate the patience.

No PR caused regression. This is more like polish than bug and found during PR review here.
So no need regression test step.

Yup, this was when adding a new feature. Regression tests will be updated more broadly for the manual requests redesign.

@aimane-chnaif

Okay, so my assessment for payments is as follows:

@aimane-chnaif - $1,500 for the C+ review & #urgency bonus
@huzaifa-99 - $1,500 for the fix & #urgency bonus
@thesahindia - $250 for reporting the bug in this PR

Does that sound right to everyone?

Offers have been sent to all three of you in the meantime.

@trjExpensify

Thank you @trjExpensify. Accepted!

@huzaifa-99

Settled up with @huzaifa-99 & @aimane-chnaif. Awaiting @thesahindia and then I'll close this out.

Job ref for ease.

Accepted, thanks!

Awesome, settled. Closing!

Navigation Menu

Repository navigation

[HOLD for payment 2023-05-23] [$1000] IOUPreview height should adjust based on content #18770

Action Performed:

Expected Result:

Actual Result:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

35 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-05-23] [$1000] IOUPreview height should adjust based on content #18770

Description

Action Performed:

Expected Result:

Actual Result:

Platforms:

Activity

melvin-bot commented on May 11, 2023

melvin-bot commented on May 11, 2023

Bug0 Triage Checklist (Main S/O)

huzaifa-99 commented on May 11, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

allroundexperts commented on May 11, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Julesssss commented on May 11, 2023

Julesssss commented on May 11, 2023

Julesssss commented on May 11, 2023

Julesssss commented on May 11, 2023

35 remaining items

huzaifa-99 commented on May 25, 2023

mountiny commented on May 25, 2023

huzaifa-99 commented on May 25, 2023

Julesssss commented on May 25, 2023

trjExpensify commented on May 25, 2023

aimane-chnaif commented on May 25, 2023

trjExpensify commented on May 25, 2023

trjExpensify commented on May 25, 2023

trjExpensify commented on May 25, 2023

huzaifa-99 commented on May 25, 2023

trjExpensify commented on May 25, 2023

thesahindia commented on May 26, 2023

trjExpensify commented on May 26, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions