Repository navigation
[HOLD for payment 2023-05-23] [HOLD for payment 2023-05-22] Request Money - Account list for New Chat or Request money is not displayed while offline #18781
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Login
- Click + New Chat
- Observe you can see possible contacts
- Go offline
- Click + Request money
Expected Result:
List of possible accounts should be displayed
Actual Result:
Skeleton is displayed
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- Windows / Chrome
- MacOS / Desktop
Version Number: 1.3.13.0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
video_79.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Activity
OSBotify commentedon May 11, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon May 11, 2023
Triggered auto assignment to @PauloGasparSv (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.Beamanator commentedon May 11, 2023
Hmm I just tried this in staging web, v1.3.13-0 - and I was able to request money no problem while offline
Beamanator commentedon May 11, 2023
@PauloGasparSv do you have time to get to this today / soonish? If not, do you mind dropping it in #engineering-chat to see who can investigate quick? 🙏
PauloGasparSv commentedon May 11, 2023
Taking a look at this right now @Beamanator : )
Beamanator commentedon May 11, 2023
You're the best!!
PauloGasparSv commentedon May 11, 2023
This is also working for me and I can't replicate this. Pretty confused here, only tested Web so far but the video evidence is from Web so IMO that's ok.
Video evidence
Screen.Recording.2023-05-11.at.14.14.20.mov
Screen.Recording.2023-05-11.at.14.16.05.mov
Also tested on v1.3.13.0
@kbecciv can you double-check if this is still happening? If not let's close this : )
Also please share console logs if the error persists!
PauloGasparSv commentedon May 11, 2023
Oh wait a second, this problem may not be happening to everyone according to this discussion so maybe that's why we can't replicate this @Beamanator
PauloGasparSv commentedon May 11, 2023
Yes, sorry for that! This isn't happening to my
paulo@expensify.comaccount but happens topaulo@expensifail.comin a different session here.This is a little tricky because I can't replicate the problem using the "Offline" preset in the Network tab but only by turning my computer's wifi off.
Sorry for the previous comment @kbecciv, investigating this again here.
PauloGasparSv commentedon May 11, 2023
This may have been introduced by #17349. Coming from this discussion I've assigned @aimane-chnaif here to create fix P.R. (thanks so much)
cc @amyevans
11 remaining items
[-]Request Money - Account list for New Chat or Request money is not displayed while offline[/-][+][HOLD for payment 2023-05-22] Request Money - Account list for New Chat or Request money is not displayed while offline[/+]melvin-bot commentedon May 15, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 15, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.13-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-05-22. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon May 15, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2023-05-22] Request Money - Account list for New Chat or Request money is not displayed while offline[/-][+][HOLD for payment 2023-05-23] [HOLD for payment 2023-05-22] Request Money - Account list for New Chat or Request money is not displayed while offline[/+]melvin-bot commentedon May 16, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.14-14 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-05-23. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon May 16, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: