You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-06-21] [$1000] 'Link sent!' message is not dynamically updated when changing language preference #18827
Add a secondary login account, and leave it unverified
Open new tab
Navigate to sign in page
Enter the unverified email address
Click on Unlink button
Verify that 'Link sent!' message is displayed
Scroll down, and select Spanish as a language preference
Expected Result:
'Link sent!' message should be dynamically updated to Spanish
Actual Result:
'Link sent!' message is not dynamically updated to Spanish
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.13.1 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
What changes do you think we should make in order to solve the problem?
We should store the translation key in the onyx successData message instead of the translated value and In the component, we need to use this translation key to get the value which makes the text language specific.
changed the title [-] 'Link sent!' message is not dynamically updated when changing language preference[/-][+][$1000] 'Link sent!' message is not dynamically updated when changing language preference[/+]on May 18, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@parasharrajat] Determine if we should create a regression test for this bug.
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[@parasharrajat] Determine if we should create a regression test for this bug. Yes
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. #18827 (comment)
For user A go to Settings -> Profile -> Contact Method -> New contact method
Add a new contact method called B
Don't verify the method and logout.
Open the login page in new tab.
Enter unverified id B & click continue.
Click on Unlink button.
Verify the success message Link Sent is shown.
Change the language from the language switch dropdown at the footer of the page. Verify that link sent message changes dynamically on changing the language.
Activity
melvin-bot commentedon May 12, 2023
Triggered auto assignment to @kevinksullivan (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 12, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)Pujan92 commentedon May 12, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Link sent isn't changed dynamically on language change
What is the root cause of that problem?
In the onyx success message we are storing the translated message so it won't get updated on language change.
App/src/libs/actions/Session/index.js
Line 713 in 6d27757
What changes do you think we should make in order to solve the problem?
We should store the translation key in the onyx successData message instead of the translated value and In the component, we need to use this translation key to get the value which makes the text language specific.
App/src/pages/signin/UnlinkLoginForm.js
Lines 65 to 69 in 6d27757
eh2077 commentedon May 12, 2023
Please re-state the problem that we are trying to solve in this issue.
'Link sent!' message is not dynamically updated when changing language preference.
What is the root cause of that problem?
The root cause is that we translate link sent success message here
App/src/libs/actions/Session/index.js
Line 713 in 6d27757
in the success data, which will not be translated into local language here
App/src/pages/signin/UnlinkLoginForm.js
Line 68 in 6d27757
What changes do you think we should make in order to solve the problem?
To fix this issue, we should not translate link sent success message in the success data here
App/src/libs/actions/Session/index.js
Line 713 in 6d27757
but set message code like
message: 'unlinkLoginForm.linkSent'And then translate here
App/src/pages/signin/UnlinkLoginForm.js
Line 68 in 6d27757
We can fix similar issues in file https://github.com/Expensify/App/blob/6d27757667e0757d02a390623c072c69238c7070/src/libs/actions/Session/index.js or even other places
What alternative solutions did you explore? (Optional)
N/A
kevinksullivan commentedon May 13, 2023
Discussing in slack
https://expensify.slack.com/archives/C049HHMV9SM/p1683937177713499?thread_ts=1683649359.591549&cid=C049HHMV9SM
melvin-bot commentedon May 16, 2023
@kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!
kevinksullivan commentedon May 18, 2023
Ok, got the go ahead yesterday on moving this forward in that slack thread above.
[-] 'Link sent!' message is not dynamically updated when changing language preference[/-][+][$1000] 'Link sent!' message is not dynamically updated when changing language preference[/+]51 remaining items
melvin-bot commentedon Jun 14, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
kevinksullivan commentedon Jun 16, 2023
@Natnael-Guchima @parasharrajat @Pujan92 please accept the offer in Upwork when you get a chance. Thanks!
Natnael-Guchima commentedon Jun 23, 2023
@kevinksullivan it seems you have sent me a $1000 offer for bug reporting bonus by accident
kevinksullivan commentedon Jun 23, 2023
Thanks @Natnael-Guchima , I modified the amount on the offer.
kevinksullivan commentedon Jun 23, 2023
@parasharrajat bump on accepting offer, and can you complete the checklist above before we pay this out?
Natnael-Guchima commentedon Jun 23, 2023
You are welcome, @kevinksullivan 🙌. Accepted the offer, thanks.
cristipaval commentedon Jun 26, 2023
bump @parasharrajat
parasharrajat commentedon Jun 26, 2023
[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: #15811
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/15811/files#r1242598881
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1687804792012139
[@parasharrajat] Determine if we should create a regression test for this bug. Yes
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. #18827 (comment)
parasharrajat commentedon Jun 26, 2023
Regression Test Steps
link sentmessage changes dynamically on changing the language.Do you agree 👍 or 👎 ?
kevinksullivan commentedon Jun 26, 2023
Paid out. Thanks everyone!