You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: v1.3.13-1 Reproducible in staging?: needs reproduction Reproducible in production?: needs reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
@situchan I see that the key to reproduce the bug is the unnecessary Backspace press event, so if that event didn't exist the issue won't be reproducible, is that the case? If so then we should hold on #18218 (or close the issue - same root cause).
Activity
melvin-bot commentedon May 12, 2023
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 12, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)situchan commentedon May 12, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
iOS app crashes on magic code input
What is the root cause of that problem?
After enter full 6 numbers, set
focusedIndextoundefinedto blur the input:App/src/components/MagicCodeInput.js
Line 109 in 293f23b
And this makes
editIndexundefined whenBackspacepress event is unnecessarily called (known bug) here:App/src/components/MagicCodeInput.js
Line 210 in 293f23b
And this effect is called again since it has
props.valueas a dependencyAnd finally crashes on this line:
App/src/components/MagicCodeInput.js
Line 108 in 293f23b
because
inputRefs.current[undefined] = undefinedWhat changes do you think we should make in order to solve the problem?
Add
_.isUndefined(editIndex) ||condition in early return conditionkadiealexander commentedon May 16, 2023
@situchan, I'm not able to reproduce this on the latest version (1.3.14-0)
RPReplay_Final1684215315.MP4
Could you please test on the latest version of the app, and share updated reproduction steps if you're still running into it?
BeeMargarida commentedon May 16, 2023
I think this only happens in iOS 16.4 simulators. I think this issue is actually related to this one - #18218
situchan commentedon May 16, 2023
@kadiealexander as the title says, this happens only in developer mode and iOS 16.4 simulator. Not reproducible on staging/production.
kadiealexander commentedon May 17, 2023
I can't get the keyboard to appear on my dev simulator.
2023-05-17_17-46-05.mp4
Asking for someone else to test here.
14 remaining items
kadiealexander commentedon May 23, 2023
Have asked for help reproducing this here.
situchan commentedon May 23, 2023
Another person reproduced and uploaded video: #18218 (comment)
kadiealexander commentedon May 24, 2023
Thanks @situchan! Checking in that issue to see if this is a dupe.
s77rt commentedon May 24, 2023
@situchan I see that the key to reproduce the bug is the unnecessary Backspace press event, so if that event didn't exist the issue won't be reproducible, is that the case? If so then we should hold on #18218 (or close the issue - same root cause).
cc @kadiealexander
situchan commentedon May 24, 2023
yes but fixing crash at least unblocks development and testing on iOS simulator which is @tgolen's concern.
After that, #18218 may exist longer.
s77rt commentedon May 24, 2023
Good point but we don't have to test on iOS 16.4. You can still test using other iOS versions.
aldo-expensify commentedon May 24, 2023
Good point @s77rt , and #18218 looks a lot more annoying than this one, and this one should get resolved once we get #18218 fixed.
Closing as duplicate.
aimane-chnaif commentedon Aug 18, 2023
This bug is still happening to me on iOS 16.4 simulator
Screen.Recording.2023-08-18.at.11.53.38.PM.mov
another case:
#23060 (comment)
Can we re-open this and fix?
cc: @BeeMargarida @s77rt @aldo-expensify @tgolen
s77rt commentedon Aug 21, 2023
@aimane-chnaif Seems working fine from my end. Please double check your pod and project files against these changes https://github.com/Expensify/App/pull/21316/files
Kooha-2023-08-21-15-04-44.mp4
aimane-chnaif commentedon Aug 21, 2023
Checked already.
Note: I reinstalled macOS and cloned fresh repo so there might be additional configuration which is not added to git
BeeMargarida commentedon Aug 21, 2023
@aimane-chnaif Double checked right now, I ran
npm run cleanand installed the pods, everything is working correctly.aimane-chnaif commentedon Aug 21, 2023
Did you run build using command or from Xcode? I used Xcode
BeeMargarida commentedon Aug 21, 2023
Using
npm run ios