You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-08-07] Chat - Delete button is not functional #19066
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-07. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
[@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@0xmiroslav] Determine if we should create a regression test for this bug.
[@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
External issue reporter - internal issue report from @mountiny, no payment - please note that the issue flagged here is not the same bug as this and was part of the parts broken as per this update
Contributor that fixed the issue - internal engineer resolved @luacmartins, no payment
Contributor+ that helped on the issue and/or PR - @0xmiroslav, $1000 payment issued in Upwork
External issue reporter - internal issue report from @mountiny, no payment - please note that the issue flagged here is not the same bug as this and was part of the parts broken as per this update
Contributor that fixed the issue - internal engineer resolved @luacmartins, no payment
External issue reporter - internal issue report from @mountiny, no payment - please note that the issue flagged here is not the same bug as this and was part of the parts broken as per this update
Contributor that fixed the issue - internal engineer resolved @luacmartins, no payment
So just to confirm, we do not need to introduce any regression testing for this, as it is already covered in existing tests, correct @luacmartins@0xmiroslav ?
Activity
melvin-bot commentedon May 16, 2023
Triggered auto assignment to @laurenreidexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 16, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon May 17, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0130f7d5c07b1b4ed7
melvin-bot commentedon May 17, 2023
Triggered auto assignment to Contributor Plus for review of internal employee PR - @0xmiroslav (
Internal)laurenreidexpensify commentedon May 17, 2023
@luacmartins assume you picked this one up?
luacmartins commentedon May 17, 2023
Yup, working on it.
laurenreidexpensify commentedon May 18, 2023
Thanks, can you link the draft PR?
luacmartins commentedon May 18, 2023
Done! #19095
70 remaining items
melvin-bot commentedon Jul 31, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 31, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-08-07. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Jul 31, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
luacmartins commentedon Jul 31, 2023
Ah there you go, seems like automation worked after all just needed to wait for it to get deployed to prod.
laurenreidexpensify commentedon Aug 7, 2023
Payment Summary:
laurenreidexpensify commentedon Aug 7, 2023
@0xmiroslav @luacmartins please advise on regression steps above thanks
0xmiroslav commentedon Aug 7, 2023
This is new feature.
I only reviewed PR initially. @aimane-chnaif put more efforts on testing and also discussed lots of follow-ups on slack.
laurenreidexpensify commentedon Aug 8, 2023
Updated payment summary:
laurenreidexpensify commentedon Aug 9, 2023
Final payment summary:
laurenreidexpensify commentedon Aug 9, 2023
So just to confirm, we do not need to introduce any regression testing for this, as it is already covered in existing tests, correct @luacmartins @0xmiroslav ?
luacmartins commentedon Aug 9, 2023
Correct!