Skip to content

[HOLD for payment 2023-08-07] Chat - Delete button is not functional #19066

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensifail.com
  2. Log in with any account
  3. Click on FAB menu
  4. Select Request money
  5. Select the user and complete the request flow.
  6. Open the Chat with requested money
  7. Click on three dots
  8. Select Delete button

Also this issue: https://expensify.slack.com/archives/C049HHMV9SM/p1684333083150029

Expected Result:

Delete button is functional

Actual Result:

Delete button is not functional

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.14.13

Reproducible in staging?: Yes

Reproducible in production?: No (new feature)

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.2723.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team and @niravkakadiya25

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684237536816689

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0130f7d5c07b1b4ed7
  • Upwork Job ID: 1658743808373661696
  • Last Price Increase: 2023-05-17

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 16, 2023
  2. melvin-bot commented on May 16, 2023

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on May 16, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. self-assigned this
    on May 17, 2023
  5. melvin-bot commented on May 17, 2023

    @melvin-bot
  6. melvin-bot commented on May 17, 2023

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @0xmiroslav (Internal)

  7. laurenreidexpensify commented on May 17, 2023

    @laurenreidexpensify
    Contributor

    @luacmartins assume you picked this one up?

  8. luacmartins commented on May 17, 2023

    @luacmartins
    Contributor

    Yup, working on it.

  9. laurenreidexpensify commented on May 18, 2023

    @laurenreidexpensify
    Contributor

    Thanks, can you link the draft PR?

  10. luacmartins commented on May 18, 2023

    @luacmartins
    Contributor

    Done! #19095

  11. 70 remaining items

  12. melvin-bot commented on Jul 31, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Jul 31, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-08-07. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  14. melvin-bot commented on Jul 31, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
    • [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@0xmiroslav] Determine if we should create a regression test for this bug.
    • [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. luacmartins commented on Jul 31, 2023

    @luacmartins
    Contributor

    Ah there you go, seems like automation worked after all just needed to wait for it to get deployed to prod.

  16. laurenreidexpensify commented on Aug 7, 2023

    @laurenreidexpensify
    Contributor

    Payment Summary:

    • External issue reporter - internal issue report from @mountiny, no payment - please note that the issue flagged here is not the same bug as this and was part of the parts broken as per this update
    • Contributor that fixed the issue - internal engineer resolved @luacmartins, no payment
    • Contributor+ that helped on the issue and/or PR - @0xmiroslav, $1000 payment issued in Upwork
  17. laurenreidexpensify commented on Aug 7, 2023

    @laurenreidexpensify
    Contributor

    @0xmiroslav @luacmartins please advise on regression steps above thanks

  18. 0xmiroslav commented on Aug 7, 2023

    @0xmiroslav
    Contributor

    This is new feature.
    I only reviewed PR initially. @aimane-chnaif put more efforts on testing and also discussed lots of follow-ups on slack.

  19. laurenreidexpensify commented on Aug 8, 2023

    @laurenreidexpensify
    Contributor

    Updated payment summary:

  20. laurenreidexpensify commented on Aug 9, 2023

    @laurenreidexpensify
    Contributor

    Final payment summary:

  21. laurenreidexpensify commented on Aug 9, 2023

    @laurenreidexpensify
    Contributor

    So just to confirm, we do not need to introduce any regression testing for this, as it is already covered in existing tests, correct @luacmartins @0xmiroslav ?

  22. luacmartins commented on Aug 9, 2023

    @luacmartins
    Contributor

    Correct!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions