You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$1000] [HOLD for payment 2023-06-13] Crash on split confirm #19234
(Precondition) Have the desktop app open but not logged in; optionally, throttle your network (see last step)
Log in to web
In a 1:1 DM, select Send money
Copy the URL from the address bar
Modify the URL so that it's a deep link (replace http with new-expensify) and open it
Follow the deep link prompt to open it in desktop
Enter an amount to split and click Next button very quickly (if you are not throttling your network)
Expected Result:
Split confirm page should open
Actual Result:
The app crashes
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: Reproducible in staging?: Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
@amyevans I pulled the changes from the latest version of main and started looking into this. If I quickly open the Send Money page using slow 3G network throttling or deep link into the page (http://localhost:8080/send/new) I get these errors:
tNumberFormatUnitOptions.js:18 Uncaught TypeError: currency cannot be undefined
The above error occurred in the <TextInputWithCurrencySymbol> component:
Uncaught (in promise) TypeError: Cannot read properties of null (reading 'style')
at eval (index.js:11:1)
Screen.Recording.2023-05-19.at.14.10.58.mov
So I can't get to the confirmation screen without the app crashing. In the video you uploaded, the Send Money page works fine and the errors in the console are different (the app crashes once the confirmation page is opened). It looks like these are new issues, do you know if they've been reported?
We have over 1,000 open issues in the repo, so I don't know off the top of my head if they've been reported yet haha. Could you post them in the #expensify-bugs Slack channel? Our QA team is better at spotting duplicates, and if they aren't dupes they will create new issues for them.
We have over 1,000 open issues in the repo, so I don't know off the top of my head if they've been reported yet haha. Could you post them in the #expensify-bugs Slack channel? Our QA team is better at spotting duplicates, and if they aren't dupes they will create new issues for them.
Good point! Sorry, I'm still getting used to this setup :) I posted the bug in the #expensify-bugs channel.
Update: Issue created based on the bug report: #19435
No PRs caused regression. This issue always existed after implement IOU pages but not able to catch because hard to reproduce. This GH was even closed until I clarify clear reproducible video, which is edge case.
So I don't suggest regression test step. If anyone disagrees, we can use this for regression test step.
Activity
melvin-bot commentedon May 18, 2023
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 18, 2023
amyevans commentedon May 18, 2023
@jczekalski please comment on the issue so I can assign you
jczekalski commentedon May 19, 2023
@amyevans
jczekalski commentedon May 19, 2023
@amyevans I pulled the changes from the latest version of main and started looking into this. If I quickly open the Send Money page using slow 3G network throttling or deep link into the page (
http://localhost:8080/send/new) I get these errors:Screen.Recording.2023-05-19.at.14.10.58.mov
So I can't get to the confirmation screen without the app crashing. In the video you uploaded, the Send Money page works fine and the errors in the console are different (the app crashes once the confirmation page is opened). It looks like these are new issues, do you know if they've been reported?
amyevans commentedon May 19, 2023
We have over 1,000 open issues in the repo, so I don't know off the top of my head if they've been reported yet haha. Could you post them in the #expensify-bugs Slack channel? Our QA team is better at spotting duplicates, and if they aren't dupes they will create new issues for them.
jczekalski commentedon May 22, 2023
Good point! Sorry, I'm still getting used to this setup :) I posted the bug in the
#expensify-bugschannel.Update: Issue created based on the bug report: #19435
42 remaining items
greg-schroeder commentedon Jun 13, 2023
Added the label to create an Upwork job, sorry for pings
greg-schroeder commentedon Jun 13, 2023
Sent an offer to @aimane-chnaif
greg-schroeder commentedon Jun 13, 2023
Last step is the checklist @aimane-chnaif!
aimane-chnaif commentedon Jun 13, 2023
No PRs caused regression. This issue always existed after implement IOU pages but not able to catch because hard to reproduce. This GH was even closed until I clarify clear reproducible video, which is edge case.
So I don't suggest regression test step. If anyone disagrees, we can use this for regression test step.
greg-schroeder commentedon Jun 13, 2023
All right. Thanks for running through it. Paid out. Going to close.