Skip to content

[HOLD for payment 2023-06-28] [HOLD for payment 2023-06-23] [$1000] Cursor does not change to I beam on selecting mentions like it does for other clickable links #19303

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. Open any report
  3. Send message with mention
  4. Click and drag to highlight the message containing the message and observe that cursor remains pointer while highlighting and does not change to I beam

Expected Result:

App should change the cursor to I beam while highlighting the mentions part in message as it normally does for email, links etc

Actual Result:

App keeps the cursor as pointer and does not change to I beam while selecting mentions part in message

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.16-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

cursor.not.change.to.I.beam.for.mentions.mp4
Recording.658.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684312696564409

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017477dd353ae7b577
  • Upwork Job ID: 1664022662379630592
  • Last Price Increase: 2023-06-07

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 19, 2023
  2. melvin-bot commented on May 19, 2023

    @melvin-bot

    Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on May 19, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. strepanier03 commented on May 19, 2023

    @strepanier03
    Contributor

    I am testing this and the mentions as well as other clickable links, like embedded URLs are all the point, not the I beam.

    I believe it should be the point because it's clickable whereas the I beam indicates text and typing.

    @kavimuru - Can you weigh in here. I'm not sure about moving this one forward.

  5. melvin-bot commented on May 22, 2023

    @melvin-bot

    @strepanier03 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  6. strepanier03 commented on May 22, 2023

    @strepanier03
    Contributor

    @dhanashree-sawant - I have question about your repro steps. In step 4 you say "Select the mention message and observe that cursor remains pointer while selecting and does not change to I beam".

    By "select" do you mean open up the sent message to editing and then clicking on the mention?

    The reason I ask is because the pointer makes sense to me because the mention is clickable, just like other links.

    If I hyperlink a URL, it should be a pointer because it's clickable, same with the mention.

    Can you help me understand why it should be an I beam if it's clickable?

  7. dhanashree-sawant commented on May 24, 2023

    @dhanashree-sawant

    Hi @strepanier03, if you see email, URL, they are all clickable but when we select by dragging over them, cursor changes to I beam, if we want to keep the cursor as pointer while drag and select, we should do that too on email and URL to maintain consistency.

  8. strepanier03 commented on May 31, 2023

    @strepanier03
    Contributor

    Aaah, I think I didn't understand that "select" meant to drag over the message, not click (select) on them. I'll go through it again and update the OP comment with the clarification.

  9. 72 remaining items

  10. JmillsExpensify commented on Jun 29, 2023

    @JmillsExpensify
    Contributor

    Offers sent to contributor and issue reporter.

  11. dhanashree-sawant commented on Jun 30, 2023

    @dhanashree-sawant

    Thanks I have accepted the offer.

  12. melvin-bot commented on Jul 4, 2023

    @melvin-bot

    @JmillsExpensify, @eVoloshchak, @joelbettner, @tienifr Huh... This is 4 days overdue. Who can take care of this?

  13. JmillsExpensify commented on Jul 5, 2023

    @JmillsExpensify
    Contributor

    @eVoloshchak Did you request payment via New Expensify? Everyone else has been paid out at this point.

  14. eVoloshchak commented on Jul 5, 2023

    @eVoloshchak
  15. eVoloshchak commented on Jul 5, 2023

    @eVoloshchak
  16. eVoloshchak commented on Jul 10, 2023

    @eVoloshchak
    Contributor

    @JmillsExpensify, this has been paid out and can be closed

  17. joelbettner commented on Jul 12, 2023

    @joelbettner

    I'm going to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions