Skip to content

[HOLD for payment 2023-05-29] [$1000] iOS/iPad - Buttons to add attachments, delete workspace, and upload an avatar are unrepsonsive #19310

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Start iOS / iPad App and login in any account
  2. Go to Settings > Profile or Settings > Workspaces > Any workspace > General settings
  3. Tap to avatar
  4. Tap to 'Upload photo'
    ===
  5. Go to any chat
  6. Tap on [ + ] on composer
  7. Tap to 'Add attachments'
    ===
  8. Start iOS / iPad App
  9. Login with any accounts - gmail or expensifail.
  10. Create workspace or goto new workspace.
  11. Tap '2 dots' button and tap 'Delete workspace'

Expected Result:

  1. User can select and upload photo for avatar.
  2. User can select and upload file in chat.
  3. Workspace deleted. User is on the 'Create new workspace' page.

Actual Result:

  1. Nothing happens. 'Upload photo' button is not working.
  2. Nothing happens. 'Add attachment' button is not working.
  3. The user cannot delete the workspace. After clicking on 'Delete workspace', the application freezes. The workspace is not deleted.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native - iPad
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.16.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Bug6061224_iPad-iOS-attachment-not-working.mp4
Bug6061224_iOS-cannot-upload-avatar.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d61f5eb9f4d23355
  • Upwork Job ID: 1659749803863924736
  • Last Price Increase: 2023-05-20

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 19, 2023
  2. melvin-bot commented on May 19, 2023

    @melvin-bot

    Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on May 19, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. greg-schroeder commented on May 20, 2023

    @greg-schroeder
    Contributor

    Reviewing

  5. greg-schroeder commented on May 20, 2023

    @greg-schroeder
    Contributor

    I reproduced this on an iPad via Browserstack:

    2023-05-19_19-31-22.mp4
  6. changed the title [-]iOS/iPad - User can't upload avatar and add attachments. Buttons are not working.[/-] [+]iOS/iPad - Buttons to add attachments, delete workspace, and upload an avatar are unrepsonsive[/+] on May 20, 2023
  7. greg-schroeder commented on May 20, 2023

    @greg-schroeder
    Contributor

    Added the unresponsive delete workspace button from #19312

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 20, 2023
  9. changed the title [-]iOS/iPad - Buttons to add attachments, delete workspace, and upload an avatar are unrepsonsive[/-] [+][$1000] iOS/iPad - Buttons to add attachments, delete workspace, and upload an avatar are unrepsonsive[/+] on May 20, 2023
  10. melvin-bot commented on May 20, 2023

    @melvin-bot
  11. melvin-bot commented on May 20, 2023

    @melvin-bot

    Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.

  12. melvin-bot commented on May 20, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

  13. 32 remaining items

  14. greg-schroeder commented on May 25, 2023

    @greg-schroeder
    Contributor

    @puneetlath @rushatgabhane - Can either of you clarify why this was deployed twice (thus creating two automated Melvin payment hold/checklist posts?) I'm sure it's something obvious but I couldn't really tell looking at the PR

    I asked for 👀 here just in case

  15. mountiny commented on May 25, 2023

    @mountiny
    Contributor

    I believe this is a bug when we CPed the PR to staging, speeding up the deployment process. i saw it happen couple of times but the logic there is quite finicky to try to fix this.

    You can take the earlier date as valid here

  16. changed the title [-][HOLD for payment 2023-06-01] [HOLD for payment 2023-05-29] [$1000] iOS/iPad - Buttons to add attachments, delete workspace, and upload an avatar are unrepsonsive[/-] [+][HOLD for payment 2023-05-29] [$1000] iOS/iPad - Buttons to add attachments, delete workspace, and upload an avatar are unrepsonsive[/+] on May 26, 2023
  17. greg-schroeder commented on May 26, 2023

    @greg-schroeder
    Contributor

    Word, thanks Vit!

  18. deleted a comment from melvin-bot on May 26, 2023
  19. deleted a comment from melvin-bot on May 26, 2023
  20. greg-schroeder commented on May 30, 2023

    @greg-schroeder
    Contributor

    Working on finalizing this one today (back from holiday)

  21. greg-schroeder commented on May 30, 2023

    @greg-schroeder
    Contributor

    Offers sent to @rushatgabhane @tienifr

    Next up is @rushatgabhane's checklist

  22. rushatgabhane commented on May 30, 2023

    @rushatgabhane
    Member

    @greg-schroeder i see this message for the offer

    image
  23. rushatgabhane commented on May 30, 2023

    @rushatgabhane
    Member
    1. The PR that introduced the bug has been identified. Link to the PR: Add pay button to money request header #18692

    2. The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/18692/files#r1210078670

    3. A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: It's part of checklist. The component was refactored but missed testing all buttons.

    4. Determine if we should create a regression test for this bug. - No. Applause caught this bug.

    5. If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.

  24. greg-schroeder commented on May 30, 2023

    @greg-schroeder
    Contributor

    That is ... weird. I will try again. Re-issued.

  25. greg-schroeder commented on May 30, 2023

    @greg-schroeder
    Contributor

    Paid. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions