You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-05-29] [$1000] iOS/iPad - Buttons to add attachments, delete workspace, and upload an avatar are unrepsonsive #19310
Go to Settings > Profile or Settings > Workspaces > Any workspace > General settings
Tap to avatar
Tap to 'Upload photo'
===
Go to any chat
Tap on [ + ] on composer
Tap to 'Add attachments'
===
Start iOS / iPad App
Login with any accounts - gmail or expensifail.
Create workspace or goto new workspace.
Tap '2 dots' button and tap 'Delete workspace'
Expected Result:
User can select and upload photo for avatar.
User can select and upload file in chat.
Workspace deleted. User is on the 'Create new workspace' page.
Actual Result:
Nothing happens. 'Upload photo' button is not working.
Nothing happens. 'Add attachment' button is not working.
The user cannot delete the workspace. After clicking on 'Delete workspace', the application freezes. The workspace is not deleted.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native - iPad
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: 1.3.16.5 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-]iOS/iPad - User can't upload avatar and add attachments. Buttons are not working.[/-][+]iOS/iPad - Buttons to add attachments, delete workspace, and upload an avatar are unrepsonsive[/+]on May 20, 2023
changed the title [-]iOS/iPad - Buttons to add attachments, delete workspace, and upload an avatar are unrepsonsive[/-][+][$1000] iOS/iPad - Buttons to add attachments, delete workspace, and upload an avatar are unrepsonsive[/+]on May 20, 2023
@puneetlath@rushatgabhane - Can either of you clarify why this was deployed twice (thus creating two automated Melvin payment hold/checklist posts?) I'm sure it's something obvious but I couldn't really tell looking at the PR
I believe this is a bug when we CPed the PR to staging, speeding up the deployment process. i saw it happen couple of times but the logic there is quite finicky to try to fix this.
changed the title [-][HOLD for payment 2023-06-01] [HOLD for payment 2023-05-29] [$1000] iOS/iPad - Buttons to add attachments, delete workspace, and upload an avatar are unrepsonsive[/-][+][HOLD for payment 2023-05-29] [$1000] iOS/iPad - Buttons to add attachments, delete workspace, and upload an avatar are unrepsonsive[/+]on May 26, 2023
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: It's part of checklist. The component was refactored but missed testing all buttons.
Determine if we should create a regression test for this bug. - No. Applause caught this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.
Activity
melvin-bot commentedon May 19, 2023
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 19, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)greg-schroeder commentedon May 20, 2023
Reviewing
greg-schroeder commentedon May 20, 2023
I reproduced this on an iPad via Browserstack:
2023-05-19_19-31-22.mp4
[-]iOS/iPad - User can't upload avatar and add attachments. Buttons are not working.[/-][+]iOS/iPad - Buttons to add attachments, delete workspace, and upload an avatar are unrepsonsive[/+]greg-schroeder commentedon May 20, 2023
Added the unresponsive delete workspace button from #19312
[-]iOS/iPad - Buttons to add attachments, delete workspace, and upload an avatar are unrepsonsive[/-][+][$1000] iOS/iPad - Buttons to add attachments, delete workspace, and upload an avatar are unrepsonsive[/+]melvin-bot commentedon May 20, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01d61f5eb9f4d23355
melvin-bot commentedon May 20, 2023
Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon May 20, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (
External)32 remaining items
greg-schroeder commentedon May 25, 2023
@puneetlath @rushatgabhane - Can either of you clarify why this was deployed twice (thus creating two automated Melvin payment hold/checklist posts?) I'm sure it's something obvious but I couldn't really tell looking at the PR
I asked for 👀 here just in case
mountiny commentedon May 25, 2023
I believe this is a bug when we CPed the PR to staging, speeding up the deployment process. i saw it happen couple of times but the logic there is quite finicky to try to fix this.
You can take the earlier date as valid here
[-][HOLD for payment 2023-06-01] [HOLD for payment 2023-05-29] [$1000] iOS/iPad - Buttons to add attachments, delete workspace, and upload an avatar are unrepsonsive[/-][+][HOLD for payment 2023-05-29] [$1000] iOS/iPad - Buttons to add attachments, delete workspace, and upload an avatar are unrepsonsive[/+]greg-schroeder commentedon May 26, 2023
Word, thanks Vit!
greg-schroeder commentedon May 30, 2023
Working on finalizing this one today (back from holiday)
greg-schroeder commentedon May 30, 2023
Offers sent to @rushatgabhane @tienifr
Next up is @rushatgabhane's checklist
rushatgabhane commentedon May 30, 2023
@greg-schroeder i see this message for the offer
rushatgabhane commentedon May 30, 2023
The PR that introduced the bug has been identified. Link to the PR: Add pay button to money request header #18692
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/18692/files#r1210078670
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: It's part of checklist. The component was refactored but missed testing all buttons.
Determine if we should create a regression test for this bug. - No. Applause caught this bug.
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again - N.A.
greg-schroeder commentedon May 30, 2023
That is ... weird. I will try again. Re-issued.
greg-schroeder commentedon May 30, 2023
Paid. Closing.