[HOLD for payment 2023-06-05] [$1000] Link to a Broken/Unfunctional Page

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to setting > Help > Playbook > Expensify Playbook for US Based Bootstrapped Startups
Notice the "Step 1: Create your Expensify account" title
In the article under the title "Step 1: Create your Expensify account" Click the link "new.expensify.com"
notice the resulting page

Expected Result:

A new sign-up Page

Actual Result:

Broken image with error reporting and a "The page is no where to be found." text

This line has a broken URL
This line has a typo on Expensify in the URL, and needs to be prefixed by https://
This line needs to be made into a hyperlink to https://new.expensify.com
This line needs to be made into a hyperlink to https://new.expensify.com
This line needs to be made into a hyperlink to https://new.expensify.com

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.16-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

New.Expensify.-.Google.Chrome.2023-05-19.11-30-08.mp4

Recording.718.mp4

Expensify/Expensify Issue URL:
Issue reported by: @amanuel-arega
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684485277897929

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01bbc1f4dbe451c351
Upwork Job ID: 1660718109505835008
Last Price Increase: 2023-05-22

@conorpendergrast

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Please re-state the problem that we are trying to solve in this issue.

Link to a Broken/Unfunctional Page

What is the root cause of that problem?

The link is not given correctly here

App/docs/articles/playbooks/Expensify-Playbook-for-US-Based-Bootstrapped-Startups.md

Line 17 in 23e5de4

    
           If you don't already have one, go to *[new.expensify.com](new.expensifiy.com)* and sign up for an account with your business email address.

It should start with `https://

What changes do you think we should make in order to solve the problem?

Update it to be https://new.expensify.com

What alternative solutions did you explore? (Optional)

Also I noticed two instances where old link is used(expensify.com). I don't know if it is intentional or not. We can also update them to use new link:
1.

App/docs/articles/playbooks/Expensify-Playbook-for-Small-to-Medium-Sized-Businesses.md

Line 17 in 23e5de4

    
           If you don't already have one, go to [Expensify.com](https://expensify.com) and sign up for an account with your work email address. The account is free so don’t worry about the cost at this stage.

App/docs/articles/playbooks/Expensify-Playbook-for-US-based-VC-Backed-Startups.md

Line 18 in 23e5de4

    
           If you don't already have one, go to [Expensify.com](https://expensify.com) and sign up for an account with your work email address. The account is free so don’t worry about the cost at this stage.

Updated with alternative solution - #19396 (comment)

Job added to Upwork: https://www.upwork.com/jobs/~01bbc1f4dbe451c351

@conorpendergrast

Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.

@aimane-chnaif

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.19-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Docs updated links #19434

If no regressions arise, payment will be issued on 2023-06-05. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@aimane-chnaif

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
[@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@aimane-chnaif] Determine if we should create a regression test for this bug.
[@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@conorpendergrast] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@aimane-chnaif

Paid, with urgency bonus, @aimane-chnaif and @alitoshmatov. Waiting for contract to be accepted to pay amanuel-arega

Still waiting for amanuel-arega, will ping via Slack

Paid amanuel-arega!

Final step is the bugzero checklist

This is doc update so I don't think any regression test step is needed.

I would tend to agree, yes. Closing out!

Navigation Menu

Repository navigation

[HOLD for payment 2023-06-05] [$1000] Link to a Broken/Unfunctional Page #19396

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

27 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-06-05] [$1000] Link to a Broken/Unfunctional Page #19396

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on May 22, 2023

melvin-bot commented on May 22, 2023

Bug0 Triage Checklist (Main S/O)

alitoshmatov commented on May 22, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

alitoshmatov commented on May 22, 2023

melvin-bot commented on May 22, 2023

melvin-bot commented on May 22, 2023

melvin-bot commented on May 22, 2023

27 remaining items

melvin-bot commented on May 29, 2023

melvin-bot commented on May 29, 2023

melvin-bot commented on May 29, 2023

conorpendergrast commented on Jun 6, 2023

conorpendergrast commented on Jun 7, 2023

conorpendergrast commented on Jun 7, 2023

conorpendergrast commented on Jun 7, 2023

aimane-chnaif commented on Jun 7, 2023

conorpendergrast commented on Jun 9, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions