You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-06-08] [$1000] New tagline after marking as unread have overlapping line #19443
So when the message next to the first message of the thread is marked as read, we will see both this line and mark as read line.
What changes do you think we should make in order to solve the problem?
We should only show this line when the message next to the first message of the thread is already read.
So we should add new props to ReportActionItemParentAction in order to show threadDividerLine only when the message next to the first message of the thread is already read.
So we should update in here:
// check if the second message of the thread is unread, then hide the divider line.constshouldHideThreadDividerLine=sortedReportActions.length>1&&sortedReportActions[sortedReportActions.length-2].reportActionID===newMarkerReportActionID;<ReportActionItemParentActionshouldHideThreadDividerLine={shouldHideThreadDividerLine}shouldDisplayNewMarker={shouldDisplayNewMarker}reportID={report.reportID}parentReportID={`${report.parentReportID}`}/>
and inside ReportActionItemParentAction we also need to update the condition of threadDividerLine.
changed the title [-]New tagline after marking as unread have overlapping line[/-][+][$1000] New tagline after marking as unread have overlapping line[/+]on May 23, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.21-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-08. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
The regression step should be done the job.
[@mollfpr] Determine if we should create a regression test for this bug.
👍
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Activity
melvin-bot commentedon May 23, 2023
Triggered auto assignment to @maddylewis (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 23, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)hungvu193 commentedon May 23, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
New tagline after marking as unread have overlapping line
What is the root cause of that problem?
Inside
ReportActionItemParentActionwe're always show this divider line:App/src/pages/home/report/ReportActionItemParentAction.js
Line 70 in b424edc
So when the message next to the first message of the thread is marked as read, we will see both this line and mark as read line.
What changes do you think we should make in order to solve the problem?
We should only show this line when the message next to the first message of the thread is already read.
So we should add new props to
ReportActionItemParentActionin order to showthreadDividerLineonly when the message next to the first message of the thread is already read.So we should update in here:
App/src/pages/home/report/ReportActionsList.js
Lines 113 to 121 in b424edc
and inside
ReportActionItemParentActionwe also need to update the condition of threadDividerLine.What alternative solutions did you explore? (Optional)
N/A
[-]New tagline after marking as unread have overlapping line[/-][+][$1000] New tagline after marking as unread have overlapping line[/+]melvin-bot commentedon May 23, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01505a287c67df838e
melvin-bot commentedon May 23, 2023
Current assignee @maddylewis is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon May 23, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (
External)melvin-bot commentedon May 23, 2023
Triggered auto assignment to @johnmlee101 (
External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.17 remaining items
melvin-bot commentedon Jun 1, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jun 1, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.21-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-06-08. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Jun 1, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
maddylewis commentedon Jun 8, 2023
Payments
maddylewis commentedon Jun 8, 2023
@hungvu193 - will you link me to your Upwork profile? thank you!
hungvu193 commentedon Jun 8, 2023
@maddylewis sure,
https://www.upwork.com/freelancers/~01ff54c35a1f76441a
mollfpr commentedon Jun 9, 2023
#18522
https://github.com/Expensify/App/pull/18522/files#r1224549578
The regression step should be done the job.
👍
maddylewis commentedon Jun 12, 2023
@abhilup - will you accept the offer in Upwork so that i can process your payment / close out this issue? thanks!
abhilup commentedon Jun 13, 2023
@maddylewis - just accepted the offer. Thank you.
maddylewis commentedon Jun 13, 2023
thanks!