Skip to content

[HOLD for payment 2023-06-08] [$1000] New tagline after marking as unread have overlapping line #19443

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. Open any report
  3. Send any message
  4. Click on reply to thread on message
  5. Send any message on thread
  6. Now, mark as unread the thread message

Expected Result:

Should show normal new tagline without overlapping border like line maybe from container of message above

Actual Result:

Overlapped by border like line

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.17.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

appVid.mov

IMG_6265

Expensify/Expensify Issue URL:

Issue reported by: @abhilup

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684409736359709

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01505a287c67df838e
  • Upwork Job ID: 1661044912992686080
  • Last Price Increase: 2023-05-23

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 23, 2023
  2. melvin-bot commented on May 23, 2023

    @melvin-bot

    Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on May 23, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  4. hungvu193 commented on May 23, 2023

    @hungvu193
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    New tagline after marking as unread have overlapping line

    What is the root cause of that problem?

    Inside ReportActionItemParentAction we're always show this divider line:

    <View style={[styles.threadDividerLine]} />

    So when the message next to the first message of the thread is marked as read, we will see both this line and mark as read line.

    What changes do you think we should make in order to solve the problem?

    We should only show this line when the message next to the first message of the thread is already read.
    So we should add new props to ReportActionItemParentAction in order to show threadDividerLine only when the message next to the first message of the thread is already read.
    So we should update in here:

    const renderItem = useCallback(
    ({item: reportAction, index}) => {
    // When the new indicator should not be displayed we explicitly set it to null
    const shouldDisplayNewMarker = reportAction.reportActionID === newMarkerReportActionID;
    const shouldDisplayParentAction = reportAction.actionName === CONST.REPORT.ACTIONS.TYPE.CREATED && ReportUtils.isThread(report);
    return shouldDisplayParentAction ? (
    <ReportActionItemParentAction
    reportID={report.reportID}
    parentReportID={`${report.parentReportID}`}

    // check if the second message of the thread is unread, then hide the divider line.
    const shouldHideThreadDividerLine = sortedReportActions.length > 1 && 
    sortedReportActions[sortedReportActions.length -2].reportActionID === newMarkerReportActionID;
    
                    <ReportActionItemParentAction
                        shouldHideThreadDividerLine={shouldHideThreadDividerLine}
                        shouldDisplayNewMarker={shouldDisplayNewMarker}
                        reportID={report.reportID}
                        parentReportID={`${report.parentReportID}`}
                    />

    and inside ReportActionItemParentAction we also need to update the condition of threadDividerLine.

    {!props.shouldHideThreadDividerLine && <View style={[styles.threadDividerLine]} />}

    What alternative solutions did you explore? (Optional)

    N/A

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 23, 2023
  6. changed the title [-]New tagline after marking as unread have overlapping line[/-] [+][$1000] New tagline after marking as unread have overlapping line[/+] on May 23, 2023
  7. melvin-bot commented on May 23, 2023

    @melvin-bot
  8. melvin-bot commented on May 23, 2023

    @melvin-bot

    Current assignee @maddylewis is eligible for the External assigner, not assigning anyone new.

  9. melvin-bot commented on May 23, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 23, 2023
  11. melvin-bot commented on May 23, 2023

    @melvin-bot

    Triggered auto assignment to @johnmlee101 (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  12. 17 remaining items

  13. melvin-bot commented on Jun 1, 2023

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Jun 1, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.21-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-06-08. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  15. melvin-bot commented on Jun 1, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
    • [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@mollfpr] Determine if we should create a regression test for this bug.
    • [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. maddylewis commented on Jun 8, 2023

    @maddylewis
    Contributor

    Payments

    • reporting bonus - abhilup ($250) - offer sent
    • contributor - @hungvu193 ($1000) - offer sent
    • C+ - @mollfpr ($1000) - offer sent
  17. maddylewis commented on Jun 8, 2023

    @maddylewis
    Contributor

    @hungvu193 - will you link me to your Upwork profile? thank you!

  18. hungvu193 commented on Jun 8, 2023

    @hungvu193
    Contributor
  19. mollfpr commented on Jun 9, 2023

    @mollfpr
    Contributor

    [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:

    #18522

    [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

    https://github.com/Expensify/App/pull/18522/files#r1224549578

    [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

    The regression step should be done the job.

    [@mollfpr] Determine if we should create a regression test for this bug.

    👍

    [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    1. Open the app
    2. Open any report
    3. Send any message
    4. Click on reply to a thread on message
    5. Send any message on the thread
    6. Now, mark as unread the thread message
    7. Verify that the new tagline is not overlapped.
    8. 👍 or 👎
  20. maddylewis commented on Jun 12, 2023

    @maddylewis
    Contributor

    @abhilup - will you accept the offer in Upwork so that i can process your payment / close out this issue? thanks!

  21. abhilup commented on Jun 13, 2023

    @abhilup

    @maddylewis - just accepted the offer. Thank you.

  22. maddylewis commented on Jun 13, 2023

    @maddylewis
    Contributor

    thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions