You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-06-05] Thread Attachment is not translated into Spanish In LHN #19467
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@parasharrajat] Determine if we should create a regression test for this bug.
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: There is no need for any discussion on this issue. It is a simple translation-related change.
[@parasharrajat] Determine if we should create a regression test for this bug. Yes
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. #19467 (comment)
Activity
melvin-bot commentedon May 23, 2023
Triggered auto assignment to @maddylewis (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 23, 2023
melvin-bot commentedon May 24, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01fd375ab383f2bad8
melvin-bot commentedon May 24, 2023
Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (
Internal)Gonals commentedon May 24, 2023
I'll do a quick fix for this
5 remaining items
melvin-bot commentedon May 29, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
maddylewis commentedon Jun 5, 2023
Payments
ayazhussain79 commentedon Jun 5, 2023
@maddylewis offer accepted
maddylewis commentedon Jun 5, 2023
@parasharrajat - whenever you have a chance, will you review this checklist to confirm if we need to do any of those steps? thanks!
#19467 (comment)
parasharrajat commentedon Jun 7, 2023
[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: #18522
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/18522/files#r1220854240
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: There is no need for any discussion on this issue. It is a simple translation-related change.
[@parasharrajat] Determine if we should create a regression test for this bug. Yes
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. #19467 (comment)
parasharrajat commentedon Jun 7, 2023
Regression Test Steps
Do you agree 👍 or 👎 ?
maddylewis commentedon Jun 7, 2023
Added regression test proposal to for Applause to add to Test Rail. Just waiting for @parasharrajat to accept the offer so i can process payment :)
maddylewis commentedon Jun 8, 2023
paid!