Skip to content

[HOLD for payment 2023-06-05] Thread Attachment is not translated into Spanish In LHN #19467

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to Settings > Preferences > Language
  2. Select Spanish language and go back
  3. Now open a Chat
  4. Send an Attachment to user
  5. Click on "Reply in thread"
  6. Check Attachment LHN

Expected Result:

Thread Attachment should be translated into Spanish In LHN

Actual Result:

Thread Attachment is not translated into Spanish In LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.17.0

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image (44)

Screenshot_30

Expensify/Expensify Issue URL:

Issue reported by: @ayazhussain79

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684419305175989

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01fd375ab383f2bad8
  • Upwork Job ID: 1661306443832766464
  • Last Price Increase: 2023-05-24

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 23, 2023
  2. melvin-bot commented on May 23, 2023

    @melvin-bot

    Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot commented on May 23, 2023

    @melvin-bot
  4. self-assigned this
    on May 24, 2023
  5. added
    InternalRequires API changes or must be handled by Expensify staff
    on May 24, 2023
  6. melvin-bot commented on May 24, 2023

    @melvin-bot
  7. melvin-bot commented on May 24, 2023

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @parasharrajat (Internal)

  8. Gonals commented on May 24, 2023

    @Gonals
    Contributor

    I'll do a quick fix for this

  9. 5 remaining items

  10. melvin-bot commented on May 29, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
    • [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@parasharrajat] Determine if we should create a regression test for this bug.
    • [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  11. maddylewis commented on Jun 5, 2023

    @maddylewis
    Contributor

    Payments

  12. ayazhussain79 commented on Jun 5, 2023

    @ayazhussain79
    Contributor

    @maddylewis offer accepted

  13. added and removed on Jun 5, 2023
  14. maddylewis commented on Jun 5, 2023

    @maddylewis
    Contributor

    @parasharrajat - whenever you have a chance, will you review this checklist to confirm if we need to do any of those steps? thanks!

    #19467 (comment)

  15. parasharrajat commented on Jun 7, 2023

    @parasharrajat
    Member

    [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: #18522
    [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/18522/files#r1220854240

    [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: There is no need for any discussion on this issue. It is a simple translation-related change.

    [@parasharrajat] Determine if we should create a regression test for this bug. Yes

    [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. #19467 (comment)

  16. parasharrajat commented on Jun 7, 2023

    @parasharrajat
    Member

    Regression Test Steps

    1. Open a Chat on the App.
    2. Send an Attachment to the user.
    3. Click on "Reply in thread" on the attachment.
    4. Check the Attachment related thread chat in LHN.
    5. Go to Settings > Preferences > Language.
    6. Select the Spanish language and go back.
    7. Check the Attachment thread in LHN and the report title for the thread.

    Do you agree 👍 or 👎 ?

  17. maddylewis commented on Jun 7, 2023

    @maddylewis
    Contributor

    Added regression test proposal to for Applause to add to Test Rail. Just waiting for @parasharrajat to accept the offer so i can process payment :)

  18. maddylewis commented on Jun 8, 2023

    @maddylewis
    Contributor

    paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ImprovementItem broken or needs improvement.InternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions