[HOLD for payment 2023-06-13] [$1000] Workspace - The empty loading chats are shown in the half part of the screen and the other half is blank

@priya-zha

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Go to staging dot on chrome
Go offline
Create a workspace
Go to announce and send any message
Reply in the same thread
Notice that the 3 loading chats are shown and all the remaining are black blank that makes it look weird
Now go online
Notice that the loading chats are shifted above and the remaining down portion are plain black and doesn't go away until you refresh the page

Expected Result:

The loading chats should not be shown in the half part of the screen that makes it look weird.

Actual Result:

The loading chats are shown in the half part of the screen and the other half is blank

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.17.0

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

error-2023-05-18_20.11.50.mp4

Recording.2798.mp4

Expensify/Expensify Issue URL:

Issue reported by: @priya-zha

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684420395406219

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0144bfc6df266a73d1
Upwork Job ID: 1661207831671959552
Last Price Increase: 2023-05-24

@jliexpensify

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

I can reproduce this on Staging:

I would also add to this behaviour and say that when you go back online, the Workspace's #annoucne room doesn't reflect what it should be.

This is what I see when I immediately go back online:

This is what I see when I refresh/what it should look like:

Job added to Upwork: https://www.upwork.com/jobs/~0144bfc6df266a73d1

@jliexpensify

Current assignee @jliexpensify is eligible for the External assigner, not assigning anyone new.

@s77rt

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@marcochavezf

Triggered auto assignment to @marcochavezf (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.24-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix 19490 empty loading chats are shown in the half part of screen #19580

If no regressions arise, payment will be issued on 2023-06-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@s77rt

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@s77rt] The PR that introduced the bug has been identified. Link to the PR:
[@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@s77rt] Determine if we should create a regression test for this bug.
[@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

The PR that introduced the bug has been identified: New Thread Report Empty State, Header, LHN, OpenReport, Buttons for DEV #18522
The offending PR has been commented on: New Thread Report Empty State, Header, LHN, OpenReport, Buttons for DEV #18522 (comment)
A discussion in #expensify-bugs has been started: I don't feel there is much to discuss here, the bug is an edge case and the offending PR was prioritised to be merged within a deadline thus some offline tests were missed
Determine if we should create a regression test for this bug: No

@marcochavezf

@marcochavezf couple of questions for you:

Is no regression test ok?
It looks like the iOS and Android deploys for this PR were cancelled, this shouldn't be an issue for payments right?

If not, I'll pay $1000 to both @tienifr and @s77rt .

@marcochavezf

Bump @marcochavezf to the above questions!

@jliexpensify

Hi @jliexpensify, yeap, it's fine

Everyone has been hired! Thanks Marco.

Everyone's paid, job closed. Cheers!

Navigation Menu

Repository navigation

[HOLD for payment 2023-06-13] [$1000] Workspace - The empty loading chats are shown in the half part of the screen and the other half is blank #19490

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

14 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-06-13] [$1000] Workspace - The empty loading chats are shown in the half part of the screen and the other half is blank #19490

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on May 23, 2023

melvin-bot commented on May 23, 2023

Bug0 Triage Checklist (Main S/O)

jliexpensify commented on May 24, 2023

melvin-bot commented on May 24, 2023

melvin-bot commented on May 24, 2023

melvin-bot commented on May 24, 2023

melvin-bot commented on May 24, 2023

14 remaining items

melvin-bot commented on Jun 6, 2023

melvin-bot commented on Jun 6, 2023

melvin-bot commented on Jun 6, 2023

s77rt commented on Jun 6, 2023

jliexpensify commented on Jun 14, 2023

jliexpensify commented on Jun 14, 2023

marcochavezf commented on Jun 15, 2023

jliexpensify commented on Jun 15, 2023

jliexpensify commented on Jun 17, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions