You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[WAITING ON MIROSLAV FOR PAYMENT] [HOLD for payment 2023-08-28] [$1000] IOS - New contact method - "New contact method" button abrupt animation when tap on email #19530
Please re-state the problem that we are trying to solve in this issue.
IOS - New contact method - "New contact method" button abrupt animation when tap on email
What is the root cause of that problem?
After click the contact methods, our app is navigating to Contact Method Detail page, and the keyboard opened, this also make the current page (which is not fully unmounted) push the bottom button since it's still navigating.
What changes do you think we should make in order to solve the problem?
We should wait for the transition ended and then rendered the content of Contact Detail Page, we can avoid this issue.
So we can add onEntryTransitionEnd function inside ContactMethodDetailsPage like this:
Depends on the requirement, we can decide to show loading or skeleton, or wait for transition end and focus or render the magic code input.
What alternative solutions did you explore? (Optional)
Instead of adding condition inside onEntryTransitionEnd in every screen, we can also update the ScreenWrapper that will show the loading until transition ended.
So we will need to add a new props called shouldShowLoadingWhileTransitioning to our ScreenWrapper, and also updated the ScreenWrapper render condition.
yes it's related but this is more like polish than bug.
This comes from immediate auto-focus of magic input.
But I believe this behavior existed before that PR (magic code implementation) as seen in video:
Screen.Recording.2023-05-26.at.5.24.28.AM.mov
If this is worth fixing, I am happy to take this one as C+.
This is definitely worth fixing, I'm a bit confused by the proposal, though. It looks like this behavior is happening in multiple places (the new contact method and the entering of the magic code). Is the proposal for fixing this in all places, or only in one place? I think we should be fixing this in all places.
My proposal only fixed it in this screen. Yeah, there're other screen with similar behavior, they are doing similar thing as this proposal, but in stead of show loading, they are waiting for transition end and focus the ref.
Thanks, I'll close it to avoid others not getting GH emails. Can you please tag me in this GH when you're ready and I will finalise payment in Upworks? Thanks!
Activity
melvin-bot commentedon May 24, 2023
Triggered auto assignment to @jliexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon May 24, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)hungvu193 commentedon May 24, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
IOS - New contact method - "New contact method" button abrupt animation when tap on email
What is the root cause of that problem?
After click the contact methods, our app is navigating to Contact Method Detail page, and the keyboard opened, this also make the current page (which is not fully unmounted) push the bottom button since it's still navigating.
What changes do you think we should make in order to solve the problem?
We should wait for the transition ended and then rendered the content of Contact Detail Page, we can avoid this issue.
So we can add
onEntryTransitionEndfunction insideContactMethodDetailsPagelike this:and update the content of it like this:
Depends on the requirement, we can decide to show loading or skeleton, or wait for transition end and focus or render the magic code input.
What alternative solutions did you explore? (Optional)
Instead of adding condition inside
onEntryTransitionEndin every screen, we can also update the ScreenWrapper that will show the loading until transition ended.So we will need to add a new props called
shouldShowLoadingWhileTransitioningto our ScreenWrapper, and also updated the ScreenWrapper render condition.Result:
Screen.Recording.2023-05-24.at.22.51.37.mov
jliexpensify commentedon May 26, 2023
Hi @0xmiroslav - @kbecciv stated this was related to your PR #19040
Could you have a look at this issue? Cheers!
0xmiroslav commentedon May 26, 2023
yes it's related but this is more like polish than bug.
This comes from immediate auto-focus of magic input.
But I believe this behavior existed before that PR (magic code implementation) as seen in video:
Screen.Recording.2023-05-26.at.5.24.28.AM.mov
If this is worth fixing, I am happy to take this one as C+.
jliexpensify commentedon May 26, 2023
Thanks! @joelbettner do you mind weighing in if this is worth fixing?
joelbettner commentedon May 29, 2023
This is definitely worth fixing, I'm a bit confused by the proposal, though. It looks like this behavior is happening in multiple places (the new contact method and the entering of the magic code). Is the proposal for fixing this in all places, or only in one place? I think we should be fixing this in all places.
hungvu193 commentedon May 29, 2023
My proposal only fixed it in this screen. Yeah, there're other screen with similar behavior, they are doing similar thing as this proposal, but in stead of show loading, they are waiting for transition end and focus the ref.
App/src/pages/settings/Profile/Contacts/NewContactMethodPage.js
Lines 112 to 118 in 7930cb5
App/src/pages/settings/Payments/AddPayPalMePage.js
Line 46 in 7930cb5
146 remaining items
jliexpensify commentedon Sep 7, 2023
@0xmiroslav can you accept the offer so I can pay you and close this out? Thanks in advance!
0xmiroslav commentedon Sep 7, 2023
Not ready yet
jliexpensify commentedon Sep 7, 2023
Are you still sorting out your account with Upworks? Is there an ETA on when you might be ready to accept payments?
0xmiroslav commentedon Sep 7, 2023
eta next week
jliexpensify commentedon Sep 14, 2023
@0xmiroslav has your account been sorted out? Can I pay into it now? Cheers.
0xmiroslav commentedon Sep 14, 2023
Still waiting. Thanks for patience
jliexpensify commentedon Sep 18, 2023
@0xmiroslav ready for payment?
0xmiroslav commentedon Sep 18, 2023
Not yet. I am also waiting local accountant. Will keep you updated.
Meanwhile, you can close this GH to be out of track from you.
jliexpensify commentedon Sep 18, 2023
Thanks, I'll close it to avoid others not getting GH emails. Can you please tag me in this GH when you're ready and I will finalise payment in Upworks? Thanks!
Payment summary comment.